Change 441516 had a related patch set uploaded (by Cooltey; owner: Cooltey):
[apps/android/wikipedia@master] [WIP] Prototype 1: Add floating queue element

https://gerrit.wikimedia.org/r/441516

Hi @RHo, what's the expected behaviors to show the Snackbar when having a floating queue view?

Looks like the Snackbar will be covered by the floating queue view. The following screenshot shows a "undo" Snackbar when swiping off cards

In T197811#4306824, @cooltey wrote:

Hi @RHo, what's the expected behaviors to show the Snackbar when having a floating queue view?

Looks like the Snackbar will be covered by the floating queue view. The following screenshot shows a "undo" Snackbar when swiping off cards

Hey @cooltey - the snackbar should push the floating queue element upwards when it appears. See YouTube for the same action:

Thanks, @RHo. Will follow it.

Change 444042 had a related patch set uploaded (by Cooltey; owner: Cooltey):
[apps/android/wikipedia@prototype_floating_queue] [READY] Prototype 1: Add floating queue element

https://gerrit.wikimedia.org/r/444042

Change 441516 abandoned by Cooltey:
[READY] Prototype 1: Add floating queue element

Reason:
Move to prototype_floating_queue branch

https://gerrit.wikimedia.org/r/441516

hi @cooltey - just one thing on the the floating queue bar, is it possible to ensure the elevation is the same as expected for a standard Material 'Dialog'?

At the moment the element looks a bit lost over the feed as it seems like there is insufficient shadow:

Actual:	Expected:

Hi @RHo

I've checked the elevation settings on the prototype, it was set to app:cardElevation="10dp", and it looks like the same when I set it to 20dp or 5dp.

Also, now I am not sure that we can change the shadow's dark level or not.

If you wish to make the shadow darker and it might need to add another layer to the floating queue view to customize the shadow.

In T197811#4482805, @cooltey wrote:

Hi @RHo

I've checked the elevation settings on the prototype, it was set to app:cardElevation="10dp", and it looks like the same when I set it to 20dp or 5dp.

Also, now I am not sure that we can change the shadow's dark level or not.

If you wish to make the shadow darker and it might need to add another layer to the floating queue view to customize the shadow.

Hmm, are you able to explore if there's another attribute that can be set which makes the shadow more apparent when the elevation is changed? It's quite important that we make it more overt for the prototype.
Not sure if it helps but this talks about a fix required so that the elevation change is reflected in the shadow:
https://stackoverflow.com/questions/27477371/android-elevation-not-showing-a-shadow

Also, this demo shows how the changing the elevation should alter the appearance:
https://material.angular.io/guide/elevation

@RHo

I see, thanks for the references.

So far I've noticed that we can make the view shows shadow by using android:elevation or app:cardElevation on the CardView, maybe there's another way to make the shadow more apparent and I will try to approach the expected shadow.

Change 450891 had a related patch set uploaded (by Cooltey; owner: Cooltey):
[apps/android/wikipedia@prototype_floating_queue] UI Tweak to prototype floating queue

https://gerrit.wikimedia.org/r/450891

hi @cooltey - thanks for fixing the shadow, it looks good now! A couple of ever so minor quibbles still:

Actual (Light)	Expected:
Actual (Dark)	Expected:
Actual (Black)	Expected:

• It's expected the Floating queue element should have 2dp rounded corners (Actual: sharp 0dp corners)
• It's expected that on Dark and Black mode the 'frame' icon around the number of tabs should use the same Material theme borders and rules color.

Hi, @RHo

Now I am using the @android:drawable/dialog_holo_light_frame to be the background, which it comes from the android library.

If I set the background color of the children layer to be white, it will make the rounded corners disappear.

But, if I did not set the background color of the children layer to be white, the background would be a little bit greyer (please see the screenshot below)

Does it look good to you?

Hi @cooltey - the screenshot still shows the sharp corners for the left top and bottom parts of the queue element (where the image thumbnail is), and I am not a fan of the semi-transparency. If it is not possible to add rounded corners I would rather we reduce the width of the floating queue element by 16dp as an alternative way to get it to stand up more from the cards.

Ie: Revised Expected:

Light	Dark	Black

Please also note the second point in my previous comment about the open tabs number icon on Dark and Black:

It's expected that on Dark and Black mode the 'frame' icon around the number of tabs should use the same Material theme borders >>and rules color.

Hey @cooltey - an unrelated interaction issue that I just noticed is that the floating queue element is not visible over a reading list. It is expected that the Floating queue element remains visible over a single reading list as well.

Hi, @RHo
Should the floating queue element in the same position as the other screens? or should it be moved to the bottom?

Hi @cooltey, moving to the bottom (with 8dp padding) is preferable, but just having it remain visible is the main thing thanks!

@RHo I see, thanks! Please download the latest version the the prototype one APK to see the updates.

Change 444042 abandoned by Cooltey:
Add floating queue element

Reason:
Move to master branch

https://gerrit.wikimedia.org/r/444042

Change 450891 abandoned by Cooltey:
UI Tweak to prototype floating queue

Reason:
Move to master branch

https://gerrit.wikimedia.org/r/450891

Looking good on the reading lists, thanks @cooltey!