Page MenuHomePhabricator
Create Task
Maniphest T198445

Markers not appearing
Closed, ResolvedPublic
Actions

Assigned To
Mooeypoo
Authored By
Daybeers
Jun 29 2018, 2:46 AM
Tags
Referenced Files
F23075345: Screen Shot 2018-06-29 at 8.50.37 AM.png
Jun 29 2018, 4:00 PM
F23075347: Screen Shot 2018-06-29 at 8.51.14 AM.png
Jun 29 2018, 4:00 PM
F23070471: Screenshot from 2018-06-29 10-30-39.png
Jun 29 2018, 8:36 AM
Subscribers
Aklapper
Catrope
Daybeers
Etonkovidova
gerritbot
kostajh
Mooeypoo
View All 9 Subscribers

Description

  1. Go to https://en.wikipedia.org/
  2. Make sure you are logged in.
  3. Click on "Preferences" in the top right.
  4. Click on the "Beta features" tab, the second from the right.
  5. Enable "New filters for edit review"
  6. Click "Save" at the bottom of the page.
  7. Go to your Watchlist by clicking it on the top right, near "Preferences", or by going to https://en.wikipedia.org/wiki/Special:Watchlist
  8. Change the Active filters so there are only "Page edits", "Page creations", and "Logged actions" left.
  9. Click the bookmark icon on the right side to save the Active filters.
  10. Reload the page, and then select the name you gave those Saved filters from the drop-down menu on the right side.
  11. The blue markers to the left of each diff entry in my Watchlist (which are solid if the change has not yet been viewed and empty if it has) aren't appearing. When the page is loading, they do appear, but only for about half a second, and then once the page has fully loaded, they disappear.

Without New filters:

Screen Shot 2018-06-29 at 8.50.37 AM.png (499×1 px, 170 KB)

With New filters beta feature enabled:

Screen Shot 2018-06-29 at 8.51.14 AM.png (345×1 px, 106 KB)

Details

SubjectRepoBranchLines +/-
RCFilters: Fix highlight container selector in Watchlist overridesmediawiki/corewmf/1.32.0-wmf.10+54 -43
RCFilters: Fix highlight container selector in Watchlist overridesmediawiki/coremaster+54 -43
Customize query in gerrit

Related Objects

Event Timeline

Daybeers created this task.Jun 29 2018, 2:46 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 29 2018, 2:46 AM
Daybeers updated the task description. (Show Details)Jun 29 2018, 4:03 AM
Aklapper changed the task status from Open to Stalled.Jun 29 2018, 8:36 AM

Hi @Daybeers, thanks for taking the time to report this and welcome to Phabricator!
Unfortunately this report lacks some information. Please follow https://www.mediawiki.org/wiki/How_to_report_a_bug and add a more complete description to this report: Either the URL of the website where this problem happens, or the MediaWiki version of your installation.
Ideally, exact and clear steps to reproduce should allow any other person to follow these steps (without having to interpret those steps) and see the same results. Problems that others can reliably reproduce can get fixed faster.

Please also follow https://www.mediawiki.org/wiki/Help:Locating_broken_scripts to see if you get output in the developer tools after disabling gadgets etc.

What I get on https://en.wikipedia.org/wiki/Special:Watchlist in Chromium 67 looks like this (and not blue but green):

Screenshot from 2018-06-29 10-30-39.png (620×769 px, 108 KB)

Daybeers updated the task description. (Show Details)Jun 29 2018, 12:53 PM
Daybeers updated the task description. (Show Details)Jun 29 2018, 12:59 PM

@Aklapper that's because I'm using the improved Watchlist interface, which you can get to by following the steps above.

Daybeers updated the task description. (Show Details)Jun 29 2018, 1:08 PM
kostajh subscribed.Jun 29 2018, 1:21 PM

@Daybeers thank you for filing this report and for the detailed steps to reproduce. This is likely a side effect from the work we we deployed for T197168. I'll look into this today.

kostajh claimed this task.Jun 29 2018, 1:22 PM
kostajh reassigned this task from kostajh to Mooeypoo.Jun 29 2018, 3:54 PM
kostajh added a subscriber: Mooeypoo.

@Mooeypoo assigning the task to you as you're working on the patch.

matmarex changed the task status from Stalled to Open.Jun 29 2018, 3:59 PM
matmarex merged a task: T198496: [wmf.10-regression] Watchlist with filters does not display bullet points .
matmarex updated the task description. (Show Details)
matmarex added subscribers: Etonkovidova, Catrope.
Mooeypoo added a comment.Jun 29 2018, 4:03 PM
In T198445#4325599, @kostajh wrote:

@Mooeypoo assigning the task to you as you're working on the patch.

Yup, I'm working on it now. Found the culprit, cleaning it up and testing, will have the patch up soon.

Etonkovidova merged a task: T198496: [wmf.10-regression] Watchlist with filters does not display bullet points .Jun 29 2018, 4:03 PM
gerritbot subscribed.Jun 29 2018, 4:21 PM

Change 443110 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[mediawiki/core@master] RCFilters: Fix highlight container selector in Watchlist override

https://gerrit.wikimedia.org/r/443110

gerritbot added a project: Patch-For-Review.Jun 29 2018, 4:21 PM
Mooeypoo added a project: Collaboration-Team-Triage (Collab-Team-This-Quarter).Jun 29 2018, 6:56 PM
Mooeypoo moved this task from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
AfroThundr3007730 mentioned this in T198513: Watchlist bullets missing colors.Jun 29 2018, 8:39 PM
gerritbot added a comment.Jun 29 2018, 9:03 PM

Change 443110 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Fix highlight container selector in Watchlist overrides

https://gerrit.wikimedia.org/r/443110

Mooeypoo moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Jun 30 2018, 3:37 AM
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jun 30 2018, 8:01 PM
gerritbot added a comment.Jul 2 2018, 12:18 PM

Change 443411 had a related patch set uploaded (by Sbisson; owner: Mooeypoo):
[mediawiki/core@wmf/1.32.0-wmf.10] RCFilters: Fix highlight container selector in Watchlist overrides

https://gerrit.wikimedia.org/r/443411

gerritbot added a comment.Jul 2 2018, 1:16 PM

Change 443411 merged by jenkins-bot:
[mediawiki/core@wmf/1.32.0-wmf.10] RCFilters: Fix highlight container selector in Watchlist overrides

https://gerrit.wikimedia.org/r/443411

Stashbot subscribed.Jul 2 2018, 1:29 PM

Mentioned in SAL (#wikimedia-operations) [2018-07-02T13:29:41Z] <hashar@deploy1001> Synchronized php-1.32.0-wmf.10/resources/src/mediawiki.rcfilters/styles/: RCFilters: Fix highlight container selector in Watchlist overrides - T198445 (duration: 00m 51s)

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)); removed MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jul 2 2018, 2:00 PM
SBisson subscribed.Jul 2 2018, 2:38 PM

The fix was deployed to production this morning.

Etonkovidova added a comment.EditedJul 2 2018, 4:58 PM

Checked in wmf.10 along with two more fixes - T198513: Watchlist bullets missing colors and T198440: Changes shifted down on Special:RecentChanges and Special:Watchlist - the markers are displayed on Watchlist and they are solid (or highlighted) according to the selected options and of seen/unseen status.

Etonkovidova closed this task as Resolved.Jul 2 2018, 4:58 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL