Maniphest T198619

Send the Accept-Language header with RESTBase API request for page preview requests
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	phuedx
	Jul 2 2018, 11:41 AM

Description

Background

From T188164#4324348:

Per discussion on the Audiences-Services sync meeting, the initial step on the Page-Previews side could be to just explicitly set the Accept-Language header to the current wiki language code with no variant.

AIUI doing so will unblock Services rolling out language variant support for RESTBase and the Page Summary endpoint in particular. Moreover, landing language variant support for that endpoint will unblock T111231: Page previews for Wikidata (blocked by T198465: Enable language variants support for summary amongst others).

AC

When Page Previews makes a request to the Page Summary endpoint:
- It includes the Accept-Language header
- The value of the Accept-Language header is the current wiki's language code verbatim, i.e. $wgContentLanguage.

Notes

MediaWiki's language codes differ from ISO language codes in a number of different cases. Use the MediaWiki-provided language code (wgPreferredVariant) as that'll be handed to Parsoid/MediaWiki and that's what they understand.

See T198619#4387451, for additional detail about why this is important.

QA steps

On https://en.wikipedia.beta.wmflabs.org/wiki/Category:Page_Previews hover over a link. Inspect the developer tools "network" tab to ensure that the request made to the rest api has Accept-language set to "en".
Visit https://zh.wikipedia.beta.wmflabs.org/wiki/Special:AllPages. API requests caused by hovering over links should send requests where Accept-language set to "zh"
Visit https://zh.wikipedia.beta.wmflabs.org/wiki/Special:%E5%8F%82%E6%95%B0%E8%AE%BE%E7%BD%AE set language in 2nd drop down to zh-HK
Now when triggering a page preview API requests should besent with Accept-language set to "zh-HK"
Note: In all of the above there should be no difference in the display of page previews

Details

	Subject	Repo	Branch	Lines +/-
	Send the Accept-Language header when calling API	mediawiki/extensions/Popups	master	+28 -14

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		• Pchelolo	T188164 Popups don‘t support language variant conversion and {{lang}} template
		Resolved		ABorbaWMF	T198619 Send the Accept-Language header with RESTBase API request for page preview requests

Event Timeline

phuedx created this task.Jul 2 2018, 11:41 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 2 2018, 11:41 AM

phuedx mentioned this in T188164: Popups don‘t support language variant conversion and {{lang}} template.Jul 2 2018, 11:42 AM

phuedx added a parent task: T188164: Popups don‘t support language variant conversion and {{lang}} template.

• Pchelolo added a project: Services (blocked).Jul 2 2018, 11:43 AM

• Pchelolo awarded a token.

pmiazga subscribed.Jul 2 2018, 12:20 PM

ovasileva triaged this task as Medium priority.Jul 2 2018, 2:01 PM

ovasileva moved this task from Incoming to Upcoming on the Web-Team-Backlog board.Jul 2 2018, 3:07 PM

Isn't Accept-Language sent automatically from the browser passing the default language of said browser...?

MediaWiki's language codes differ from ISO language codes in a number of different cases. Use the MediaWiki-provided language code as that'll be handed to Parsoid/MediaWiki and that's what they understand.

Because https://phabricator.wikimedia.org/T198619#4387117 I think this logic should live in the services layer tbh.

In T198619#4387117, @Jdlrobson wrote:

Isn't Accept-Language sent automatically from the browser passing the default language of said browser...?

It is and that is the problem for us in many ways:

It will split the cache - the wikis that support variants will set vary: accept-language, so if a person with en as a default language comes to serbian wiki - everything will become pretty slow for him

Browser default variant might be VERY much not what we want to set. Just as example: in MW for Serbian sr is no variant, sr-el is latin serbian and sr-ec is Cyrillic. The actual standard have sr, sr-latn and sr-cyrl. However Safari sets just sr for latin Serbian and sr-cr for Cyrillic, which is not only not following any standard, but also clashes with Mediawiki no-variant and that's just one example I found, I'm sure there's more. So I think we should control what exactly we send, not let the browser do it.

Depending on product decision we might want to send something other then what the user's browser setting are. For example, user preferred variant, or the variant currently selected for the particular article the user is reading now.

Thanks for explaining this. This makes a lot more sense now with this context!

phuedx updated the task description. (Show Details)Jul 2 2018, 4:16 PM

ovasileva raised the priority of this task from Medium to High.Jul 3 2018, 2:02 PM

Jdlrobson renamed this task from Send the Accept-Language header with RESTBase API request to Send the Accept-Language header with RESTBase API request for page preview requests.Jul 3 2018, 4:13 PM

Jdlrobson updated the task description. (Show Details)Jul 3 2018, 4:17 PM

pmiazga set the point value for this task to 2.Jul 3 2018, 4:22 PM

Jdlrobson added a project: Readers-Web-Kanbanana-Board-Old.Jul 3 2018, 5:29 PM

Jdlrobson moved this task from Upcoming to 2017-18 Q4 on the Web-Team-Backlog board.Jul 3 2018, 6:16 PM

MBinder_WMF moved this task from 2017-18 Q4 to Current Sprint (and resolved 2018-19 Q1) pre-milestone on the Web-Team-Backlog board.Jul 3 2018, 6:55 PM

pmiazga claimed this task.Jul 3 2018, 9:03 PM

pmiazga moved this task from To Do to Doing on the Readers-Web-Kanbanana-Board-Old board.

Change 443746 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/extensions/Popups@master] Send the Accept-Language header when calling API

https://gerrit.wikimedia.org/r/443746

gerritbot added a project: Patch-For-Review.Jul 3 2018, 10:31 PM

pmiazga removed pmiazga as the assignee of this task.Jul 3 2018, 10:31 PM

pmiazga moved this task from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.

I switched my local wiki to Chinese and chose Chinese HK as my variant language

Screen Shot 2018-07-03 at 3.57.06 PM.png (327×726 px, 55 KB)

Variant is set correctly in header

Jdlrobson moved this task from Needs Code Review to Needs Design Review on the Readers-Web-Kanbanana-Board-Old board.Jul 5 2018, 6:40 PM

Change 443746 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Send the Accept-Language header when calling API

https://gerrit.wikimedia.org/r/443746

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jul 5 2018, 7:00 PM

Jdlrobson updated the task description. (Show Details)Jul 5 2018, 8:28 PM

Restricted Application added a subscriber: Stang. · View Herald TranscriptJul 5 2018, 8:28 PM

Alex probably nothing for you to care about here, but offering this to you just in case :)

pmiazga removed a project: Patch-For-Review.Jul 5 2018, 9:24 PM

Shizhao added a project: Chinese-Sites.Jul 6 2018, 3:52 AM

Shizhao moved this task from Backlog to MediaWiki core on the Chinese-Sites board.

Liuxinyu970226 subscribed.Jul 6 2018, 3:56 AM

Jdforrester-WMF subscribed.Jul 6 2018, 6:13 PM

@Jdlrobson ok going to pass over to Anthony. FYI I'm not seeing any page previews, or network requests, when I hover over links on https://en.wikipedia.beta.wmflabs.org/wiki/Special:AllPages

Jdlrobson updated the task description. (Show Details)Jul 11 2018, 8:33 PM

I can see that the a header is set to sr on Cerbian wiki - bravo, that unblocks us from deploying the language variants for the summary endpoint and if I change my preferences I can see sr-ec and sr-el. Thank you, I think this could be resolved.

Per T198619#4420254.

Shizhao moved this task from MediaWiki core to Closed on the Chinese-Sites board.Jul 13 2018, 3:50 AM

Liuxinyu970226 unsubscribed.Jul 14 2018, 3:30 AM

• Phabricator_maintenance edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1); removed Web-Team-Backlog.Sep 13 2018, 6:39 PM

Stang unsubscribed.Nov 13 2021, 8:51 PM

	F23360955: Screen Shot 2018-07-05 at 11.38.03 AM.png
	Jul 5 2018, 6:38 PM

	F23360872: Screen Shot 2018-07-03 at 3.57.06 PM.png
	Jul 5 2018, 6:38 PM

Send the Accept-Language header with RESTBase API request for page preview requestsClosed, ResolvedPublic2 Estimated Story PointsActions