| KaMan | |
| Jul 12 2018, 7:24 AM |
| F28681470: image.png | |
| Apr 16 2019, 9:14 PM |
| F28681460: image.png | |
| Apr 16 2019, 9:14 PM |
| F23718537: hover.png | |
| Jul 13 2018, 4:49 PM |
| F23661690: hidden-suggester.png | |
| Jul 12 2018, 7:24 AM |
Problem:
When the suggester for the language field is opened on Special:NewLexeme parts of the suggester are behind the SpecialPage tab at the top of the screen.
Screenshots/mockups:
Acceptance criteria:
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Michael | T199409 [Bug] NewLexeme suggester menu appears behind special page tab | |||
| Resolved | Michael | T222444 Create new wdio-wikibase release |
This is happenning due to z-index being set to 0 on an ancestor html element div.mw-body-content.
in screenshots:
if that z-index is removed
question is why that z-index was set to 0. If we cannot remove it, I'm afraid the only solution is to change OOUI widget used here so that it moves the popup element as a direct child of body (usual solution for in popup libraries to avoid this problem) which is not a small thing and not in our scope.
So our options:
Let's try the first and investigate/get-feedbcak on it first?
The z-index: 0 has been deliberately done in https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/178086 to mitigate a security issue: T40848
Other special pages which would face the same problem, e.g. https://de.wikipedia.org/wiki/Spezial:Aktive_Benutzer, seemed to have solved this issue by using a different OOUI widget that already implements the suggested behavior.
In principle, the option to move the popup into an extra overlay already exists: https://www.mediawiki.org/wiki/OOUI/Concepts#Overlays
The challenge is now to find where to set this option.
Change 504569 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/WikibaseLexeme@master] Use default overlay for language selector widget
Change 504626 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] Adjust wikibase-wdio for Lexeme change
Change 505698 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] Add method to be used for multi selects
Change 505700 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/WikibaseLexeme@master] Use specialised function in browser test
Change 505698 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add method to be used for multi selects
Change 505700 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Use specialised function in browser test
Change 504626 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Adjust wikibase-wdio for Lexeme change
Change 504569 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Use default overlay for item selector widget
