Maniphest T199617

Link to edit the label overlaps with the label
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Trizek-WMF
	Jul 14 2018, 12:32 PM

Description

I have seen that case of overlapping on fr.wp while editing as a volunteer, using Firefox:

From https://fr.wikipedia.org/wiki/Guillaume_Desboys?veaction=edit:

Capture d’écran_2018-07-14_14-29-59.png (221×430 px, 37 KB)

That overlapping varies depending on something I can't identify. See that example from https://fr.wikipedia.org/wiki/Jehan_Grahant?veaction=edit:

Capture d’écran_2018-07-14_14-21-54.png (225×427 px, 35 KB)

Also, have the "label" title and the editing link bolder than the label itself makes that label difficult to read:

Capture d’écran_2018-07-14_14-28-04.png (198×419 px, 23 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Update VE core submodule to master (44556e8fd)	mediawiki/extensions/VisualEditor	master	+1 -1
	Fix clipping on label preview in link context	VisualEditor/VisualEditor	master	+6 -1

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	• Deskana	T55973 VisualEditor: Link input widget should have separate inputs for target and display text
Resolved	DLynch	T124305 Users sometimes struggle to select the text of the link anchor within the cartouche and so delete it on select-retype
Resolved	• ppelberg	T199617 Link to edit the label overlaps with the label

Event Timeline

Trizek-WMF triaged this task as Medium priority.Jul 14 2018, 12:32 PM

Trizek-WMF created this task.

Restricted Application added a project: VisualEditor. · View Herald TranscriptJul 14 2018, 12:32 PM

Trizek-WMF raised the priority of this task from Medium to Needs Triage.Jul 14 2018, 12:32 PM

Cirdan merged a task: T200038: If the link label is too long, label edit link is not shown.Jul 19 2018, 6:56 PM

Cirdan subscribed.

Esanders mentioned this in T201232: Clicking the "Change label" button needs to give the user clearer feedback.Aug 8 2018, 3:13 PM

Thanks for bringing this up @Trizek-WMF - I agree with your observations.
To clarify, there seem to be two issues:

The edit label overlap - this feels like there needs to be a rule in place for after the ellipsis a space needs to be inserted - but as this seems to be happening inconsistently, I would imagine that there is something going on with the styling. I might be missing something more technical that is happening.

The styling of the label title - There are a lot of bold elements here competing for your attention so we should review the typographic hierarchy at some point.

cc/ @Volker_E - you might have more thoughts on this and be better able to address how to triage.

Trizek-WMF updated the task description. (Show Details)Aug 21 2018, 1:11 PM

Change 517099 had a related patch set uploaded (by Bartosz Dziewoński; owner: Esanders):
[VisualEditor/VisualEditor@master] Fix clipping on label preview in link context

https://gerrit.wikimedia.org/r/517099

gerritbot added a project: Patch-For-Review.Jun 14 2019, 7:50 PM

@Esanders rediscovered this issue while working on changes to contexts on mobile:

IMG_F85529B9844E-1.jpeg (2×1 px, 559 KB)

matmarex moved this task from Incoming to Code review on the VisualEditor (Current work) board.Jun 14 2019, 7:52 PM

Change 517099 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Fix clipping on label preview in link context

https://gerrit.wikimedia.org/r/517099

Before	After

Ryasmeen added a project: Verified.Jun 14 2019, 8:08 PM

Change 517137 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (44556e8fd)

https://gerrit.wikimedia.org/r/517137

gerritbot added a project: Patch-For-Review.Jun 14 2019, 8:57 PM

Change 517137 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (44556e8fd)

https://gerrit.wikimedia.org/r/517137

Ryasmeen mentioned this in T221311: Mobile edit cards: pre-deployment QA "adding/modifying links".Jun 14 2019, 9:40 PM

matmarex added a project: Editing QA.Jun 14 2019, 9:41 PM

(oops, was already marked as Verified)

Maintenance_bot removed a project: Patch-For-Review.Jun 14 2019, 10:10 PM

@iamjessklein The prioritization and organization improves with your current, scheduled work on the mobile link editing dialog. Any plans to take the good parts from there?

yes, I believe that this is going to be captured in T225725

cc/ @ppelberg

Trizek-WMF awarded a token.Jun 20 2019, 8:45 AM

In T199617#5260212, @Volker_E wrote:

@iamjessklein The prioritization and organization improves with your current, scheduled work on the mobile link editing dialog. Any plans to take the good parts from there?

! In T199617#5262963, @iamjessklein wrote:
yes, I believe that this is going to be captured in T225725

cc/ @ppelberg

@iamjessklein + @Volker_E: y'all are talking about extending the work we are doing on the mobile context items (see T225725) to the desktop context items? If so, then yep, this is our plan.

The conversation about how exactly the designs will be implemented on desktop is happening in this ticket: T226214

• ppelberg closed this task as Resolved.Aug 6 2019, 2:15 AM

• ppelberg claimed this task.

	F23750938: Capture d’écran_2018-07-14_14-28-04.png
	Jul 14 2018, 12:32 PM

	F23750941: Capture d’écran_2018-07-14_14-29-59.png
	Jul 14 2018, 12:32 PM

	F23750936: Capture d’écran_2018-07-14_14-21-54.png
	Jul 14 2018, 12:32 PM

	F29547495: image.png
	Jun 14 2019, 7:55 PM

	F29547481: image.png
	Jun 14 2019, 7:55 PM

Link to edit the label overlaps with the labelClosed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

Link to edit the label overlaps with the label
Closed, ResolvedPublic
Actions

Related Objects
Search...