Page MenuHomePhabricator

Syntax highlighter disables Undo button in 2010 wikitext editor
Open, Stalled, LowestPublic

Description

User:Jweiss11 has reported a problem with the syntax highlighter interfering with the Undo button in the 2010 WikiEditor.

The user reports that this happens in Google Chrome Version 67.0.3396.99 (Official Build) (64-bit) and in Firefox, both on Windows 10 Home.

Steps to reproduce:

  1. Open a page to edit.
  2. Enable the syntax highlighter (click the icon in the toolbar).
  3. Make a change.
  4. Discover that the 'Undo' button (the browser menu item) doesn't work any more.

I can't reproduce this in Safari, but I can reproduce it in Chrome and Firefox on a Mac.

Workaround:

Turn off syntax highlighting if you want to be able to undo your typing.

Event Timeline

Restricted Application added a project: Community-Tech. · View Herald TranscriptJul 24 2018, 5:02 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Niharika added a subscriber: Niharika.

I can reproduce this but the keyboard shortcut Ctrl/Cmd+Z works for me.

I suspect fixing the menu item to work is going to be very hard with the current state of CodeMirror.

TheDJ added a subscriber: TheDJ.Jul 30 2018, 9:26 PM

Lol, i've been hearing about this issue a lot, and never thought to check the menu... I don't think I can remember the last time I used a menu for undo. Shows you how fixed you can be into a pattern that other users might not be into.

Safari too for me (latest version on macOS); the Undo menu item is non-functional when the syntax highlighter (CodeMirror) is on, just like with the other browsers.

This is an known upstream issue, for which there is no workaround, because browsers don't support this level of integration with the pasteboard yet.

https://github.com/codemirror/CodeMirror/issues/4809
https://github.com/codemirror/CodeMirror/blob/master/doc/manual.html#L968

TheDJ changed the task status from Open to Stalled.Nov 13 2018, 1:20 PM
TheDJ triaged this task as Lowest priority.
TheDJ moved this task from Backlog to Reported Upstream on the Upstream board.