Page MenuHomePhabricator

[subtask] Various page issues events sending NaN for sectionNumbers in old treatment
Closed, ResolvedPublic0 Story Points

Description

There is an additional bug in the page issues treatment.

Visit http://localhost:8888/w/index.php/Pharmacovigilance in old treatment. (pageLoaded event is fired with sectionNumbers =[0])
Click "Page issues" (issuesClicked event is fired with sectionNumbers =[0])

Cmd+click "improve this article" in a new tab
Cmd+click "verification" link to open in a new tab
Close the overlay
Click "page issues" link again.

Expected:
sectionNumbers is sent with the value [0] for all events

Actual:
The correct value is only sent for pageLoaded and issueClickedEvents

Details

Related Gerrit Patches:
mediawiki/skins/MinervaNeue : masterDon't send NaN as a value for sectionNumbers

Event Timeline

Jdlrobson triaged this task as High priority.Aug 27 2018, 9:04 PM
Jdlrobson created this task.
Jdlrobson changed the point value for this task from 5 to 0.

Change 455730 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Don't send NaN as a value for sectionNumbers

https://gerrit.wikimedia.org/r/455730

Change 455730 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Don't send NaN as a value for sectionNumbers

https://gerrit.wikimedia.org/r/455730

Jdrewniak closed this task as Resolved.Aug 31 2018, 5:50 PM

reviewed this today with @Tbayer and agreed that this can be closed out since the error was not occurring on staging anymore.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptAug 31 2018, 5:50 PM