Page MenuHomePhabricator

New Pages Feed: filter logic inconsistent for "Were created by bots"
Closed, ResolvedPublic

Description

In T199277, the logic for how the selected filters are displayed changed. There is an inconsistency in the logic that should be fixed. I see this behavior in Test Wiki and in English Wikipedia right now.

When items under the "That:" filter are selected, they should be appended to the logic list without any parentheses, like in the image below. "Were created by blocked users" is selected, and "By blocked users" is at the end of the logic list.

But when I select "Were created by bots", it puts "bots" in the parentheses with "State".

Instead, it should be saying "By bots" at the end of the logic list.

Event Timeline

Change 458578 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/PageTriage@master] Show "by bots" at the right place in the filters summary

https://gerrit.wikimedia.org/r/458578

SBisson claimed this task.Sep 6 2018, 7:56 PM

Sorry, I know this cookie was licked but I came across this while working on something else and I couldn't not fix it.

Change 458578 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Show "by bots" at the right place in the filters summary

https://gerrit.wikimedia.org/r/458578

Etonkovidova closed this task as Resolved.Sep 15 2018, 12:15 AM

Checked the fix in betalabs.