fixcopyright wiki translations are missing some messages
Closed, ResolvedPublic

Description

E.g. compare fixcopyright:MediaWiki:Eucc-option-protect-public-domain-text-v3/hu with translatewiki:MediaWiki:Eucc-option-protect-public-domain-text-v3/hu. All the Hungarian translations were added by L10n-bot in one go a day ago, and they do include the correct translation so this is some kind of l10n cache problem.

Apparently these affects all translations except en, de, fr, es (so 10 languages).

Tgr created this task.Sep 11 2018, 5:46 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 11 2018, 5:46 AM
Tgr renamed this task from Hungarian translation for fixcopyright wiki is out of date to Hungarian translation for fixcopyright wiki is missing some messages.Sep 11 2018, 5:46 AM

The source string has changed:
https://fixcopyright.wikimedia.org/wiki/MediaWiki:Eucc-option-protect-public-domain-text-v3/en
https://translatewiki.net/wiki/MediaWiki:Eucc-option-protect-public-domain-text-v3/en

LU skips those messages as it cannot know they are compatible. The patch that changed English strings should have SWATed to prevent this from happening.

Tgr renamed this task from Hungarian translation for fixcopyright wiki is missing some messages to fixcopyright wiki translations are missing some messages.Sep 11 2018, 6:39 AM
Tgr updated the task description. (Show Details)
Tgr triaged this task as Unbreak Now! priority.Sep 11 2018, 6:45 AM

Yeah, the English (and de/fr/es) translations were apparently updated to add amendment numbers which needed to happen quickly.

I tried using <messagename>/en as a less destructive override mechanism but unfortunately that doesn't work. The related MediaWiki issue is T3495: Improve message source fallback flow I guess?

Marking UBN as this causes most languages to have mixed local and English content on a wiki that's running the last day of an outreach campaign.

Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptSep 11 2018, 6:45 AM

Change 459681 had a related patch set uploaded (by Gergő Tisza; owner: L10n-bot):
[mediawiki/extensions/EUCopyrightCampaign@master] Localisation updates from https://translatewiki.net.

https://gerrit.wikimedia.org/r/459681

We have less than 30 hours until the vote, the page is broken in all but three languages and as far as I can tell everyone involved in the project is based in the US and unavailable as it's between 0-3 AM there. I'll deploy the latest translations from translatewiki and hope for the best - that circumvents whatever legal review process is being used to vet the text but that seems like the lesser evil at this point. Problematic text can be reverted later.

Pinging people for awareness: @greg @CCicalese_WMF WMF-Legal

Tgr added a subscriber: Legoktm.EditedSep 11 2018, 7:53 AM

Plan (per IRC discussion with @Legoktm):

Change 459680 had a related patch set uploaded (by Gergő Tisza; owner: L10n-bot):
[mediawiki/skins/EUCopyrightCampaignSkin@master] Localisation updates from https://translatewiki.net.

https://gerrit.wikimedia.org/r/459680

Change 459681 merged by jenkins-bot:
[mediawiki/extensions/EUCopyrightCampaign@master] Localisation updates from https://translatewiki.net.

https://gerrit.wikimedia.org/r/459681

Change 459680 merged by jenkins-bot:
[mediawiki/skins/EUCopyrightCampaignSkin@master] Localisation updates from https://translatewiki.net.

https://gerrit.wikimedia.org/r/459680

Change 459741 had a related patch set uploaded (by Gergő Tisza; owner: L10n-bot):
[mediawiki/skins/EUCopyrightCampaignSkin@wmf/1.32.0-wmf.20] Localisation updates from https://translatewiki.net.

https://gerrit.wikimedia.org/r/459741

Tgr added a comment.Sep 11 2018, 9:13 AM

cherry-pick all localization changes to wmf.20 (or maybe just create a patch which updates /i18n to the master version) and merge

Used git cherry wmf/1.32.0-wmf.20 master to make a list and discarded those which touched non-i18n files (except 2737a3c which later changes depended on and seemed harmless). The result:

EUCopyrightCampaign:

4e2a358 Localisation updates from https://translatewiki.net.
40ef3d1 Add warning translations in case browser cannot invoke email application.
012563d Add warning in case browser cannot invoke email application.
e1b6406 Localisation updates from https://translatewiki.net.
af5f53a Update English call script and email sections with updated information..
42cf683 Fix error in wording in translations.
b2c4c83 Fix error in wording.
5ccc339 Localisation updates from https://translatewiki.net.
2737a3c Remove unused messages and help greppers with comments
b040b8a [IMPORTANT] Fix link to fixcopyright domain
0128577 Localisation updates from https://translatewiki.net.
8f7b9cf Tweak English wording.

EUCopyrightCampaignSkin:

d71e816 Localisation updates from https://translatewiki.net.
5dcce78 Note logo text that should not be translated.
09fc11e Localisation updates from https://translatewiki.net.
fb774dc Localisation updates from https://translatewiki.net.
65e711b Localisation updates from https://translatewiki.net.

Change 459753 had a related patch set uploaded (by Gergő Tisza; owner: L10n-bot):
[mediawiki/extensions/EUCopyrightCampaign@wmf/1.32.0-wmf.20] Localisation updates from https://translatewiki.net.

https://gerrit.wikimedia.org/r/459753

Change 459741 merged by jenkins-bot:
[mediawiki/skins/EUCopyrightCampaignSkin@wmf/1.32.0-wmf.20] Localisation updates from https://translatewiki.net.

https://gerrit.wikimedia.org/r/459741

Change 459753 merged by jenkins-bot:
[mediawiki/extensions/EUCopyrightCampaign@wmf/1.32.0-wmf.20] Localisation updates from https://translatewiki.net.

https://gerrit.wikimedia.org/r/459753

Mentioned in SAL (#wikimedia-operations) [2018-09-11T09:59:24Z] <tgr@deploy1001> Started scap: T204018 update i18n on fixcopyrightwiki

Mentioned in SAL (#wikimedia-operations) [2018-09-11T10:30:25Z] <tgr@deploy1001> Finished scap: T204018 update i18n on fixcopyrightwiki (duration: 31m 01s)

Tgr added a comment.Sep 11 2018, 10:33 AM
tgr@mwmaint1001:~$ mwscript deleteEqualMessages.php fixcopyrightwiki --delete
Checking for pages with default message...
... fetching message info for content language
17 pages in the MediaWiki namespace override messages.
16 pages are equal to the default message (+ 0 talk pages).

...deleting equal messages (this may take a long time!)...
* [[MediaWiki:Eucc-email-part-two]]
* [[MediaWiki:Eucc-option-protect-public-domain-text-v1]]
* [[MediaWiki:Eucc-option-protect-public-domain-text-v2]]
* [[MediaWiki:Eucc-option-protect-public-domain-text-v3]]
* [[MediaWiki:Eucc-option-freedom-of-panorama-text-v1]]
* [[MediaWiki:Eucc-option-freedom-of-panorama-text-v2]]
* [[MediaWiki:Eucc-option-freedom-of-panorama-text-v3]]
* [[MediaWiki:Eucc-option-exception-for-ucg-text-v1]]
* [[MediaWiki:Eucc-option-exception-for-ucg-text-v2]]
* [[MediaWiki:Eucc-option-exception-for-ucg-text-v3]]
* [[MediaWiki:Eucc-option-exception-for-text-and-data-mining-text-v1]]
* [[MediaWiki:Eucc-option-exception-for-text-and-data-mining-text-v2]]
* [[MediaWiki:Eucc-option-exception-for-text-and-data-mining-text-v3]]
* [[MediaWiki:Eucc-call-script-text]]
* [[MediaWiki:Eucc-mail-dialog-top-label]]
* [[MediaWiki:Eucc-tweet-at-rep-default-text]]

done!
Tgr added a comment.Sep 11 2018, 10:42 AM

This removed all English overrides (except mainpage which is harmless). Other languages (esp. de, fr, es) still have plenty of overrides which do not quite match translatewiki (although the changes look minor). Those do not cause problems (other than confusion of translatewiki.net translators) so I left them as is.

Tgr closed this task as Resolved.Sep 11 2018, 10:42 AM
Tgr claimed this task.