I looked at this today and I think we should revisit the estimation for this task. The reason it doesn't work is that ImageLinksDataUpdater gets an entity and only adds image usages for the entity and not its subentities. The only possible way that I can think of is to add a "getSubEntities()" to EntityDocument interface and implement it with empty value everywhere, then use it in EntityStatementDataUpdaterAdapter + praying that in future we don't end up having subentities that would have subentities of their own.

In T204066#4707450, @Ladsgroup wrote:

I looked at this today and I think we should revisit the estimation for this task. The reason it doesn't work is that ImageLinksDataUpdater gets an entity and only adds image usages for the entity and not its subentities. The only possible way that I can think of is to add a "getSubEntities()" to EntityDocument interface and implement it with empty value everywhere, then use it in EntityStatementDataUpdaterAdapter + praying that in future we don't end up having subentities that would have subentities of their own.

I would suggest to create a new interface for this method, should it be added… I don't think we should clutter up EntityDocument with that.

An alternative would be to create a new interface containing a method that is defined to return all statements (from the entity itself+sub entities). A possible name would be getDependentStatements/DependentStatementListProvider or getSubordinatedStatements/SubordinatedStatementListProvider. This way, we would have a mechanism that is subentity agnostic and we don't need WikibaseRepo to do the right thing™ with the subentities.

I think I prefer the suggestion to add an accessor of subentities. And I don’t see why it couldn’t work for subentities of subentities. If we change EntityStatementDataUpdaterAdapter::processEntity to this:

	public function processEntity( EntityDocument $entity ) {
		if ( $entity instanceof StatementListProvider ) {
			foreach ( $entity->getStatements() as $statement ) {
				$this->dataUpdater->processStatement( $statement );
			}
		}
		if ( $entity instanceof SubEntitiesProvider ) {
			foreach ( $entity->getEntities() as $entity ) {
				$this->processEntity( $entity );
			}
		}
	}

it should automatically support recursive subentities. (But perhaps that should be a separate adapter, not EntityStatementDataUpdaterAdapter? I’m not familiar with these classes.)

Change 472020 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Make Lexeme implement SubEntityProvider

https://gerrit.wikimedia.org/r/472020

I’ve uploaded one possible implementation, based on the above comment:

• data model PR
• Wikibase change
• WikibaseLexeme change

However, this will require a new data model release, and we aren’t even on the latest current release yet, so this would be blocked on T206325: Use wikibase/data-model 9.0 everywhere.

I made two commits simplifying the involved code in preparation of implementing the behavior change:

• https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/472483
• https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/472732

Discussed how to make the behavior change while not increasing tech debt with Lucas. Here is the basic idea: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/472730

This is done, awaiting review:

Wikibase change: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/477031
Wikibase Lexeme change: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/+/477117

Change 477117 had a related patch set uploaded (by Hoo man; owner: Jeroen De Dauw):
[mediawiki/extensions/WikibaseLexeme@master] Update parser output for Form and Sense statements

https://gerrit.wikimedia.org/r/477117

Change 477031 had a related patch set uploaded (by Hoo man; owner: Jeroen De Dauw):
[mediawiki/extensions/Wikibase@master] Replace generic code with item/property specific code

https://gerrit.wikimedia.org/r/477031

Change 477031 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Replace generic code with item/property specific code

https://gerrit.wikimedia.org/r/477031

Change 477117 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Update parser output for Form and Sense statements

https://gerrit.wikimedia.org/r/477117

I expected it to be deployed today. Just tried to test it on Luftballons but no change, maybe it's not deployed yet, or some pages need a purge?

Wikidata usually gets a new software versions on Wednesday afternoon (our time), and right now the train was also rolled back, see T206662: 1.33.0-wmf.8 deployment blockers. But you might be able to test this on test.wikidata.org – as far as I can see this fix only requires changes to be deployed to the Wikibase repository, not to Commons.

Change 472020 abandoned by Jeroen De Dauw:
Make Lexeme implement SubEntityProvider

Reason:
We used another approach, see https://phabricator.wikimedia.org/T204066

https://gerrit.wikimedia.org/r/472020