Page MenuHomePhabricator
Create Task
Maniphest T204873

"Special page" tab accidentally renamed to "CollabPad"
Closed, ResolvedPublic
Actions

Description

On special pages like https://www.wikidata.org/wiki/Special:SpecialPages the top tab says "CollabPad" instead of "Special Page" like at https://en.wikipedia.org/wiki/Special:SpecialPages . https://www.wikidata.org/wiki/Special:SpecialPages?uselang=qqx returns the message https://www.wikidata.org/wiki/MediaWiki:Collabpad , but that should be nstab-special (https://www.wikidata.org/wiki/MediaWiki:Nstab-special) according to https://en.wikipedia.org/wiki/Special:SpecialPages?uselang=qqx .

Not sure what happened here, but doesn't seem correct

Screenshot_2018-09-19 Special pages - MediaWiki.png (372×589 px, 16 KB)

Details

SubjectRepoBranchLines +/-
Fix special page overridemediawiki/extensions/VisualEditorwmf/1.32.0-wmf.22+12 -9
Fix special page overridemediawiki/extensions/VisualEditormaster+12 -9
Revert "CollabPad: Show current sub-page as separate tab"mediawiki/extensions/VisualEditormaster+2 -66
Customize query in gerrit

Related Objects
Search...

Event Timeline

Multichill created this task.Sep 19 2018, 7:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 19 2018, 7:53 PM
Multichill added subscribers: Lydia_Pintscher, Lea_Lacroix_WMDE.Sep 19 2018, 7:55 PM

Changed https://www.wikidata.org/wiki/MediaWiki:Collabpad to "CollabPad (but it is a special page)" and that's now all over the place.

Legoktm triaged this task as Unbreak Now! priority.Sep 19 2018, 8:02 PM
Legoktm added a project: VisualEditor.
Legoktm subscribed.

CollabPad is a VE thing...

Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptSep 19 2018, 8:02 PM
Legoktm renamed this task from "Special page" accidentally renamed to "CollabPad" on Wikidata to "Special page" accidentally renamed to "CollabPad" .Sep 19 2018, 8:03 PM
Legoktm added a parent task: T191068: 1.32.0-wmf.22 deployment blockers.
Legoktm removed a project: Wikidata.
Legoktm updated the task description. (Show Details)

Not Wikidata related, I can reproduce on https://www.mediawiki.org/wiki/Special:SpecialPages?useskin=vector

Legoktm added subscribers: Jdforrester-WMF, Esanders.Sep 19 2018, 8:06 PM

Probably https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/460766

Esanders added a comment.Sep 19 2018, 8:19 PM

Oops. Reverted: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/VisualEditor/+/461467/

gerritbot subscribed.Sep 19 2018, 8:20 PM

Change 461467 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Revert "CollabPad: Show current sub-page as separate tab"

https://gerrit.wikimedia.org/r/461467

gerritbot added a project: Patch-For-Review.Sep 19 2018, 8:20 PM
Esanders edited projects, added MediaWiki-Special-pages; removed VisualEditor.Sep 19 2018, 8:21 PM
gerritbot added a comment.Sep 19 2018, 8:27 PM

Change 461468 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Fix special page override

https://gerrit.wikimedia.org/r/461468

gerritbot added a comment.Sep 19 2018, 8:28 PM

Change 461467 abandoned by Esanders:
Revert "CollabPad: Show current sub-page as separate tab"

Reason:
Fixed instead with I463cbbbc5b6f284aa2794ceb2652911ef7053c2e

https://gerrit.wikimedia.org/r/461467

gerritbot added a comment.Sep 19 2018, 8:51 PM

Change 461468 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Fix special page override

https://gerrit.wikimedia.org/r/461468

gerritbot added a comment.Sep 19 2018, 8:54 PM

Change 461473 had a related patch set uploaded (by Jforrester; owner: Esanders):
[mediawiki/extensions/VisualEditor@wmf/1.32.0-wmf.22] Fix special page override

https://gerrit.wikimedia.org/r/461473

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)).Sep 19 2018, 9:00 PM
Jdforrester-WMF renamed this task from "Special page" accidentally renamed to "CollabPad" to "Special page" tab accidentally renamed to "CollabPad" .Sep 19 2018, 9:09 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF edited projects, added VisualEditor (Current work); removed Patch-For-Review.
gerritbot added a comment.Sep 19 2018, 9:20 PM

Change 461473 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.32.0-wmf.22] Fix special page override

https://gerrit.wikimedia.org/r/461473

Stashbot subscribed.Sep 19 2018, 9:24 PM

Mentioned in SAL (#wikimedia-operations) [2018-09-19T21:24:39Z] <jforrester@deploy1001> Synchronized php-1.32.0-wmf.22/extensions/VisualEditor/includes/SpecialCollabPad.php: T204873 Fix special page override hot deploy (duration: 00m 57s)

Jdforrester-WMF closed this task as Resolved.Sep 19 2018, 9:25 PM
Jdforrester-WMF moved this task from Incoming to Product owner review on the VisualEditor (Current work) board.

Fix deployed everywhere.

Framawiki awarded a token.Sep 19 2018, 9:37 PM
Framawiki subscribed.
ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)); removed MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)).Sep 19 2018, 10:00 PM
Liuxinyu970226 awarded a token.Sep 20 2018, 4:28 AM
Liuxinyu970226 unsubscribed.
Esanders removed a project: VisualEditor (Current work).Sep 20 2018, 10:11 AM
hashar mentioned this in T191068: 1.32.0-wmf.22 deployment blockers.Sep 20 2018, 9:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL