Page MenuHomePhabricator
Create Task
Maniphest T207477

'All public logs' for a given page lists the 'page curation log' reviews, but not 'patrol log' reviews
Open, Stalled, LowPublic
Actions

Description

There is a bug where the All public logs ( https://en.wikipedia.org/w/index.php?title=Special:Log&action=view&page=Rachel_Green_(biologist) ) for a given page doesn't list the Patrol log actions ( https://en.wikipedia.org/wiki/Special:Log?type=patrol&user=&page=Rachel_Green_%28biologist%29&wpdate=&tagfilter= ) but does list the page curation log actions (https://en.wikipedia.org/wiki/Special:Log?type=pagetriage-curation&user=&page=Rachel_Green_%28biologist%29&wpdate=&tagfilter=&subtype= ).

The 'Patrol log' should be added to 'All public logs' for a page. Otherwise it is difficult to see who has reviewed a page if they used Twinkle to review it (it will only show in the patrol log, and hence won't show up in the public logs for the page.

See: https://en.wikipedia.org/wiki/Wikipedia:Page_Curation/Suggested_improvements#11._Patrolled_by_Twinkle

Details

SubjectRepoBranchLines +/-
Show patrol log by default when viewing public logsmediawiki/coremaster+3 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Insertcleverphrasehere created this task.Oct 19 2018, 3:05 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 19 2018, 3:05 PM
Aklapper added a project: PageTriage.Oct 19 2018, 4:40 PM

@Insertcleverphrasehere: Adding PageTriage project tag so this task can be found when looking at PageCuration tasks at https://phabricator.wikimedia.org/tag/mediawiki-extensions-pagecuration/ . No need to add team tags like Growth-Team; that is up to each team (or automatic filters).

GTrang subscribed.Oct 21 2018, 2:55 PM

This is really an issue in the MediaWiki core rather than the PageTriage extension. I will upload a patch for this.

gerritbot subscribed.Oct 21 2018, 3:28 PM

Change 468840 had a related patch set uploaded (by GeoffreyT2000; owner: GeoffreyT2000):
[mediawiki/core@master] Show patrol log by default when viewing public logs

https://gerrit.wikimedia.org/r/468840

gerritbot added a project: Patch-For-Review.Oct 21 2018, 3:28 PM
Insertcleverphrasehere added a comment.Oct 29 2018, 3:36 PM

Bug is still an issue: (See: https://en.wikipedia.org/w/index.php?title=Special:Log&action=view&page=Geology_of_Afghanistan).
Not sure if the patch above has just not been implemented yet?

Aklapper added a comment.Oct 29 2018, 4:05 PM

https://gerrit.wikimedia.org/r/468840 says "Needs Code-Review Label", not "Merged". :)

Insertcleverphrasehere added a comment.Oct 29 2018, 4:08 PM

OK thanks very much Aklapper, Just a confirmation that this is in the process of being fixed and that we shouldn't need to request this as part of our community wishlist proposal?

kostajh edited projects, added Platform Engineering; removed PageTriage.Feb 4 2019, 6:50 PM
EvanProdromou claimed this task.Feb 5 2019, 3:27 PM
EvanProdromou subscribed.

We're looking this issue over to make sure we're doing it correctly. We want to make sure there's actually community support, and that auto-patrolling doesn't flood the logs.

CCicalese_WMF edited projects, added Platform Engineering (Needs Cleaning - Security, stability, performance, and scalability (TEC1)), Platform Team Workboards (Waiting for Review); removed Platform Engineering.Feb 5 2019, 3:28 PM
JTannerWMF removed a project: Growth-Team.Mar 19 2019, 6:04 PM
JTannerWMF subscribed.

Untagging ourselves due to us being accidentally tagged originally.

Aklapper added a project: MediaWiki-Logevents.Mar 19 2019, 6:48 PM
gerritbot added a comment.Mar 19 2019, 10:04 PM

Change 468840 had a related patch set uploaded (by GeoffreyT2000; owner: GeoffreyT2000):
[mediawiki/core@master] Show patrol log by default when viewing public logs

https://gerrit.wikimedia.org/r/468840

Quiddity changed the status of subtask T215922: Community input for patrol log reviews in 'all public logs' from Open to Stalled.May 28 2019, 3:55 PM
WDoranWMF removed a project: Platform Team Workboards (Waiting for Review).Jul 5 2019, 4:51 PM
gerritbot added a comment.Jul 29 2019, 9:45 PM

Change 468840 abandoned by GeoffreyT2000:
Show patrol log by default when viewing public logs

Reason:
Per Code Review -2.

https://gerrit.wikimedia.org/r/468840

WDoranWMF triaged this task as Low priority.Sep 3 2019, 6:35 PM
WDoranWMF edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Engineering (Needs Cleaning - Security, stability, performance, and scalability (TEC1)).
• eprodromou subscribed.Sep 3 2019, 6:36 PM

We need to change the configuration to reflect the recommendation from CE, see https://phabricator.wikimedia.org/T215922#4959510

Kudpung subscribed.Sep 13 2019, 3:56 AM

This doesn't look quite like the original request at Suggested Improvements. Can we have an update please in layman's terms?

Aklapper removed a project: Patch-For-Review.Sep 20 2019, 9:16 PM
daniel moved this task from Inbox to Backlog on the Platform Team Workboards (Clinic Duty Team) board.Oct 8 2019, 9:57 AM
• eprodromou closed subtask T215922: Community input for patrol log reviews in 'all public logs' as Resolved.Oct 8 2019, 5:29 PM
• AMooney changed the task status from Open to Stalled.Mar 12 2020, 1:22 PM
• AMooney edited projects, added Platform Engineering; removed Platform Team Workboards (Clinic Duty Team).
WDoranWMF moved this task from Inbox to Icebox on the Platform Engineering board.Mar 12 2020, 1:29 PM
WDoranWMF edited projects, added Platform Engineering (Icebox); removed Platform Engineering.Mar 23 2020, 2:05 PM
Aklapper removed EvanProdromou as the assignee of this task.May 25 2021, 8:39 PM
MarioGom subscribed.Nov 14 2021, 11:29 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL