Page MenuHomePhabricator

Flow tests failing in REL1_32 and REL1_31
Open, HighPublic

Description

see https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Flow/+/468793/ and https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Flow/+/468794/

WIth REL1_32 failing with:

19:22:24 1) Flow\Tests\Formatter\FormatterTest::testCheckUserFormatter with data set #0 ('With only a topicId reply sho...t fail', Closure$Flow\Tests\Formatter\FormatterTest::checkUserProvider;714 Object (...), 'reply', Flow\Model\UUID Object (...), Flow\Model\UUID Object (...), null)
19:22:24 Argument 1 passed to MediaWiki\Linker\LinkRenderer::makeLink() must implement interface MediaWiki\Linker\LinkTarget, null given
19:22:24 
19:22:24 /workspace/src/includes/linker/LinkRenderer.php:153
19:22:24 /workspace/src/extensions/Flow/includes/Formatter/AbstractFormatter.php:310
19:22:24 /workspace/src/extensions/Flow/includes/Formatter/CheckUserFormatter.php:50
19:22:24 /workspace/src/extensions/Flow/tests/phpunit/Formatter/FormatterTest.php:76
19:22:24 /workspace/src/tests/phpunit/MediaWikiTestCase.php:424
19:22:24 /workspace/src/maintenance/doMaintenance.php:94
19:22:24 
19:22:24 2) Flow\Tests\Formatter\FormatterTest::testCheckUserFormatter with data set #1 ('With topicId and postId shoul...t fail', Closure$Flow\Tests\Formatter\FormatterTest::checkUserProvider#2;715 Object (...), 'reply', Flow\Model\UUID Object (...), Flow\Model\UUID Object (...), Flow\Model\UUID Object (...))
19:22:24 Argument 1 passed to MediaWiki\Linker\LinkRenderer::makeLink() must implement interface MediaWiki\Linker\LinkTarget, null given
19:22:24 
19:22:24 /workspace/src/includes/linker/LinkRenderer.php:153
19:22:24 /workspace/src/extensions/Flow/includes/Formatter/AbstractFormatter.php:310
19:22:24 /workspace/src/extensions/Flow/includes/Formatter/CheckUserFormatter.php:50
19:22:24 /workspace/src/extensions/Flow/tests/phpunit/Formatter/FormatterTest.php:76
19:22:24 /workspace/src/tests/phpunit/MediaWikiTestCase.php:424
19:22:24 /workspace/src/maintenance/doMaintenance.php:94
19:22:24 
19:22:24 FAILURES!
19:22:24 Tests: 3778, Assertions: 33537, Errors: 2, Skipped: 11.
19:22:24

And REL1_31 failing with:

23:44:05 Fatal error: unknown class Pimple\Container in /workspace/src/extensions/Flow/includes/Container.php on line 5
23:44:05 Traceback (most recent call last):
23:44:05   File "/usr/local/bin/quibble", line 9, in <module>
23:44:05     load_entry_point('quibble==0.0.0', 'console_scripts', 'quibble')()
23:44:05   File "/usr/local/lib/python3.4/dist-packages/quibble/cmd.py", line 552, in main
23:44:05     cmd.execute()
23:44:05   File "/usr/local/lib/python3.4/dist-packages/quibble/cmd.py", line 455, in execute
23:44:05     self.mw_install()
23:44:05   File "/usr/local/lib/python3.4/dist-packages/quibble/cmd.py", line 329, in mw_install
23:44:05     mwdir=self.mw_install_path
23:44:05   File "/usr/local/lib/python3.4/dist-packages/quibble/mediawiki/maintenance.py", line 37, in update
23:44:05     'Update failed with exit code: %s' % p.returncode)
23:44:05 Exception: Update failed with exit code: 255

Event Timeline

Paladox created this task.Oct 21 2018, 9:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 21 2018, 9:56 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 21 2018, 9:56 PM
Paladox triaged this task as High priority.Oct 21 2018, 9:57 PM

Preventing merges in the stable branch.

Change 472263 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/Flow@master] Temporarily mark flaky tests as broken

https://gerrit.wikimedia.org/r/472263

Change 472263 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Temporarily mark flaky tests as broken

https://gerrit.wikimedia.org/r/472263

Change 472456 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/Flow@REL1_32] Temporarily mark flaky tests as broken

https://gerrit.wikimedia.org/r/472456

JTannerWMF moved this task from FY 2019-20 to Q3 2018-19 on the Growth-Team board.Jan 3 2019, 3:54 PM

Change 472456 abandoned by Kosta Harlan:
Temporarily mark flaky tests as broken

Reason:
No comments/activity on this so I assume it's not needed anymore.

https://gerrit.wikimedia.org/r/472456