Maniphest T207616

Flow tests failing in REL1_32 and REL1_31
Closed, DeclinedPublic
Actions

Assigned To

None

Authored By

	Paladox
	Oct 21 2018, 9:56 PM

Description

see https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Flow/+/468793/ and https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Flow/+/468794/

WIth REL1_32 failing with:

19:22:24 1) Flow\Tests\Formatter\FormatterTest::testCheckUserFormatter with data set #0 ('With only a topicId reply sho...t fail', Closure$Flow\Tests\Formatter\FormatterTest::checkUserProvider;714 Object (...), 'reply', Flow\Model\UUID Object (...), Flow\Model\UUID Object (...), null)
19:22:24 Argument 1 passed to MediaWiki\Linker\LinkRenderer::makeLink() must implement interface MediaWiki\Linker\LinkTarget, null given
19:22:24 
19:22:24 /workspace/src/includes/linker/LinkRenderer.php:153
19:22:24 /workspace/src/extensions/Flow/includes/Formatter/AbstractFormatter.php:310
19:22:24 /workspace/src/extensions/Flow/includes/Formatter/CheckUserFormatter.php:50
19:22:24 /workspace/src/extensions/Flow/tests/phpunit/Formatter/FormatterTest.php:76
19:22:24 /workspace/src/tests/phpunit/MediaWikiTestCase.php:424
19:22:24 /workspace/src/maintenance/doMaintenance.php:94
19:22:24 
19:22:24 2) Flow\Tests\Formatter\FormatterTest::testCheckUserFormatter with data set #1 ('With topicId and postId shoul...t fail', Closure$Flow\Tests\Formatter\FormatterTest::checkUserProvider#2;715 Object (...), 'reply', Flow\Model\UUID Object (...), Flow\Model\UUID Object (...), Flow\Model\UUID Object (...))
19:22:24 Argument 1 passed to MediaWiki\Linker\LinkRenderer::makeLink() must implement interface MediaWiki\Linker\LinkTarget, null given
19:22:24 
19:22:24 /workspace/src/includes/linker/LinkRenderer.php:153
19:22:24 /workspace/src/extensions/Flow/includes/Formatter/AbstractFormatter.php:310
19:22:24 /workspace/src/extensions/Flow/includes/Formatter/CheckUserFormatter.php:50
19:22:24 /workspace/src/extensions/Flow/tests/phpunit/Formatter/FormatterTest.php:76
19:22:24 /workspace/src/tests/phpunit/MediaWikiTestCase.php:424
19:22:24 /workspace/src/maintenance/doMaintenance.php:94
19:22:24 
19:22:24 FAILURES!
19:22:24 Tests: 3778, Assertions: 33537, Errors: 2, Skipped: 11.
19:22:24

And REL1_31 failing with:

23:44:05 Fatal error: unknown class Pimple\Container in /workspace/src/extensions/Flow/includes/Container.php on line 5
23:44:05 Traceback (most recent call last):
23:44:05   File "/usr/local/bin/quibble", line 9, in <module>
23:44:05     load_entry_point('quibble==0.0.0', 'console_scripts', 'quibble')()
23:44:05   File "/usr/local/lib/python3.4/dist-packages/quibble/cmd.py", line 552, in main
23:44:05     cmd.execute()
23:44:05   File "/usr/local/lib/python3.4/dist-packages/quibble/cmd.py", line 455, in execute
23:44:05     self.mw_install()
23:44:05   File "/usr/local/lib/python3.4/dist-packages/quibble/cmd.py", line 329, in mw_install
23:44:05     mwdir=self.mw_install_path
23:44:05   File "/usr/local/lib/python3.4/dist-packages/quibble/mediawiki/maintenance.py", line 37, in update
23:44:05     'Update failed with exit code: %s' % p.returncode)
23:44:05 Exception: Update failed with exit code: 255

Details

	Subject	Repo	Branch	Lines +/-
	Temporarily mark flaky tests as broken	mediawiki/extensions/Flow	REL1_32	+16 -0
	Temporarily mark flaky tests as broken	mediawiki/extensions/Flow	master	+16 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T208988 Fix Flow random test failures
		Declined		None	T207616 Flow tests failing in REL1_32 and REL1_31

Event Timeline

Paladox created this task.Oct 21 2018, 9:56 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 21 2018, 9:56 PM

Paladox added a project: StructuredDiscussions.Oct 21 2018, 9:56 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 21 2018, 9:56 PM

Preventing merges in the stable branch.

First issue is T206582: Flow\Tests\Formatter\FormatterTest test failures: TypeError: Argument 1 passed to MediaWiki\Linker\LinkRenderer::makeLink() must implement interface MediaWiki\Linker\LinkTarget, null given

Second issue:

In T202668#4529174, @hashar wrote:

That is due to mediawiki/vendor no more having pimple/pimple. It has been removed by 46bc943c161698ea90d549edab5efb735e715aa1

That is the same issue as T189560

JTannerWMF moved this task from Inbox to Needs Discussion on the Growth-Team board.Oct 24 2018, 4:45 PM

Aklapper mentioned this in T206582: Flow\Tests\Formatter\FormatterTest test failures: TypeError: Argument 1 passed to MediaWiki\Linker\LinkRenderer::makeLink() must implement interface MediaWiki\Linker\LinkTarget, null given.Oct 27 2018, 5:36 AM

kostajh moved this task from Needs Discussion to Upcoming Work on the Growth-Team board.Oct 31 2018, 6:08 PM

kostajh added a parent task: T208988: Fix Flow random test failures.Nov 7 2018, 7:36 PM

hashar awarded a token.Nov 7 2018, 8:13 PM

hashar removed projects: Continuous-Integration-Infrastructure, Continuous-Integration-Config.

JTannerWMF moved this task from Upcoming Work to FY 2019-20 on the Growth-Team board.Nov 7 2018, 8:27 PM

Change 472263 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/Flow@master] Temporarily mark flaky tests as broken

https://gerrit.wikimedia.org/r/472263

gerritbot added a project: Patch-For-Review.Nov 7 2018, 9:08 PM

Change 472263 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Temporarily mark flaky tests as broken

https://gerrit.wikimedia.org/r/472263

Change 472456 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/Flow@REL1_32] Temporarily mark flaky tests as broken

https://gerrit.wikimedia.org/r/472456

JTannerWMF moved this task from FY 2019-20 to Q2 2019-20 on the Growth-Team board.Jan 3 2019, 3:54 PM

Change 472456 abandoned by Kosta Harlan:
Temporarily mark flaky tests as broken

Reason:
No comments/activity on this so I assume it's not needed anymore.

https://gerrit.wikimedia.org/r/472456

JTannerWMF moved this task from Q2 2019-20 to Triaged but Future on the Growth-Team board.Mar 6 2019, 7:22 PM

MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:56 PM

Lens0021 subscribed.May 25 2021, 3:59 PM

REL1_32 is now EOL and REL1_31 will soon be EOL.[1] Will this make this task resolved?

[1] https://lists.wikimedia.org/hyperkitty/list/mediawiki-announce@lists.wikimedia.org/thread/H5JPSLBRIAL3A4ETGUZ5KYMN5XHDOQ6Z/