Maniphest T208423

Revision summaries use outdated form links
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Pablo-WMDE
	Oct 31 2018, 2:13 PM

Description

T195477 changed the way anchors for forms on lexeme pages are structured, now not containing the lexeme part any more.
The lexeme page history shows all revisions of that page incl. the change summary. If a change happenend that added a statement to a lexeme form as property, a link to said form is rendered.

Due to the change of format there seem to be history entries which still contain links using the old anchor format.

the lexeme page history links to the forms using the correct

Info

I actually assumed this to be ruled out by the fact that the summaries are, at least that is what I thought, only converted to a human-readable format when displayed

Bildschirmfoto von 2018-10-31 14-57-00.png (943×1 px, 160 KB)

Details

Subject	Repo	Branch	Lines +/-
Fix the fragment of old-style links to subentities	mediawiki/extensions/Wikibase	master	+25 -2
Fix the fragment of old-style links to forms	mediawiki/extensions/WikibaseLexeme	master	+39 -0
Don’t detect fragments of form IDs of other lexemes	mediawiki/extensions/WikibaseLexeme	master	+30 -3
Create lexeme id from fragment	mediawiki/extensions/WikibaseLexeme	master	+32 -5

Customize query in gerrit

Related Objects

Mentioned In: rEWLE744103af56f9: Fix the fragment of old-style links to forms
rEWLE65655c193286: Fix the fragment of old-style links to forms
rEWLE1e390285699b: Fix the fragment of old-style links to forms
rEWLEea3ff7f310f2: Don’t detect fragments of form IDs of other lexemes
rEWLEe78ad5d4c4d4: Fix the fragment of old-style links to forms
rEWLE9bf7bf49f9db: Fix the fragment of old-style links to forms
rEWLEc713c13bbbd0: Don’t detect fragments of form IDs of other lexemes
rEWLE32ab3ec67f62: Create lexeme id from fragment
rEWLEb85c6bc8f4e1: Create lexeme id from fragment
rEWLEd298a94c636d: Create lexeme id from fragment
rEWLE76757e3e09a7: Create lexeme id from fragment
rEWLE12aa92d22809: Create lexeme id from fragment
rEWLE88bec730973d: Create lexeme id from fragment
Mentioned Here: T195477: Make Form ID link targets less redundant

Event Timeline

• Pablo-WMDE created this task.Oct 31 2018, 2:13 PM

Restricted Application added a project: Wikidata. · View Herald TranscriptOct 31 2018, 2:13 PM

• Pablo-WMDE added a subscriber: WMDE-leszek.Nov 7 2018, 10:01 AM

Michael claimed this task.Nov 7 2018, 2:26 PM

Michael added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).

Michael moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

It seems this is only a problem with historic entries. New ones are fine-ish: https://test.wikidata.org/w/index.php?title=Lexeme:L42&action=history

Turns out the wikitext for the comment from the summary is directly in the database as wikitext. Thus is seems not savely possible to fix the old entries.

Screenshots are from system recreating the problem:

Michael moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Nov 7 2018, 5:59 PM

I actually noticed a different problem on L42’s history on testwikidata:

(‎Created claim: lexeme form of choice (P77771): merge target/merge source/foo (L103)) (undo)
(‎Created claim: lexeme form of choice (P77771): MediaWikis (L41-F1)) (undo) (restore)

In the older edit (below), the link [[L41#L41-F1]] is rendered as a link to the L41-F1 entity, using the representation of that form (MediaWikis – plural: the lexeme’s lemma is MediaWiki, singular). In the newer edit, however (above), the link [[L103#F1]] is rendered as a link to the L103 entity, using the lemmas of that lexeme, instead of the representations of its first form (which would be just merge sorce). So that’s two related things:

The component which prettifies entity links in edit summaries hasn’t been updated for the new form anchors yet, apparently.
Could that component also be used to update the anchor from e. g. #L41-F1 to #F1, solving this issue without requiring any database modifications?

Unfortunately, I don’t remember where that component actually is right now, and I can’t find anything relevant in WikibaseLexeme’s wiring files.

Results of the investigation so far:

The relevant pattern is in WikibaseLexeme/src/Domain/Model/FormId.php:

const PATTERN = '/^L[1-9]\d*-F[1-9]\d*\z/';

However, simply removing the first part of the pattern breaks \Wikibase\Lexeme\Domain\Model\LexemeSubEntityId::extractLexemeIdAndSubEntityId, which relies on the two-part form.

I looked a bit into this as well, and I think LexemeHandler::getIdForTitle needs to be updated. It currently tries to “parse” the fragment as an ID; in addition, it should also attempt to parse text + fragment as an ID.

Change 472953 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/WikibaseLexeme@master] Create lexeme id from fragment

https://gerrit.wikimedia.org/r/472953

gerritbot added a project: Patch-For-Review.Nov 12 2018, 10:25 AM

Michael mentioned this in rEWLE88bec730973d: Create lexeme id from fragment.Nov 12 2018, 10:27 AM

Michael mentioned this in rEWLE12aa92d22809: Create lexeme id from fragment.Nov 12 2018, 10:40 AM

Michael mentioned this in rEWLE76757e3e09a7: Create lexeme id from fragment.Nov 12 2018, 10:52 AM

Addshore triaged this task as Medium priority.Nov 12 2018, 10:59 AM

Michael mentioned this in rEWLEd298a94c636d: Create lexeme id from fragment.Nov 12 2018, 11:19 AM

Michael mentioned this in rEWLEb85c6bc8f4e1: Create lexeme id from fragment.Nov 12 2018, 11:46 AM

Michael mentioned this in rEWLE32ab3ec67f62: Create lexeme id from fragment.Nov 12 2018, 3:40 PM

Addshore moved this task from incoming to in progress on the Wikidata board.Nov 13 2018, 3:34 PM

Change 472953 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Create lexeme id from fragment

https://gerrit.wikimedia.org/r/472953

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.6; 2018-11-27).Nov 14 2018, 3:01 PM

In T208423#4731782, @Lucas_Werkmeister_WMDE wrote:

The component which prettifies entity links in edit summaries hasn’t been updated for the new form anchors yet, apparently.

Could that component also be used to update the anchor from e. g. #L41-F1 to #F1, solving this issue without requiring any database modifications?

The first part of this is fixed with the above change, I’ll try to do the second part now.

Lucas_Werkmeister_WMDE claimed this task.Nov 14 2018, 5:42 PM

Lucas_Werkmeister_WMDE added a subscriber: Michael.

Change 473586 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Don’t detect fragments of form IDs of other lexemes

https://gerrit.wikimedia.org/r/473586

Change 473585 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Fix the fragment of old-style links to subentities

https://gerrit.wikimedia.org/r/473585

Change 473587 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Fix the fragment of old-style links to forms

https://gerrit.wikimedia.org/r/473587

Alright, I’ve uploaded one possible approach:

It’s not the nicest thing in the world, but I think it’s acceptable. Alternative suggestions are welcome, though.

Related but independent is another fix in WikibaseLexeme.

Lucas_Werkmeister_WMDE mentioned this in rEWLEc713c13bbbd0: Don’t detect fragments of form IDs of other lexemes.Nov 14 2018, 7:17 PM

Lucas_Werkmeister_WMDE mentioned this in rEWLE9bf7bf49f9db: Fix the fragment of old-style links to forms.

Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Nov 14 2018, 7:17 PM

Lucas_Werkmeister_WMDE mentioned this in rEWLEe78ad5d4c4d4: Fix the fragment of old-style links to forms.Nov 14 2018, 7:24 PM

Lucas_Werkmeister_WMDE mentioned this in rEWLEea3ff7f310f2: Don’t detect fragments of form IDs of other lexemes.

Lucas_Werkmeister_WMDE mentioned this in rEWLE1e390285699b: Fix the fragment of old-style links to forms.Nov 15 2018, 2:16 PM

Lucas_Werkmeister_WMDE mentioned this in rEWLE65655c193286: Fix the fragment of old-style links to forms.Nov 15 2018, 3:07 PM

Lucas_Werkmeister_WMDE mentioned this in rEWLE744103af56f9: Fix the fragment of old-style links to forms.Nov 15 2018, 3:51 PM

Change 473586 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Don’t detect fragments of form IDs of other lexemes

https://gerrit.wikimedia.org/r/473586

Change 473587 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Fix the fragment of old-style links to forms

https://gerrit.wikimedia.org/r/473587

Addshore reassigned this task from Lucas_Werkmeister_WMDE to Michael.Nov 16 2018, 11:14 AM

Change 473585 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix the fragment of old-style links to subentities

https://gerrit.wikimedia.org/r/473585

Tarrow moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Nov 19 2018, 9:56 AM

Lydia_Pintscher closed this task as Resolved.Nov 21 2018, 10:21 AM

Lydia_Pintscher moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

	F27096356: Screenshot_2018-11-07 phpmyadmin mw localhost 8080 db-master default revision phpMyAdmin 4 8 3(1).png
	Nov 7 2018, 5:59 PM

	F27096357: Screenshot_2018-11-07 phpmyadmin mw localhost 8080 db-master default revision phpMyAdmin 4 8 3.png
	Nov 7 2018, 5:59 PM

	F27000405: Bildschirmfoto von 2018-10-31 14-57-00.png
	Oct 31 2018, 2:13 PM

Revision summaries use outdated form linksClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Revision summaries use outdated form links
Closed, ResolvedPublic
Actions