Page MenuHomePhabricator
Create Task
Maniphest T214358

Fatal error: Uncaught TypeError: Argument 2 passed to TranslateHooks::onPageContentLanguage() must be an instance of Language, string given
Closed, ResolvedPublic
Actions

Description

Setup

  • MediaWiki 1.31.1 (632c3b6) 16:10, 16 January 2019
  • PHP 7.0.32-0ubuntu0.16.04.1 (apache2handler)
  • MySQL 5.7.24-0ubuntu0.16.04.1
  • Translate 2019.01 rETRA5f8b699bdd80

Issue
When upgrading to the latest version of Translate I get the following fatal:

Fatal error: Uncaught TypeError: Argument 2 passed to TranslateHooks::onPageContentLanguage() must be an instance of Language, string given, called in /../w/includes/Hooks.php on line 177 and defined in /../w/extensions/Translate/TranslateHooks.php:475

Stack Trace

#0 /../w/includes/Hooks.php(177): TranslateHooks::onPageContentLanguage(Object(Title), 'en', Object(LanguageEn))
#1 /../w/includes/Hooks.php(205): Hooks::callHook('PageContentLang...', Array, Array, NULL)
#2 /../w/includes/content/ContentHandler.php(671): Hooks::run('PageContentLang...', Array)
#3 /../w/includes/content/ContentHandler.php(697): ContentHandler->getPageLanguage(Object(Title), NULL)
#4 /../w/includes/Title.php(5032): ContentHandler->getPageViewLanguage(Object(Title))
#5 /../w/includes/skins/SkinTemplate.php(279): Title->getPageViewLanguage()
#6 /../w/includes/skins/SkinTemplate.php(464): SkinTemplate->wrap in /../w/extensions/Translate/TranslateHooks.php on line 475

Details

SubjectRepoBranchLines +/-
Unstub $wgLang for PageContentLanguage hookmediawiki/coremaster+5 -1
Improve documentation of the PageContentLanguage hookmediawiki/coremaster+8 -5
Update PageContentLanguage hook handlermediawiki/extensions/LiquidThreadsmaster+7 -9
Update PageContentLanguage hook handlermediawiki/extensions/WikiLexicalDatamaster+3 -5
Use Language objects in PageContentLanguage hookmediawiki/extensions/CirrusSearchmaster+3 -5
Expanded param doctype further for PageContentLanguage hookmediawiki/extensions/Translatemaster+2 -2
Fix fatal error on PageContentLanguage hook subscribermediawiki/extensions/Translatewmf/1.33.0-wmf.14+3 -3
Fix fatal error on PageContentLanguage hook subscribermediawiki/extensions/Translatemaster+3 -3
Customize query in gerrit

Related Objects

Event Timeline

Kghbln created this task.Jan 22 2019, 10:04 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 22 2019, 10:04 AM
Kghbln updated the task description. (Show Details)Jan 22 2019, 10:05 AM
Nikerabbit added a project: MediaWiki Language Extension Bundle.Jan 23 2019, 9:46 AM
Nikerabbit added subscribers: xSavitar, Fomafix, Arrbee and 3 others.

Introduced in f6e5fced (CC @D3r1ck01 ), but the incorrect documentation (and typehint) was introduced in d800005 (CC @Fomafix) but (only partially) reverted in 626f6373a547 (CC @Krinkle).

It is not clear to me why this issue has not occured in translatewiki.net or WMF production or in our testing.

We really need to stop going back and forth on this. I suggest the following:

  • Fix MediaWiki core to always pass objects. Two different types only causes troubles like this.
  • Fix the current code to say Language|string and remove the explicit type hints.

To be decided whether we need a bugfix MLEB release or whether the fix can wait for regular 2019.04 (CC @KartikMistry @Arrbee).

KartikMistry added a comment.Jan 23 2019, 2:41 PM

@Nikerabbit We can do quick bug fix release for MLEB if needed.

Nikerabbit triaged this task as Unbreak Now! priority.Jan 23 2019, 2:58 PM

This breaks posting on LiquidThreads on translatewiki.net.

Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptJan 23 2019, 2:58 PM
gerritbot subscribed.Jan 23 2019, 3:01 PM

Change 486081 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/Translate@master] Fix fatal error on PageContentLanguage hook subscriber

https://gerrit.wikimedia.org/r/486081

gerritbot added a project: Patch-For-Review.Jan 23 2019, 3:01 PM
gerritbot added a comment.Jan 23 2019, 3:18 PM

Change 486081 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Fix fatal error on PageContentLanguage hook subscriber

https://gerrit.wikimedia.org/r/486081

Kghbln added a comment.Jan 23 2019, 3:31 PM

I just fetched the fix and I am now on Translate (8269ba6) 15:59, 23 January 2019. Thus I can confirm that this issue no longer happens.

Nikerabbit claimed this task.Jan 23 2019, 3:36 PM
Nikerabbit lowered the priority of this task from Unbreak Now! to High.
Nikerabbit edited projects, added Language-Team (Language-2019-January-March), Unplanned-Sprint-Work; removed Patch-For-Review.
Nikerabbit moved this task from Backlog to 2019.01 on the MediaWiki Language Extension Bundle board.

I also confirm translatewiki.net is okay now. Leaving open until we release the fix.

Nikerabbit moved this task from Backlog to In Progress on the Language-Team (Language-2019-January-March) board.Jan 23 2019, 3:37 PM
ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.16; 2019-02-05).Jan 23 2019, 4:01 PM
Jdforrester-WMF mentioned this in T214517: PHP Fatal Error: Argument 2 passed to TranslateHooks::onPageContentLanguage() must be an instance of Language, StubUserLang given.Jan 23 2019, 8:28 PM
gerritbot added a comment.Jan 23 2019, 9:24 PM

Change 486167 had a related patch set uploaded (by Jforrester; owner: Nikerabbit):
[mediawiki/extensions/Translate@wmf/1.33.0-wmf.14] Fix fatal error on PageContentLanguage hook subscriber

https://gerrit.wikimedia.org/r/486167

gerritbot added a project: Patch-For-Review.Jan 23 2019, 9:24 PM
gerritbot added a comment.Jan 23 2019, 11:10 PM

Change 486167 merged by jenkins-bot:
[mediawiki/extensions/Translate@wmf/1.33.0-wmf.14] Fix fatal error on PageContentLanguage hook subscriber

https://gerrit.wikimedia.org/r/486167

Stashbot subscribed.Jan 23 2019, 11:13 PM

Mentioned in SAL (#wikimedia-operations) [2019-01-23T23:13:16Z] <jforrester@deploy1001> Synchronized php-1.33.0-wmf.14/extensions/Translate/TranslateHooks.php: T214517 T214358 Hot-deploy Ic9d85fec1 to un-block train, hopefully (duration: 00m 53s)

gerritbot added a comment.Jan 24 2019, 4:01 PM

Change 486312 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/Translate@master] Expanded param doctype further for PageContentLanguage hook

https://gerrit.wikimedia.org/r/486312

gerritbot added a comment.Jan 24 2019, 4:21 PM

Change 486312 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Expanded param doctype further for PageContentLanguage hook

https://gerrit.wikimedia.org/r/486312

Nikerabbit removed a project: Patch-For-Review.Feb 5 2019, 7:41 AM
Nikerabbit added a comment.Mar 6 2019, 2:48 PM

I thought that I would fix this in core, but it seems the "bad" values are coming from other hook subscribers and hence are completely out of control. I'll improve some small things and documentation and see if I can identify some extensions producing these "bad" values.

Kghbln added a comment.Mar 6 2019, 2:52 PM
In T214358#5005302, @Nikerabbit wrote:

I thought that I would fix this in core, but it seems the "bad" values are coming from other hook subscribers and hence are completely out of control. I'll improve some small things and documentation and see if I can identify some extensions producing these "bad" values.

Ouch, this sounds bad. To help you a bit with the extensions. This is the wiki that gave me the error. So it must be one of them. The only other extension not part of MLEB concerned with language appears to be Semantic Interlanguage Links.

Krinkle unsubscribed.Mar 6 2019, 3:07 PM
gerritbot added a comment.Mar 6 2019, 3:31 PM

Change 494748 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/core@master] Improve documentation of PageContentLanguageHook

https://gerrit.wikimedia.org/r/494748

gerritbot added a project: Patch-For-Review.Mar 6 2019, 3:31 PM
Nikerabbit added a comment.Mar 7 2019, 11:15 AM

Doing an audit on: https://codesearch.wmflabs.org/search/?q=%5B%27%22%5DPageContentLanguage%5B%27%22%5D&i=nope&files=&repos=

  • MediaWiki core (hook runner) -> Language object (Language::factory or MediaWikiServices::getInstance()->getContentLanguage())
  • TranslateHooks::onPageContentLanguage -> Language object (wfGetLangObj or $wgContLang)
  • PageTranslationHooks::onPageContentLanguage -> Language object (Language::factory)
  • SemanticInterlanguageLinks -> string!
  • CirrusSearch\Jenkins\Jenkins::setLanguage -> string! (but only used for tests)
  • LqtDispatch::onPageContentLanguage -> Language or StubUserLang! ($wgLang passed as hook parameter)
  • PageLanguage::onPageContentLanguage -> Language (Language::factory)
  • WikiLexicalDataHooks::onPageContentLanguage -> Language or StubUserLang! (global $wgLang)
  • WikimediaIncubator::onPageContentLanguage -> Language or StubUserLang! (Language::factory or global $wgLang)
  • SemanticMediaWiki -> string!

@Kghbln Can I ask you to ask changes in SemanticInterlanguageLinks and SemanticMediaWiki?

I can attempt submitting patches for CirrusSearch , WikiLexicalData and WikimediaIncubator.

That still leaves the possibility of the $wgLang which is passed as hook parameter to be a StubUserLang. I should investigate whether it is okay to unstub it before passing it to the hooks.

gerritbot added a comment.Mar 7 2019, 11:16 AM

Change 494901 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/CirrusSearch@master] Use Language objects in PageContentLanguage hook

https://gerrit.wikimedia.org/r/494901

gerritbot added a comment.Mar 7 2019, 11:21 AM

Change 494902 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/LiquidThreads@master] Update PageContentLanguage hook handler

https://gerrit.wikimedia.org/r/494902

gerritbot added a comment.Mar 7 2019, 11:26 AM

Change 494904 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/WikiLexicalData@master] Update PageContentLanguage hook handler

https://gerrit.wikimedia.org/r/494904

gerritbot added a comment.Mar 7 2019, 11:38 AM

Change 494908 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/core@master] Unstub $wgLang for PageContentLanguage hook

https://gerrit.wikimedia.org/r/494908

Nikerabbit removed a project: Unplanned-Sprint-Work.Mar 7 2019, 11:40 AM
Nikerabbit moved this task from In Progress to In Review on the Language-Team (Language-2019-January-March) board.
gerritbot added a comment.Mar 7 2019, 4:58 PM

Change 494901 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Use Language objects in PageContentLanguage hook

https://gerrit.wikimedia.org/r/494901

Kghbln added a comment.Mar 7 2019, 9:30 PM

Can I ask you to ask changes in SemanticInterlanguageLinks and SemanticMediaWiki?

I created the respective issues:

gerritbot added a comment.Mar 8 2019, 10:08 AM

Change 494904 merged by jenkins-bot:
[mediawiki/extensions/WikiLexicalData@master] Update PageContentLanguage hook handler

https://gerrit.wikimedia.org/r/494904

gerritbot added a comment.Mar 8 2019, 10:13 AM

Change 494902 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@master] Update PageContentLanguage hook handler

https://gerrit.wikimedia.org/r/494902

gerritbot added a comment.Mar 12 2019, 7:34 AM

Change 494748 merged by jenkins-bot:
[mediawiki/core@master] Improve documentation of the PageContentLanguage hook

https://gerrit.wikimedia.org/r/494748

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.22; 2019-03-19); removed MW-1.33-notes (1.33.0-wmf.16; 2019-02-05).Mar 16 2019, 8:31 PM
Nikerabbit moved this task from Backlog to maintenance and operational issues on the MediaWiki-extensions-Translate board.Mar 18 2019, 3:16 PM
Pginer-WMF edited projects, added Language-Team (Language-2019-April-June); removed Language-Team (Language-2019-January-March).Apr 2 2019, 11:26 AM
Pginer-WMF moved this task from Backlog to In Review on the Language-Team (Language-2019-April-June) board.
Nikerabbit moved this task from 2019.01 to 2019.04 on the MediaWiki Language Extension Bundle board.Apr 10 2019, 10:46 AM
Nikerabbit mentioned this in T212482: RFC: Evolve hook system to support "filters" and "actions" only.May 7 2019, 4:31 PM
Nikerabbit added a comment.May 15 2019, 11:33 AM

If there is no progress on the last open patch by end of the sprint (next Tuesday I believe), I propose to abandon it and resolve this task.

Nikerabbit moved this task from In Review to Blocked on the Language-Team (Language-2019-April-June) board.May 15 2019, 11:34 AM
Nikerabbit moved this task from Blocked to In Progress on the Language-Team (Language-2019-April-June) board.May 16 2019, 8:02 AM
gerritbot added a comment.May 16 2019, 4:51 PM

Change 494908 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/core@master] Unstub $wgLang for PageContentLanguage hook

https://gerrit.wikimedia.org/r/494908

gerritbot added a comment.May 16 2019, 10:51 PM

Change 494908 merged by jenkins-bot:
[mediawiki/core@master] Unstub $wgLang for PageContentLanguage hook

https://gerrit.wikimedia.org/r/494908

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.6; 2019-05-21).May 16 2019, 11:00 PM
Nikerabbit removed a project: Patch-For-Review.May 17 2019, 10:34 AM
Nikerabbit moved this task from In Progress to Done on the Language-Team (Language-2019-April-June) board.May 17 2019, 10:40 AM

Note about QA: there isn't any good way to manually test this besides that the errors are gone when running in production. The original fix was confirmed in T214358#4902560 and the follow-ups mostly updated documentation and are low risk.

Arrbee closed this task as Resolved.May 20 2019, 8:16 AM
Nikerabbit mentioned this in T240083: "User::loadFromSession called before the end of Setup.php" (violation by Wikibase/ULS) [Story Points 5].Dec 9 2019, 12:22 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL