Page MenuHomePhabricator
Create Task
Maniphest T215408

Exception when switching from mobile VE to wikitext: "Uncaught TypeError: e is not a constructor"
Closed, ResolvedPublic
Actions

Description

Exception when switching from mobile VE to wikitext:

Uncaught TypeError: e is not a constructor
    at r.switchToSourceEditor (VisualEditorOverlay.js:162)
    at s.editSource (ve.init.mw.MobileFrontendArticleTarget.js:239)
    at VeUiMWEditModeSourceTool.ve.ui.MWEditModeSourceTool.switch (ve.ui.MWEditModeTool.js?6fc55:60)
    at VeUiMWEditModeSourceTool.mw.libs.ve.MWEditModeTool.onSelect (ve.init.MWEditModeTool.js?8a9ee:80)
    at OoUiListToolGroup.OO.ui.ToolGroup.onMouseKeyUp (ToolGroup.js:240)
    at OoUiListToolGroup.OO.ui.PopupToolGroup.onMouseKeyUp (PopupToolGroup.js:151)
    at OoUiListToolGroup.OO.ui.ListToolGroup.onMouseKeyUp (ListToolGroup.js:204)
    at HTMLDivElement.dispatch (jquery.js?6a07d:5183)
    at HTMLDivElement.elemData.handle (jquery.js?6a07d:4991)

Details

SubjectRepoBranchLines +/-
EditorOverlay: Pass constructor of itself to VisualEditorOverlay, not instancemediawiki/extensions/MobileFrontendwmf/1.33.0-wmf.16+5 -5
EditorOverlay: Pass constructor of itself to VisualEditorOverlay, not instancemediawiki/extensions/MobileFrontendmaster+5 -5
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Feb 6 2019, 12:50 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 6 2019, 12:50 PM
matmarex claimed this task.Feb 6 2019, 12:51 PM
matmarex mentioned this in T215367: [Regression wmf.16] Switching to VE from Wikitext editor is failing on mobile, shows error "TypeError: Cannot read property 'saveFields' of null".

Caused by d13353879a30c79095c54b904987898650a27f8c (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/486535)

gerritbot subscribed.Feb 6 2019, 12:53 PM

Change 488395 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/MobileFrontend@master] EditorOverlay: Pass constructor of itself to VisualEditorOverlay, not instance

https://gerrit.wikimedia.org/r/488395

gerritbot added a project: Patch-For-Review.Feb 6 2019, 12:53 PM
matmarex added a comment.Feb 6 2019, 12:53 PM

This will need to be backported to 1.33.0-wmf.16.

Jdlrobson added a project: Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3).Feb 6 2019, 4:06 PM
Jdlrobson subscribed.

Bug was caused by me during refactors. Sorry.

Jdlrobson moved this task from To Do to Needs QA on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.Feb 6 2019, 4:06 PM
Jdlrobson moved this task from Needs QA to Ready for Signoff on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
matmarex edited projects, added VisualEditor (Current work); removed VisualEditor.Feb 6 2019, 4:08 PM
matmarex moved this task from Incoming to QA on the VisualEditor (Current work) board.
gerritbot added a comment.Feb 6 2019, 4:20 PM

Change 488395 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] EditorOverlay: Pass constructor of itself to VisualEditorOverlay, not instance

https://gerrit.wikimedia.org/r/488395

gerritbot added a comment.Feb 6 2019, 4:32 PM

Change 488492 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/MobileFrontend@wmf/1.33.0-wmf.16] EditorOverlay: Pass constructor of itself to VisualEditorOverlay, not instance

https://gerrit.wikimedia.org/r/488492

matmarex added a comment.Feb 6 2019, 4:47 PM

Scheduled for SWAT: https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20190206T1700

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.17; 2019-02-12).Feb 6 2019, 5:00 PM
gerritbot added a comment.Feb 6 2019, 5:27 PM

Change 488492 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@wmf/1.33.0-wmf.16] EditorOverlay: Pass constructor of itself to VisualEditorOverlay, not instance

https://gerrit.wikimedia.org/r/488492

Stashbot subscribed.Feb 6 2019, 5:40 PM

Mentioned in SAL (#wikimedia-operations) [2019-02-06T17:39:59Z] <thcipriani@deploy1001> Synchronized php-1.33.0-wmf.16/extensions/MobileFrontend: SWAT: [[gerrit:488492|EditorOverlay: Pass constructor of itself to VisualEditorOverlay, not instance]] T215408 (duration: 00m 57s)

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.16; 2019-02-05); removed MW-1.33-notes (1.33.0-wmf.17; 2019-02-12).Feb 6 2019, 6:00 PM
Jdlrobson triaged this task as Unbreak Now! priority.Feb 6 2019, 6:03 PM

Per SWAT

Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptFeb 6 2019, 6:03 PM
JTannerWMF added a project: Editing QA.Feb 7 2019, 5:42 PM
Esanders moved this task from Inbox to High Priority on the Editing QA board.Feb 7 2019, 7:05 PM
Ryasmeen edited projects, added Verified; removed Editing QA, Patch-For-Review.Feb 7 2019, 10:18 PM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.
Jdlrobson edited projects, added Web-Team-Backlog (Tracking); removed Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3).Feb 11 2019, 6:06 PM

Tracked on VisualEditor board so moving to tracking.

ppelberg closed this task as Resolved.EditedMar 1 2019, 11:11 PM
ppelberg subscribed.

This looks good.

Steps taken to test/confirm...

  1. In Chrome, navigate to https://en.m.wikipedia.org/wiki/Apache_Kafka
  2. Click edit
  3. Switch to mobile VE
  4. Exit editor (tap "X")
  5. View JavaScript Console
  6. Click edit
  7. Switch to mobile VE from wikitext
  8. ✅ "Uncaught TypeError: e is not a constructor" not visible in JavaScript Console.
Liuxinyu970226 unsubscribed.Mar 11 2019, 12:27 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL