As described in T213429#4954219 and confirmed as an issue by @cmadeo in testing there's excess white space. Based on previous conversations, I don't know if this is something that we can remedy, however, I'm documenting here as a known issue.
Description
Details
Related Objects
- Mentioned In
- T218414: Editing toolbar on mobile VE is not sticky (can scroll out of view) on iOS
- Mentioned Here
- T218414: Editing toolbar on mobile VE is not sticky (can scroll out of view) on iOS
rGVED81e2e57a5169: Unwrap a solitary paragraph from data transfer items
rGVEDa9d533280c9d: Localisation updates from https://translatewiki.net.
T213429: Build Section Editing Prototype
Event Timeline
It appears that we no longer need this padding with the new approach to scrolling on iOS!
Change 497483 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] MobileArticleTarget: Remove padding below the surface on iOS
Change 497483 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] MobileArticleTarget: Remove padding below the surface on iOS
I can still reproduce this issue on Beta. Showed it to @ppelberg today, so reopening it.
Looks like we regressed it with the toolbar changes. The existing code should check for whether the keyboard is active, but it actually checks for which toolbar is active – which was equivalent before, but now there is only a single toolbar, so the check does nothing.
Change 535253 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[VisualEditor/VisualEditor@master] ve.ui.Surface: Fix check for active virtual keyboard in #adjustVisiblePadding
Change 535253 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] ve.ui.Surface: Fix check for active virtual keyboard in #adjustVisiblePadding
Change 537178 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (a9d533280)
Change 537178 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (81e2e57a5)
Still reproduce on Beta when I tap at the end of the article, was testing on the same article.