@Samwilson, please note that I've updated all the mockups in the description so that they are correct in all details. I don't know if the changes are significant--typically the changes made are small issues of text styling or something that should not have tripped you up, assuming you were working from the spec.

One item that all have been updated with is that they now show no Categories list at the top. If you've built this already, that's great. We can keep it in. Prateek's idea for what to do with a long list of categories was to show some small number (3?) and then have a More link that shows a popup menu. As I say, I'm OK with that or with dropping.

Before:

After:

I like the links, but in my opinion the left alignment is more legible. Can we at least add some extra spacing between the "Last updated" line and the information below it? And perhaps go back to a table-like format for the "From" and "To" part?

Additionally, in some other languages where the translation for "View all edits" is longer, it can throw off the alignment:

The left alignment would give us more room for a long list of wikis/categories, and they will wrap naturally.

Also, the "Category: NASA, NASA Programs, NASA Space Stations and 24 more" (with the truncation and showing "N more") will require JavaScript, I think, and it will flicker after page load. Correction: It will require JS if you want it to truncate so that the list doesn't wrap onto multiple lines. If you're okay with the list wrapping (like you see for the wiki list on F28428248), then there's no problem.

I agree, left-aligned and with four separate labels looks good and gives plenty of room for long wiki and category lists. Also would mean the long 'view all edits' button would be less likely to get in the way (it'd be next to the two date lines).

Should categories have a dash or something if there are none?

I wonder if categories should be listed at all. It is a "filter", and we don't list other filters (which currently only includes participants). The real issue I see is there's no wiki specified, outside clicking on the link. Another option, and I'm unsure about design, would be to specify the number of categories. That could link to the actual category list, and make it expand.

A long time ago, there was discussion about making the entries in the list of participants and categories into links. This would mean doing away with the inputs (T204168), which ropes back to Sam's point from way back when that you probably won't ever change the entries, only remove or add new ones, hence there may be no need to show them as inputs. My point here is that if we want links to the categories, we can do this where they are already defined. An example:

And for participants (including talk on contribs links):

In T218340#5041832, @MusikAnimal wrote:

Additionally, in some other languages where the translation for "View all edits" is longer, it can throw off the alignment: F28428230

Sorry, the "View all edits" button is getting moved with T218445, so disregard this concern.

@Samwilson, as long as you're working on the filtering UI, would it be OK to ask you to make the fix that @Prtksxna had originally suggested in T207214 . The issue is that long category names run over the edge of the category menu. Prateek suggested we that we don't need to change the size of the entry box, but if we increased the width of the menu—to as the right edge of the Save button—that would help people out. What do you think?

Currently	With the menu fix

I've removed the categories in https://github.com/wikimedia/eventmetrics/pull/240 — ready for review.

The filter messages are also ready for review: https://github.com/wikimedia/eventmetrics/pull/234

I agree with @MusikAnimal that the category links belong in the category panel; let's revisit adding them in a separate ticket.

@jmatazzoni I'll have a look at the dropdown width problem.

Still to come for this ticket are the two points in T218340#5034961.

@Samwilson @MusikAnimal, the issues with the layout for elements above the filter panels/Error box are not part of this ticket, which deals only with the filtering UI. Those elements are part of T218445, and I think the issues have been addressed there. If not let's move the discussion there.

@Samwilson an issue suddenly occurred to me relating to the Partial states. It's quite possible that users will want to get results in the Partial states. What I'd like to do is this:

• Add a line to the partial state Error Box saying that they should Update Data (with a link). I'll put the exact language into the spec if you say it's OK.
• Make a rule saying that any time the user—n either Partial or Valid states—Updates Data, then when the page refreshes a) the filter panels will display as closed while b) l the Error Box message, if relevant (i.e., if we are in Partial) will remain displayed.

So, basically, if you've Updated and you are getting results (i.e., you're not in Unfiltered state) then filter panels display as closed, but you still see Error message if relevant. That way people in Partial will be able to see their results.

Is that OK? Can I add it to this ticket or do I need to make a separate ticket? Is that hard?

@Samwilson, please note: at Sati and Alex's request, I added one more message to the Partial state Error Box messages. (It's the last error message from the list in the Unfiltered state). That means it will be in the "Partial" and "Partial state with Wikidata" Error boxes. This is the message:

• If you combine Categories and Participants, the system will provide metrics for contributions that satisfy both filters (i.e., Category AND Participants).

(Do I need to have Prateek update the mockups? Or is it OK if the text on the mockups is not complete?)

@Samwilson, I've added a spec for the behavior we discussed in Standup today. Find the new spec in the Description under What to do after Updating Data Let me know if you have any questions. .

In T218340#5046099, @jmatazzoni wrote:

@Samwilson, please note: at Sati and Alex's request, I added one more message to the Partial state Error Box messages. (It's the last error message from the list in the Unfiltered state). That means it will be in the "Partial" and "Partial state with Wikidata" Error boxes. This is the message:

Done in PR234. The other bits of this ticket will come in separate patches.

@Samwilson, I've added what will be the last of my tweaks for this ticket (promise!). It is a change, not shown in the mockup, to the language of the "Subtitle" for the Partial states. It's in the Description, but here is what I wrote:

You will get metrics for some but not all of the wikis specified for the event. To calculate figures, you may need to Update data. [Where "Update data" is a link that performs the same function as the Update data button]

@Prtksxna, please take note. I don't know if you want to add this to the mockups or not...

In T218340#5047192, @jmatazzoni wrote:

@Samwilson, I've added what will be the last of my tweaks for this ticket (promise!). It is a change, not shown in the mockup, to the language of the "Subtitle" for the Partial states. It's in the Description, but here is what I wrote:

Cool. I've added this to PR234.

@Samwilson, I have the URLs for the [?] Help icons that were labeled as "to come" until now. I've added them to the Description. For your convenience, I'll put them here, too:

Help icons in the Valid and Partial Error boxes

The address and hover message for both Valid and Partial states are the same

• URL: https://meta.wikimedia.org/wiki/Event_Metrics#Filtering_is_required
• Hover text: Learn more about how filtering works

Help icon inside the Participants filter panel

• URL: https://meta.wikimedia.org/wiki/Event_Metrics#Filter_by_Participants
• Hover text: Learn about Participant filtering

Help icon inside the Categories filter panel

• URL: https://meta.wikimedia.org/wiki/Event_Metrics#Filter_by_Categories
• Hover text: Learn about Categories filtering

(And now I really, really am done with this spec!)

PR234 is merged and ready to be seen on the staging site.

Remaining parts of this to come soon...

@jmatazzoni: Does the "Settings successfully completed or updated. Click "Update data" to calculate metrics." green banner stay showing always, even after the stats have been updated? At the moment it disappears after update, but from the spec it sounds like it should stay there always.

https://github.com/wikimedia/eventmetrics/pull/246 contains the rest of the filtering logic.

The last part of this will be the "Changes to instruction text and labels of filter panels" (we're still waiting for design for this, according to the spec). One point however: I think the URLs should follow the form that I've just added for the help-links in the error boxes, i.e. this sort of thing so that the target can be moved around as required in that page.

The final patch for this is ready for review: https://github.com/wikimedia/eventmetrics/pull/249

In T218340#5056878, @Samwilson wrote:

@jmatazzoni: Does the "Settings successfully completed or updated. Click "Update data" to calculate metrics." green banner stay showing always, even after the stats have been updated? At the moment it disappears after update, but from the spec it sounds like it should stay there always.

Good question @Samwilson. I've added the answer to the description above. Here it is, for your convenience:

• The green banner shown below appears ONLY until the user has "Calculated totals" (and it appears every time the page loads until the user Calculates totals). Once totals have been calculated, the banner disappears but the status messages/icons continue to display.

In addition, I've made some adjustments to the messaging, based on the fact that I didn't fully understand some of the existing functionality. Find those adjustments in T219436.

I think everything in this ticket is merged now and ready for QA on the staging site. The remaining parts will be done in T219436.

@Samwilson, great work on this! I found a few small things to fix.

• Missing green checkmark: in the Valid state, I'm not seeing the green glyphyicon-ok in the filter chrome.
• Info-sign icon should be blue In the Unfiltered with Wikidata state, the glyphicon-info-sign icon is meant to be blue.

In Unfiltered state when Wikidata is one of multiple wikis specified

• **Do not show the "Unfiltered with Wikidata" state (as currently happens). I've renamed that "Unfiltered with Wikidata ONLY," to make it more clear that this state applies, as the spec says, when "only one wiki is specified for the event: Wikidata."
• **So, when Wikidata is one of several wikis specified, and none are filtered, just show the standard Unfiltered state. (Yes, users might not handle Wikidata right on the first Save, but I don't want to overload them in this firsts screen.)

In the Partial with Wikidata state, when multiple wikis are specified and Wikidata and at least 1 other wiki are not filtered

• Everything looks good except the the first bullet point about "The following wikis require filtering..." should also include Wikidata. (Currently it lists only the other wikis).

In Partial with Wikidata, when 1) multiple wikis are specified, but 2) Wikidata is the only one not filtered**

You’ve kind of invented a new state here. It’s just like the one above, but you’ve closed the Categories filter panel—which is nice. I like it. But just do the following:

• Currently the first bullet point listing the uncovered wikis is omitted entirely. It should not be omitted: include it and list Wikidata as the wiki that "requires filtering." (In other words, this is just as above but with the twist that the Categories panel is closed)
• QA as of 4/1: This one has gone backwards. Not only are you not showing the first bullet, but now Participants is closed too. Again, you can fix in two ways, as yo prefer: 1) If you want to make this one exactly like the one above—which is to say, both filter panels are open—that is fine, 2) or just show Participants as open. But in either case, provide the first bullet point, listing the wikis that need attention (which will be Wikidata).

The above points have all been addressed and the code for them is merged and ready for QA.

Thanks @jmatazzoni, I'm fixing up the missing bits now.

It seems that I was blind earlier when I said that everything was merged; it wasn't, there is still PR269. Moving this back to needs review.

Another PR: https://github.com/wikimedia/eventmetrics/pull/272 (I hope no one minds me keeping these small; it seems easier to review this way.)

@jmatazzoni When there are multiple wikis and Wikidata is the only one not filtered and the participants panel is open, should the 'Required for Wikidata [red asterisk]' be present on that panel?

@Samwilson, better but still a few small issues unsolved. Please see below.

Partial state with Wikidata (when multiple wikis are specified and Wikidata and at least 1 other wiki are not filtered)

This looks correct overall but it no longer shows the following Status message & icon (see screenshot)

• Participants: Required for Wikidata [icon="glyphicon-asterisk"]

Partial with Wikidata, when 1) multiple wikis are specified, but 2) Wikidata is the only one not filtered**

In addition to the problem above (wrong status message/icon), both panels are closed.

• Let's make it simple and make this state the same as the one above. I.e., the 6 bullet points, "Required for wikidata" status message/icon on Participants panel, both panels open.

Last (hopefully!) PR: https://github.com/wikimedia/eventmetrics/pull/276

Merged. Ready for QA.