Page MenuHomePhabricator

Homepage: drop shadow on start module should disappear when all complete
Closed, ResolvedPublicBUG REPORT

Description

Steps to Reproduce:

Complete all actions on your newcomer homepage. This means the user must have a confirmed email, have clicked the "Tutorial" link, and have created a user page.

Actual Results:

Start module continues to have heavy drop shadow.

image.png (374×874 px, 51 KB)

Expected Results:

Start module's drop shadow becomes light.

Note: it is not important to do this before the May 2 release.

Event Timeline

Change 507592 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/GrowthExperiments@master] Start: remove drop-shadow when completed

https://gerrit.wikimedia.org/r/507592

Change 507592 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Start: remove drop-shadow when completed

https://gerrit.wikimedia.org/r/507592

Checked in betalabs - the shadow is completely removed:

Screen Shot 2019-05-02 at 9.40.28 AM.png (363×915 px, 55 KB)

I think I made a mistake here.

Start module's drop shadow becomes light.

It is supposed to be light like all other modules but it was removed completely. I can easily fix it.

Change 507839 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/GrowthExperiments@master] Start: light drop-shadow when the module is not completed

https://gerrit.wikimedia.org/r/507839

Change 507839 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Start: light drop-shadow when the module is not completed

https://gerrit.wikimedia.org/r/507839