Page MenuHomePhabricator
Create Task
Maniphest T222714

Remove the code for the first interface
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Remove all code related to the first interface from the code base, including:

  • code
  • i18n messages ( en and qqq )
  • ruby browser tests
  • old interface phpunit tests
  • interface switch config variable ( in the code )

Also running ruby selenium tests for TwoColConflict will be unnecessary .

  • ruby selenium test CI trigger

Details

SubjectRepoBranchLines +/-
Remove left over from old two column conflict UI triggermediawiki/extensions/VisualEditormaster+1 -5
Remove the code for the first interfacemediawiki/extensions/TwoColConflictmaster+17 -3 K
Remove ruby selenium browser testsmediawiki/extensions/TwoColConflictmaster+0 -672
Remove Ruby browser tests for TwoColConflictintegration/configmaster+0 -2
Remove ruby selenium browser tests for TwoColConflictintegration/configmaster+0 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

WMDE-Fisch created this task.May 7 2019, 1:36 PM
• Lea_WMDE added a subtask: T222441: TwoColConflict browser tests are flapping.May 14 2019, 9:04 AM
• Lea_WMDE added a subtask: T208994: Flaky TwoColConflict test "The help dialog is visible" (mwselenium).
WMDE-Fisch updated the task description. (Show Details)May 21 2019, 1:46 PM
WMDE-Fisch set the point value for this task to 5.
gerritbot added a comment.May 21 2019, 4:52 PM

Change 511754 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/TwoColConflict@master] Remove selenium browser tests

https://gerrit.wikimedia.org/r/511754

gerritbot added a project: Patch-For-Review.May 21 2019, 4:52 PM
WMDE-Fisch mentioned this in rESCCb6b4f16a7abc: Remove selenium browser tests.May 21 2019, 4:55 PM
gerritbot added a comment.May 22 2019, 7:13 AM

Change 511812 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[integration/config@master] Remove selenium browser tests for TwoColConflict

https://gerrit.wikimedia.org/r/511812

hashar added a parent task: T220035: Drop Ruby Selenium CI jobs; we don't support them any more.May 22 2019, 7:17 AM
WMDE-Fisch mentioned this in rESCCccd377e8567a: Remove ruby selenium browser tests.May 22 2019, 7:19 AM
gerritbot added a comment.May 22 2019, 7:21 AM

Change 511812 merged by jenkins-bot:
[integration/config@master] Remove ruby selenium browser tests for TwoColConflict

https://gerrit.wikimedia.org/r/511812

gerritbot added a comment.May 22 2019, 8:09 AM

Change 511824 had a related patch set uploaded (by Awight; owner: Awight):
[integration/config@master] Remove Ruby browser tests for TwoColConflict

https://gerrit.wikimedia.org/r/511824

gerritbot added a comment.May 22 2019, 8:15 AM

Change 511824 merged by jenkins-bot:
[integration/config@master] Remove Ruby browser tests for TwoColConflict

https://gerrit.wikimedia.org/r/511824

gerritbot added a comment.May 22 2019, 9:32 AM

Change 511754 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Remove ruby selenium browser tests

https://gerrit.wikimedia.org/r/511754

Maintenance_bot removed a project: Patch-For-Review.May 22 2019, 10:22 AM
WMDE-Fisch mentioned this in T224122: 20% maintenance tasks in QWERTY sprint 2019-05-15.May 22 2019, 2:11 PM
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.7; 2019-05-28).May 25 2019, 1:01 AM
thiemowmde updated the task description. (Show Details)May 29 2019, 6:27 PM
thiemowmde closed subtask T222441: TwoColConflict browser tests are flapping as Resolved.
thiemowmde added subscribers: thiemowmde, awight.
thiemowmde closed subtask T208994: Flaky TwoColConflict test "The help dialog is visible" (mwselenium) as Resolved.May 29 2019, 6:31 PM
gerritbot added a comment.Aug 16 2019, 12:16 PM

Change 530565 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/TwoColConflict@master] Remove the code for the first interface

https://gerrit.wikimedia.org/r/530565

gerritbot added a project: Patch-For-Review.Aug 16 2019, 12:16 PM
gerritbot added a comment.Aug 16 2019, 2:47 PM

Change 530565 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Remove the code for the first interface

https://gerrit.wikimedia.org/r/530565

Maintenance_bot removed a project: Patch-For-Review.Aug 16 2019, 3:10 PM
WMDE-Fisch closed this task as Resolved.Aug 16 2019, 4:10 PM
WMDE-Fisch added a project: WMDE-QWERTY-Sprint-2019-08-08.
WMDE-Fisch updated the task description. (Show Details)
WMDE-Fisch moved this task from Sprint Backlog to Done on the WMDE-QWERTY-Sprint-2019-08-08 board.
ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.20; 2019-08-27); removed MW-1.34-notes (1.34.0-wmf.7; 2019-05-28).Aug 20 2019, 9:01 PM
gerritbot added a comment.Jan 24 2022, 2:06 PM

Change 756598 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/VisualEditor@master] Remove left over from old two column conflict UI trigger

https://gerrit.wikimedia.org/r/756598

gerritbot added a project: Patch-For-Review.Jan 24 2022, 2:06 PM
gerritbot added a comment.Jan 25 2022, 11:33 AM

Change 756598 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove left over from old two column conflict UI trigger

https://gerrit.wikimedia.org/r/756598

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.20; 2022-01-31).Jan 25 2022, 12:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits