When opening the publish dialog, the focus is set to <body> instead of to the edit summary field. This is bad for accessibility (keyboard access) and is generally slower for editors.
I don't know exactly since when it happens, but definitely it's not older than a week. First detected on Catalan wikipedia, but since present on all wiki's. (since may 10th train update?)
It happens with the visual editor and the text editor. Checked with Firefox 66 and Chrome 74.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| SaveDialog: Move iOS Safari hack to avoid losing focus | mediawiki/extensions/VisualEditor | master | +4 -4 |
I can also reproduce this on mediawiki.org and de.wikisource. All of these wikis have the SingleEditTab config in common, so perhaps this has some strange effect on the focus. The focus actually isn't even on the dialog, you can't close it by pressing ESC.
Wild guess: Could this be caused by rEVEDf9330c8564ee: Replace the save button with a save tool? At least, that seems to changes how the dialog is invoked.
Change 509790 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] SaveDialog: Move iOS Safari hack to avoid losing focus
Change 509790 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] SaveDialog: Move iOS Safari hack to avoid losing focus
