Page MenuHomePhabricator
Create Task
Maniphest T224929

Not required to choose card type in new Ingenico iframe?
Closed, ResolvedPublic4 Estimated Story Points
Actions

Description

From Sam:

Sadok was testing our payments form and made this discovery, which I've confirmed; + a comment from Peter earlier today indicates that it's more widely known! But to get everyone on the same page:

  • Open payments wiki w/ Ingenico as the processor
  • Enter the required Billing info and select a card type. Then the fun starts
  • Your card type is identified after you begin entering your credit card #
  • If you enter a string of test #s (ex. 3333) an inline error message tells you the card doesn't validate
  • Most weird: You're able to submit a donation using a card type that doesn't match your initial card selection (for ex., I choose American Express but check out via my Mastercard)

So: is specific card selection still required with the new iframe? Or could we remove that step?

From David:
We need the user to take some action on this page to submit their data and load the iframe. Maybe we could swap those buttons for a "continue" button?

Details

SubjectRepoBranchLines +/-
No Card Selector Ingenico Variantmediawiki/extensions/DonationInterfacemaster+77 -2
Customize query in gerrit

Related Objects

Event Timeline

• DStrine created this task.Jun 3 2019, 7:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 3 2019, 7:28 PM
• DStrine moved this task from Triage to Q3 2021-2022 on the Fundraising-Backlog board.Jun 3 2019, 7:29 PM
• DStrine added a subscriber: • jrobell.Jun 24 2019, 5:49 PM

@spatton @jrobell @Ppena Like I said we still need a continue button. Do you just want to do this across the board or A/B?

Pcoombe added a comment.Jun 24 2019, 7:38 PM

This is a major change, I'm pretty sure it should be an A/B test first if possible.

spatton added a comment.Jun 24 2019, 8:16 PM

+1 to what Peter said. Is that a big task, @DStrine?

EWilfong_WMF subscribed.Jul 2 2019, 10:01 PM
spatton added a comment.Jul 17 2019, 2:35 PM

Pinging this @DStrine, could you give us a time estimate re: implementing this, vs. setting up as a variant we can test?

• DStrine changed the point value for this task from 0 to 4.Jul 17 2019, 4:59 PM
• DStrine moved this task from Q3 2021-2022 to Sprint +2 on the Fundraising-Backlog board.Jul 23 2019, 4:57 PM
Ejegg mentioned this in T169795: Labels for payments form fields.Aug 21 2019, 2:59 AM
• DStrine moved this task from Sprint +2 to Sprint +1 on the Fundraising-Backlog board.Sep 13 2019, 6:10 PM
• DStrine moved this task from Sprint +1 to Current Sprint on the Fundraising-Backlog board.Sep 17 2019, 8:04 PM
• DStrine added a project: Fundraising Sprint Sysadmin Kane.Sep 17 2019, 8:13 PM
Ejegg subscribed.Sep 17 2019, 8:17 PM

We're currently depending on this choice to tell Civi which type of credit card was used. When we take these buttons away we'll need to get that data from somewhere the GetHostedCheckoutResponse, under createdPaymentOutput -> payment -> paymentOutput -> cardPaymentMethodSpecificOutput -> paymentProductId.

XenoRyet claimed this task.Sep 17 2019, 10:59 PM
XenoRyet moved this task from Backlog to Doing on the Fundraising Sprint Sysadmin Kane board.
Ejegg added a subscriber: Cstone.Sep 17 2019, 11:49 PM

@XenoRyet want to work with @Cstone on this? We went over this in tech talk and think we might have worked out a simple way to do it.

XenoRyet added a comment.Sep 17 2019, 11:50 PM

Yea, I'll try to catch up with her in the morning. Also spaced on tech-talk, sorry about that.

gerritbot added a comment.Sep 18 2019, 11:41 PM

Change 537775 had a related patch set uploaded (by XenoRyet; owner: XenoRyet):
[mediawiki/extensions/DonationInterface@master] WIP No Card Selector Ingenico Variant

https://gerrit.wikimedia.org/r/537775

gerritbot added a project: Patch-For-Review.Sep 18 2019, 11:41 PM
XenoRyet moved this task from Doing to Review on the Fundraising Sprint Sysadmin Kane board.Sep 24 2019, 10:56 PM
XenoRyet moved this task from Review to Pending Deployment on the Fundraising Sprint Sysadmin Kane board.Sep 27 2019, 5:31 PM
gerritbot added a comment.Sep 27 2019, 8:20 PM

Change 537775 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] No Card Selector Ingenico Variant

https://gerrit.wikimedia.org/r/537775

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.25; 2019-10-01).Sep 27 2019, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 27 2019, 9:10 PM
XenoRyet moved this task from Pending Deployment to Deployed on the Fundraising Sprint Sysadmin Kane board.Sep 30 2019, 7:24 PM
XenoRyet added a comment.Sep 30 2019, 7:26 PM

@Pcoombe @spatton We did set this up as a variant, and it is deployed to production now. You can test it by setting the variant to 'noCardSelect', like so:

https://payments.wikimedia.org/index.php?title=Special:IngenicoGateway&appeal=JimmyQuote&ffname=cc-vmad&recurring=false&payment_method=cc&amount=2.75&uselang=en&country=US&currency=USD&variant=noCardSelect

Cstone closed this task as Resolved.Oct 1 2019, 8:35 PM
MBeat33 mentioned this in T234953: Donors seeing only *some* card types on form.Oct 8 2019, 4:14 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL