Page MenuHomePhabricator

Rename Special:ElectronPdf to Special:Download as Pdf or Special:Export as Pdf
Closed, ResolvedPublic

Description

Now that Electron is Proton, this Special Page name makes little sense. It should be renamed to something more future proof.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdlrobson added a project: good first task.
Jdlrobson added a subscriber: Jdlrobson.

Makes sense to me. Olga is this something we should do or RI? Seems relatively trivial.

Special:DownloadAsPdf is probably more in line with current naming conventions, I don't think we have any special page with space in its name.

Change 527203 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/ElectronPdfService@master] Rename Special:ElectronPdf to Special:DownloadAsPdf

https://gerrit.wikimedia.org/r/527203

Any chance of a review Gergo on https://gerrit.wikimedia.org/r/527203 ?
It's a shame the extension is called ElectronPdfService. There should be a rule against mentioning any kind of technology in an extension name..

It's possible to rename the extension, if someone feels they have the time for it. Create a new repo, import the old one into it, remove "electron" everywhere, deploy it to production, switch, undeploy the old one, rename things in mw.org and Phab... probably a bit more work than worth it though.

(And yes, if all the extension does is fetch a configurable remote URL, don't build assumptions about the service behind that URL into the name.)

Jdlrobson added a subscriber: Krinkle.

Who maintains this extension? I got a +1 from @Krinkle on the patch: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/ElectronPdfService/+/527203/
but I don't know how to get this maintained. Is this something Code stewardship reviews can help with?

Jdlrobson changed the task status from Open to Stalled.Oct 2 2019, 10:35 PM

Who maintains this extension?

https://www.mediawiki.org/wiki/Developers/Maintainers lists WMDE Engineering as code stewards. And FYI, https://wikimedia.biterg.io/goto/425b70151ed4eeb9a8e43a86d3453e73 lists which people (and organizations) have contributed to ElectronPdfService code.

Change 527203 abandoned by Jdlrobson:
Rename Special:ElectronPdf to Special:DownloadAsPdf

https://gerrit.wikimedia.org/r/527203

It should be renamed to something more future proof.

Is the special page actually able to accommodate multiple backends? If not, it would be inappropriate to "steal" a generic name which could be useful for more generic or different solutions in the future (or by other extensions not meant for Wikimedia wikis).

We already have Special:Book as a multipurpose special page which handles multiple backends, maybe this special page should be merged into that?

Aklapper changed the task status from Stalled to Open.Apr 17 2020, 11:23 AM

Who maintains this extension? I got a +1 from krinkle on the patch: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/ElectronPdfService/+/527203/
but I don't know how to get this maintained. Is this something Code stewardship reviews can help with?

I don't see why this task was marked as stalled. If code stewardship is unclear then there should be a dedicated task under Code-Stewardship-Reviews

Change 527203 restored by TheDJ:
[mediawiki/extensions/ElectronPdfService@master] Rename Special:ElectronPdf to Special:DownloadAsPdf

https://gerrit.wikimedia.org/r/527203

Change 527203 merged by jenkins-bot:
[mediawiki/extensions/ElectronPdfService@master] Rename Special:ElectronPdf to Special:DownloadAsPdf

https://gerrit.wikimedia.org/r/527203

TheDJ assigned this task to Jdlrobson.

I merged the patch by jon, as it is sufficient to solve this problem and it mirrors the textual labels of the links. Simple solutions, no one is merging special pages and extensions any time soon. If you want another extension to use Special:DownloadAsPdf... well don't install both at the same time. :)