Page MenuHomePhabricator

Rename Special:ElectronPdf to Special:Download as Pdf or Special:Export as Pdf
Open, LowPublic


Now that Electron is Proton, this Special Page name makes little sense. It should be renamed to something more future proof.

Event Timeline

TheDJ created this task.Jun 4 2019, 12:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdlrobson added a project: good first bug.
Jdlrobson added a subscriber: Jdlrobson.

Makes sense to me. Olga is this something we should do or RI? Seems relatively trivial.

Tgr added a subscriber: Tgr.Jul 9 2019, 11:21 AM

Special:DownloadAsPdf is probably more in line with current naming conventions, I don't think we have any special page with space in its name.

Fito awarded a token.Jul 18 2019, 1:25 AM

Change 527203 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/ElectronPdfService@master] Rename Special:ElectronPdf to Special:DownloadAsPdf

Jdlrobson triaged this task as Low priority.Aug 1 2019, 7:50 PM

Any chance of a review Gergo on ?
It's a shame the extension is called ElectronPdfService. There should be a rule against mentioning any kind of technology in an extension name..

Tgr added a comment.Aug 2 2019, 8:04 AM

It's possible to rename the extension, if someone feels they have the time for it. Create a new repo, import the old one into it, remove "electron" everywhere, deploy it to production, switch, undeploy the old one, rename things in and Phab... probably a bit more work than worth it though.

(And yes, if all the extension does is fetch a configurable remote URL, don't build assumptions about the service behind that URL into the name.)