Page MenuHomePhabricator
Create Task
Maniphest T225620

Special:CXStats fails to load if there is no published translations
Closed, ResolvedPublic
Actions

Description

Found while helping @Jpita to setup his local dev environment. When trying to visit Special:CXStats, page never loads. With debug=1 flag, following trace is logged in console:

"Wikimedia\Rdbms\DBQueryError at /Users/josepita/code/mediawiki/core/includes/libs/rdbms/database/Database.php(1586)
#0 /Users/josepita/code/mediawiki/core/includes/libs/rdbms/database/Database.php(1554): Wikimedia\Rdbms\Database->getQueryExceptionAndLog(string, integer, string, string)
#1 /Users/josepita/code/mediawiki/core/includes/libs/rdbms/database/Database.php(1274): Wikimedia\Rdbms\Database->reportQueryError(string, integer, string, string, boolean)
#2 /Users/josepita/code/mediawiki/core/includes/libs/rdbms/database/Database.php(1782): Wikimedia\Rdbms\Database->query(string, string)
#3 /Users/josepita/code/mediawiki/core/extensions/ContentTranslation/includes/Translation.php(363): Wikimedia\Rdbms\Database->select(array, array, array, string, array)
#4 /Users/josepita/code/mediawiki/core/extensions/ContentTranslation/api/ApiQueryContentTranslationLanguageTrend.php(43): ContentTranslation\Translation::getDeletionTrend(string)
#5 /Users/josepita/code/mediawiki/core/includes/api/ApiQuery.php(250): ApiQueryContentTranslationLanguageTrend->execute()
#6 /Users/josepita/code/mediawiki/core/includes/api/ApiMain.php(1595): ApiQuery->execute()
#7 /Users/josepita/code/mediawiki/core/includes/api/ApiMain.php(531): ApiMain->executeAction()
#8 /Users/josepita/code/mediawiki/core/includes/api/ApiMain.php(502): ApiMain->executeActionWithErrorHandling()
#9 /Users/josepita/code/mediawiki/core/api.php(87): ApiMain->execute()
#10 {main}"

This happens when there are no edits on local wiki. After publishing some translation with CX and visiting Special:CXStats loads correctly.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Avoid query errors in Translation::getDeletionTrendmediawiki/extensions/ContentTranslationmaster+5 -4
Customize query in gerrit

Event Timeline

• Petar.petkovic created this task.Jun 12 2019, 11:57 AM
• Petar.petkovic moved this task from Needs Triage to Bugs on the ContentTranslation board.
Nikerabbit added a comment.Jun 13 2019, 6:43 AM

Could try replacing https://gerrit.wikimedia.org/g/mediawiki/extensions/ContentTranslation/+/115b8c9ad4e44655bbdc8d1d0a4ebbe3965f51dc/includes/Translation.php#344 with return [].

• Petar.petkovic added a comment.Jun 13 2019, 8:08 AM
In T225620#5255813, @Nikerabbit wrote:

Could try replacing https://gerrit.wikimedia.org/g/mediawiki/extensions/ContentTranslation/+/115b8c9ad4e44655bbdc8d1d0a4ebbe3965f51dc/includes/Translation.php#344 with return [].

Yes, I think that line is the culprit for this error. There is similar query and error being caught in another API as well.
If I setup new wiki sometimes, I'll try remembering to fix this.

• Jpita added a comment.Jun 13 2019, 8:35 AM
In T225620#5255936, @Petar.petkovic wrote:
In T225620#5255813, @Nikerabbit wrote:

Could try replacing https://gerrit.wikimedia.org/g/mediawiki/extensions/ContentTranslation/+/115b8c9ad4e44655bbdc8d1d0a4ebbe3965f51dc/includes/Translation.php#344 with return [].

Yes, I think that line is the culprit for this error. There is similar query and error being caught in another API as well.
If I setup new wiki sometimes, I'll try remembering to fix this.

you can't "reset" the environment?

Nikerabbit added a comment.Jun 13 2019, 1:06 PM
In T225620#5255997, @Jpita wrote:

you can't "reset" the environment?

One can do a fresh install by dropping the database. But on the other hand, at least my own development and testing environment has accumulated a bunch of content over time that has been useful to have around when testing stuff.

Nikerabbit claimed this task.Apr 8 2020, 7:07 AM
Nikerabbit added projects: Language-Team (Language-2020-Focus-Sprint), Wikimedia-production-error.
gerritbot added a comment.Apr 8 2020, 7:14 AM

Change 587486 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/ContentTranslation@master] Avoid query errors in Translation::getDeletionTrend

https://gerrit.wikimedia.org/r/587486

gerritbot added a project: Patch-For-Review.Apr 8 2020, 7:14 AM
Nikerabbit triaged this task as Medium priority.Apr 8 2020, 7:15 AM
Nikerabbit moved this task from Priority Backlog to In Review on the Language-Team (Language-2020-Focus-Sprint) board.
gerritbot added a comment.Apr 8 2020, 8:54 AM

Change 587486 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Avoid query errors in Translation::getDeletionTrend

https://gerrit.wikimedia.org/r/587486

Maintenance_bot removed a project: Patch-For-Review.Apr 8 2020, 9:11 AM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.28; 2020-04-14).Apr 8 2020, 10:00 AM
Krinkle moved this task from Untriaged to Apr 2020 on the Wikimedia-production-error board.Apr 8 2020, 4:00 PM
• Rileych moved this task from In Review to Recheck after deployment on the Language-Team (Language-2020-Focus-Sprint) board.Apr 9 2020, 1:10 PM
Nikerabbit moved this task from Recheck after deployment to Done on the Language-Team (Language-2020-Focus-Sprint) board.Apr 17 2020, 7:00 AM

Checked that https://hyw.wikipedia.org/wiki/%D5%8D%D5%BA%D5%A1%D5%BD%D5%A1%D6%80%D5%AF%D5%B8%D5%B2:ContentTranslationStats loads.

Jdforrester-WMF moved this task from Apr 2020 to Resolved on the Wikimedia-production-error board.Apr 29 2020, 4:57 PM
Krinkle closed this task as Resolved.Apr 29 2020, 7:03 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits