| Urbanecm | |
| Jun 21 2019, 7:05 PM |
| F29715963: Screen Shot 2019-07-08 at 4.34.22 PM.png | |
| Jul 8 2019, 11:50 PM |
Hey all,
all Growth-team made products, which adds discussion posts, currently add a signature as its own line. At cswiki, a signature is usually added right after the last sentence.
Can this be changed, please? Also, @revi, can you comment what's common on kowiki?
Thanks,
Martin
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Signature should not be at its own line | mediawiki/extensions/GrowthExperiments | master | +1 -1 |
Change 518717 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/extensions/GrowthExperiments@master] Signature should not be at its own line
For Korean Wikipedia either own line or just after the last paragraph is both fine. If you just want to follow cswiki rules on kowiki, that's fine from kowiki perspective.
@Urbanecm -- that would be fine with me. Could you tell us exactly how to format it? Should it contain two dashes (--) or something, like the following:
This is my help question. -- ~~~~
@Urbanecm -- sounds good. I see that you already have a patch for this. We should make sure this patch applies to the help panel, homepage help module, and homepage mentorship module. I'm moving this to Code Review.
Change 518717 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Signature should not be at its own line
@MMiller_WMF - moved to PM Review for information only.
Checked in betalabs (from Homepage Mentor and Help modules and from Help panel) - a signature is correctly placed:
