Page MenuHomePhabricator
Create Task
Maniphest T227899

Error message should display when content in search field is in an unacceptable format
Closed, ResolvedPublic
Actions

Description

As per the mockup, it's confusing if there is no error message to direct a contributor to input their website correctly.

errormessage.png (732×442 px, 93 KB)

Details

SubjectRepoBranchLines +/-
Add validation feedback to external linkmediawiki/extensions/VisualEditormaster+20 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

• iamjessklein created this task.Jul 12 2019, 3:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 12 2019, 3:51 PM
• iamjessklein updated the task description. (Show Details)Jul 12 2019, 3:51 PM
Esanders subscribed.Jul 15 2019, 12:22 PM
gerritbot added a comment.Jul 15 2019, 2:01 PM

Change 523170 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Add validation feedback to external link

https://gerrit.wikimedia.org/r/523170

gerritbot added a project: Patch-For-Review.Jul 15 2019, 2:01 PM
Esanders added a comment.EditedJul 15 2019, 2:01 PM

As implemented:

image.png (240×456 px, 20 KB)

Edit: Copy changed to less jargon-y "Enter a full URL, ..." at @matmarex's suggestions

gerritbot added a comment.Jul 15 2019, 10:51 PM

Change 523170 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Add validation feedback to external link

https://gerrit.wikimedia.org/r/523170

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.14; 2019-07-16).Jul 15 2019, 11:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 15 2019, 11:10 PM
matmarex edited projects, added VisualEditor (Current work); removed VisualEditor.Jul 15 2019, 11:12 PM
matmarex moved this task from Incoming to QA on the VisualEditor (Current work) board.
matmarex added a project: Editing QA.Jul 15 2019, 11:27 PM
matmarex moved this task from Inbox to High Priority on the Editing QA board.Jul 15 2019, 11:31 PM
Esanders added a subscriber: matmarex.Jul 16 2019, 10:20 AM
• iamjessklein added a comment.Jul 16 2019, 12:08 PM

@Esanders - what's the final copy?

Esanders added a comment.Jul 16 2019, 1:51 PM

"Enter a full URL, e.g. https://example.org"

JTannerWMF mentioned this in T227894: [EPIC] User Testing Outcomes.Jul 16 2019, 11:29 PM
Esanders merged a task: T228231: Edit Cards: Change error text color to red.Jul 17 2019, 12:18 PM
Esanders added a subscriber: ppelberg.

Styling the input text as red would be an upstream change in OOUI, and would effect many more use cases, as this is a standardised widget.

We've decided to leave as is for now, and @iamjessklein may file an upstream task against OOUI to discuss this.

Ryasmeen edited projects, added Verified; removed Editing QA.Jul 26 2019, 3:09 PM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.
ppelberg closed this task as Resolved.Jul 26 2019, 3:17 PM
ppelberg claimed this task.
ppelberg added a parent task: T221247: [Epic] Mobile context items.Jul 26 2019, 4:45 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits