Problem
All EditAttemptStep events that aren't creating a new page (identified by page_id != 0) should have a valid revision_id (the newly saved revision for saveSuccess events, and the base revision for the edit for all the rest).
However, some events don't. This is the count of non-page creating events with a revision ID of 0 during the 90 days ending 4 February 2019.
platform | editor_interface | abort | firstChange | init | loaded | ready | saveAttempt | saveFailure | saveIntent | saveSuccess |
---|---|---|---|---|---|---|---|---|---|---|
desktop | visualeditor | 53,000 | 28,000 | 71,000 | 63,000 | 63,000 | 22,000 | 5,300 | 21,000 | 220 |
desktop | wikitext | 820,000 | 1,200,000 | 0 | 2,400,000 | 2,400,000 | 0 | 0 | 0 | 0 |
desktop | wikitext-2017 | 12 | 31 | 26 | 21 | 23 | 9 | 1 | 14 | 0 |
phone | visualeditor | 130 | 36,000 | 210,000 | 120,000 | 120,000 | 23,000 | 3,500 | 27,000 | 580 |
phone | wikitext | 67,000 | 21,000 | 470,000 | 400,000 | 400,000 | 17,000 | 1,100 | 23,000 | 280 |
This appears to be happening across all our editors, but not really affecting saveSuccess events (probably thanks to our recent work on T226847).
The desktop wikitext editor is the most heavily affected. Here's the problematic events as a proportion of all events:
platform | editor_interface | abort | firstChange | init | loaded | ready | saveAttempt | saveFailure | saveIntent | saveSuccess |
---|---|---|---|---|---|---|---|---|---|---|
desktop | visualeditor | 3.4% | 12.6% | 4.3% | 4.1% | 4.1% | 12.0% | 13.2% | 11.9% | 0.1% |
desktop | wikitext | 51.4% | 88.0% | 0.0% | 70.1% | 70.1% | 0.0% | 0.0% | 0.0% | 0.0% |
desktop | wikitext-2017 | 0.1% | 0.1% | 0.1% | 0.0% | 0.1% | 0.0% | 0.1% | 0.0% | 0.0% |
phone | visualeditor | 0.0% | 4.0% | 4.3% | 3.7% | 3.7% | 3.5% | 4.2% | 3.7% | 0.1% |
phone | wikitext | 1.5% | 3.6% | 5.5% | 4.9% | 4.9% | 3.5% | 3.3% | 3.2% | 0.1% |