Page MenuHomePhabricator

Wrong section in edit summary of mobile editor
Open, Needs TriagePublic

Description

Edit: https://ro.m.wikipedia.org/wiki/Special:MobileDiff/13023738

Edit was made with the wikitext editor by clicking on the edit button corresponding to the section that was to be deleted.

When saving, I was not given the option to see or edit the section in the summary. Instead of adding the current section name (or at least the L2 section name, "Istorie") the first L2 section name was added.

Event Timeline

Strainu created this task.Aug 9 2019, 7:39 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 9 2019, 7:39 AM
phuedx added a subscriber: phuedx.Aug 15 2019, 11:31 AM

When saving, I was not given the option to see or edit the section in the summary.

Did you see the "Previewing <foo>" overlay? If so, then it sounds like the API request to generate the edit preview failed silently. If not, then this is a serious bug.

Instead of adding the current section name (or at least the L2 section name, "Istorie") the first L2 section name was added.

When I try to edit a section on https://en.m.wikipedia.beta.wmflabs.org/wiki/Cat, I don't see any placeholder text in the edit summary box. Is the request that when you click the edit button corresponding to section "Foo", then "Foo" should be the default edit summary?

Strainu added a comment.EditedAug 15 2019, 12:12 PM

When saving, I was not given the option to see or edit the section in the summary.

Did you see the "Previewing <foo>" overlay? If so, then it sounds like the API request to generate the edit preview failed silently. If not, then this is a serious bug.

I did see the overlay, with the edit description box and nothing (no preview) under it. As I was deleting a section, this seemed correct to me.

Is the request that when you click the edit button corresponding to section "Foo", then "Foo" should be the default edit summary?

It's more important that the final result (the description of the edit in the page history) is correct. Showing "/* Foo */" as default edit summary is optional, but I would appreciate it - there are cases (such as renaming a section) when I feel the need to edit that part.

Jdlrobson added a subscriber: Jdlrobson.

the first L2 section name was added.

This has nothing to do with MobileFrontend as far as I can tell. We don't autogenerate any kind of summary and as far as I can tell it comes from ~/core/includes/Linker.php

When saving, I was not given the option to see or edit the section in the summary. Instead of adding the current section name (or at least the L2 section name, "Istorie") the first L2 section name was added.

There should be an option to edit the summary. As Phuedx says it probably died silently. This is a bug that can be fixed in the editor and probably best handled by editing team.

JTannerWMF added a subscriber: JTannerWMF.

We will take a look at this