| • alexhollender_WMF | |
| Sep 17 2019, 10:42 PM |
| F30456475: image.png | |
| Sep 24 2019, 9:28 PM |
| F30383377: image.png | |
| Sep 17 2019, 10:42 PM |
There are two issues with the editor-loading header:
Seems to be caused by a line-height applying to the icon that should be removed:
.ve-mobile-fakeToolbar .mw-ui-icon-mf-spinner {
/* line-height: 3em; */| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| mobile.init/fakeToolbar: Tweak vertical centering | mediawiki/extensions/MobileFrontend | master | +0 -1 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | ovasileva | T226562 AMC - display labels for toolbar actions on larger screens | |||
| Resolved | • alexhollender_WMF | T229440 [EPIC] Refactor icon sizing in MF/Minerva to achieve consistency | |||
| Resolved | • alexhollender_WMF | T233171 [ICONS] editor-loading header |
There is a gap at the bottom of the header (maybe related to T215426?)
This is working fine for me, could be an iOS issue? Or maybe already fixed?
Change 538934 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/MobileFrontend@master] mobile.init/fakeToolbar: Tweak vertical centering
Change 538934 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] mobile.init/fakeToolbar: Tweak vertical centering
This patch should fix vertical centering (issue 2), but I don't know if it does anything about the gap in the border (issue 1), because I found no way to reproduce that one.
