Page MenuHomePhabricator

Update mediawiki/mediawiki-codesniffer for php7.3 support in release branches
Open, Needs TriagePublic

Description

A backport to REL1_31 for CentralAuth failed on CI due to CodeSniffer being incompatible with php7.3. https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CentralAuth/+/496331/

The branch has "mediawiki/mediawiki-codesniffer": "17.0.0" which is not 7.3 compatible. It is a known issue fixed several time, for those tasks that got filled with PHP 7.3 support:

Should we go through all extensions and bump PHP CodeSniffer? Or alternatively do we have a way to magically make old versions php7.3 aware?

Event Timeline

hashar created this task.Sep 24 2019, 9:06 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 24 2019, 9:06 PM
hashar updated the task description. (Show Details)Sep 24 2019, 9:06 PM

Change 538973 had a related patch set uploaded (by Hashar; owner: Hashar):
[mediawiki/extensions/CentralAuth@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/538973

Change 538973 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/538973

Change 616166 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@REL1_31] Upgrade mediawiki-codesniffer to 19.1.0 for PHP 7.3 support

https://gerrit.wikimedia.org/r/616166

Change 616166 merged by Bartosz Dziewoński:
[mediawiki/extensions/VisualEditor@REL1_31] Upgrade mediawiki-codesniffer to 19.1.0 for PHP 7.3 support

https://gerrit.wikimedia.org/r/616166