Page MenuHomePhabricator
Create Task
Maniphest T233759

Update mediawiki/mediawiki-codesniffer for php7.3 support in release branches
Closed, ResolvedPublic
Actions

Description

A backport to REL1_31 for CentralAuth failed on CI due to CodeSniffer being incompatible with php7.3. https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CentralAuth/+/496331/

The branch has "mediawiki/mediawiki-codesniffer": "17.0.0" which is not 7.3 compatible. It is a known issue fixed several time, for those tasks that got filled with PHP 7.3 support:

Should we go through all extensions and bump PHP CodeSniffer? Or alternatively do we have a way to magically make old versions php7.3 aware?

Details

SubjectRepoBranchLines +/-
Upgrade mediawiki-codesniffer for php7.3 supportmediawiki/extensions/PopupsREL1_31+1 -1
Upgrade mediawiki-codesniffer for php7.3 supportmediawiki/extensions/GlobalUsageREL1_31+2 -1
Upgrade mediawiki-codesniffer to 19.1.0 for PHP 7.3 supportmediawiki/extensions/VisualEditorREL1_31+2 -1
Upgrade mediawiki-codesniffer for php7.3 supportmediawiki/extensions/CentralAuthREL1_31+20 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

hashar created this task.Sep 24 2019, 9:06 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 24 2019, 9:06 PM
hashar updated the task description. (Show Details)Sep 24 2019, 9:06 PM
gerritbot added a comment.Sep 24 2019, 9:22 PM

Change 538973 had a related patch set uploaded (by Hashar; owner: Hashar):
[mediawiki/extensions/CentralAuth@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/538973

gerritbot added a project: Patch-For-Review.Sep 24 2019, 9:22 PM
hashar added subscribers: Umherirrender, Legoktm.Sep 24 2019, 9:23 PM
hashar mentioned this in T225325: LibraryUpgrader CI normalisation tasks, June/July 2019.Sep 24 2019, 9:32 PM
gerritbot added a comment.Sep 25 2019, 9:34 AM

Change 538973 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/538973

Maintenance_bot removed a project: Patch-For-Review.Sep 25 2019, 10:10 AM
Daimona mentioned this in T104807: Older hidden versions of a currently-public AbuseFilter are exposed via diffs (CVE-2019-18612).Oct 29 2019, 4:58 PM
Jdforrester-WMF mentioned this in T236070: Bump PHPCS version in REL1_31 extensions.Jan 7 2020, 9:57 PM
Reedy mentioned this in T229731: Global blocks: if an IP is within two ranges and one is locally disabled, GlobalBlock won't listen to the other one (CVE-2020-10534).Mar 13 2020, 8:46 PM
Reedy added a subtask: T236071: Add support for MW branches to LibUp.Apr 6 2020, 4:36 PM
Reedy added a subtask: T236070: Bump PHPCS version in REL1_31 extensions.
Jdforrester-WMF subscribed.Apr 8 2020, 5:52 PM
gerritbot added a comment.Jul 24 2020, 8:50 PM

Change 616166 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@REL1_31] Upgrade mediawiki-codesniffer to 19.1.0 for PHP 7.3 support

https://gerrit.wikimedia.org/r/616166

gerritbot added a project: Patch-For-Review.Jul 24 2020, 8:50 PM
gerritbot added a comment.Jul 24 2020, 9:03 PM

Change 616166 merged by Bartosz Dziewoński:
[mediawiki/extensions/VisualEditor@REL1_31] Upgrade mediawiki-codesniffer to 19.1.0 for PHP 7.3 support

https://gerrit.wikimedia.org/r/616166

Maintenance_bot removed a project: Patch-For-Review.Jul 24 2020, 9:10 PM
Umherirrender mentioned this in T259384: MediaWiki codesniffer fails on php7.3 for MobileFrontend extension.Jul 31 2020, 7:46 PM
Reedy moved this task from Backlog to Bundled extensions/skins on the PHP 7.3 support board.Nov 10 2020, 10:16 PM
gerritbot added a comment.Dec 22 2020, 9:43 PM

Change 651591 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/GlobalUsage@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/651591

gerritbot added a project: Patch-For-Review.Dec 22 2020, 9:43 PM
gerritbot added a comment.Dec 22 2020, 10:50 PM

Change 651591 merged by jenkins-bot:
[mediawiki/extensions/GlobalUsage@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/651591

Maintenance_bot removed a project: Patch-For-Review.Dec 22 2020, 11:10 PM
Legoktm closed subtask T236071: Add support for MW branches to LibUp as Resolved.Jan 1 2021, 4:42 AM
Umherirrender closed this task as Resolved.Jan 1 2021, 2:45 PM

Work in progress, some repos still missing, but bot/libup is running,
see https://libraryupgrader2.wmcloud.org/library/composer/mediawiki/mediawiki-codesniffer?branch=REL1_31 for the progress

More track under libup task: T236070

gerritbot added a comment.Jan 4 2021, 11:59 AM

Change 654214 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/Popups@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/654214

gerritbot added a project: Patch-For-Review.Jan 4 2021, 11:59 AM
gerritbot added a comment.Jan 4 2021, 12:08 PM

Change 654214 merged by Umherirrender:
[mediawiki/extensions/Popups@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/654214

Maintenance_bot removed a project: Patch-For-Review.Jan 4 2021, 12:10 PM
Umherirrender closed subtask T236070: Bump PHPCS version in REL1_31 extensions as Resolved.Jan 5 2021, 2:01 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL