Page MenuHomePhabricator

[AMC] fix alignment of "Saved filters" button on AMC watchlist page
Closed, ResolvedPublic2 Story Points

Description

Description

The Saved filters should be aligned with the main content on the page (left-aligned for LTR languages and right-aligned for RTL languages), and also needs some padding added to the top.

currentupdated

acceptance criteria

  • the design should be mobile first
  • Should require no changes to Minerva.

Developer notes

The rule .mw-rcfilters-ui-watchlistTopSectionWidget-savedLinks { float: right} is added by resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.WatchlistTopSectionWidget.less

This should be restricted to tablets.
In mobile, add the additional vertical padding.

QA Results

ACStatusDetails
1T235536#5623935

Details

Related Gerrit Patches:

Event Timeline

Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptTue, Oct 15, 4:35 PM
ovasileva triaged this task as High priority.Tue, Oct 15, 5:01 PM
ovasileva set the point value for this task to 2.Thu, Oct 17, 5:12 PM

Change 545626 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] Saved filters button should be responsive

https://gerrit.wikimedia.org/r/545626

Change 545626 merged by jenkins-bot:
[mediawiki/core@master] Saved filters button should be responsive

https://gerrit.wikimedia.org/r/545626

Edtadros claimed this task.Mon, Oct 28, 5:08 PM
Edtadros reassigned this task from Edtadros to ovasileva.Thu, Oct 31, 4:20 PM
Edtadros added a subscriber: Edtadros.

Test Result

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome
Device: MBP
Emulated Device: iPhoneX

Test Artifact(s):

The Saved filters should be aligned with the main content on the page (left-aligned for LTR languages and right-aligned for RTL languages), and also needs some padding added to the top.

Edtadros updated the task description. (Show Details)Thu, Oct 31, 4:21 PM
ovasileva closed this task as Resolved.Mon, Nov 4, 5:37 PM

all done!