Page MenuHomePhabricator

[AMC] fix alignment of "Saved filters" button on AMC watchlist page
Closed, ResolvedPublic2 Estimated Story Points

Description

Description

The Saved filters should be aligned with the main content on the page (left-aligned for LTR languages and right-aligned for RTL languages), and also needs some padding added to the top.

currentupdated

acceptance criteria

  • the design should be mobile first
  • Should require no changes to Minerva.

Developer notes

The rule .mw-rcfilters-ui-watchlistTopSectionWidget-savedLinks { float: right} is added by resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.WatchlistTopSectionWidget.less

This should be restricted to tablets.
In mobile, add the additional vertical padding.

QA Results

ACStatusDetails
1T235536#5623935

Event Timeline

Change 545626 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] Saved filters button should be responsive

https://gerrit.wikimedia.org/r/545626

Change 545626 merged by jenkins-bot:
[mediawiki/core@master] Saved filters button should be responsive

https://gerrit.wikimedia.org/r/545626

Edtadros added a subscriber: Edtadros.

Test Result

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome
Device: MBP
Emulated Device: iPhoneX

Test Artifact(s):

The Saved filters should be aligned with the main content on the page (left-aligned for LTR languages and right-aligned for RTL languages), and also needs some padding added to the top.