Change 548573 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/skins/MinervaNeue@master] Enable Back-to-top and Categories button in AMC

https://gerrit.wikimedia.org/r/548573

I started working on it

If we don't want to put the back to top feature in AMC mode, we might want to turn it into a gadget.

That would mean we would need to deploy the gadget across all Wikimedia projects. Adding definitions and creating JS pages, too much work, don't you think? Besides gadgets don't work without JS (except CSS only gadgets).

This will likely affect most of the mobile users. @Johan should we announce this in the next Tech news?

When would this happen?

Made a note in the task description as well. I'm not sure back to top makes sense as a part of AMC (as it's not an editing-focused workflow). That, given the bugs with it overlapping other things make me think that it's best to remove it for now. We'll have a better version of navigation once we get to making the sticky headers work(T151115: [EPIC] Improve in-article navigation), although admittedly that won't be in the near future.

@Ammarpad, @Masumrezarock100 it sounds like the core web team need to chat about this and make some decisions before pushing forward with the change. @Johan I'll let you know when that's happened and move this out the "upcoming" column which allows us to have that discussion.

@Johan we've had the chat: looks like we will be aiming for the week of 18th November (no train up until then). The user notice should be something along these lines.
"The mobile beta mode has been disabled for the forseeable future, to reduce the maintenance burden of the mobile site, in preparation for the team's focus on the desktop improvements project. Disruption should be minimal - users wanting the categories feature should enable the AMC mode. A jump back to top feature has been removed and should be replaced with [[ https://en.m.wikipedia.org/wiki/User:Jdlrobson/scripts/backtotop.js | a gadget/user script ]]if necessary."

@Ammarpad the plan is now to remove the back to top code and associated feature flag. You should feel free to continue your patch!

In T237290#5637795, @Jdlrobson wrote:

@Ammarpad the plan is now to remove the back to top code and associated feature flag. You should feel free to continue your patch!

Noted. Thanks

@Jdlrobson Thank you. Simplified the sentence structure and added it to https://meta.wikimedia.org/wiki/Tech/News/2019/47 which will be delivered to the wikis on Monday November 18.

Change 549698 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/skins/MinervaNeue@master] Discontinue back-to-top feature

https://gerrit.wikimedia.org/r/549698

Change 548573 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Enable Categories button in AMC

https://gerrit.wikimedia.org/r/548573

Change 549698 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Discontinue back-to-top feature

https://gerrit.wikimedia.org/r/549698

When we disable beta we run into the issue described in T198265. However given T233741 that might be another way to resolve this. For now I suggest making the settings link JS-only and only revealing it if settings are available. I can work on this..

Change 556473 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Disable BETA mode

https://gerrit.wikimedia.org/r/556473

In T237290#5733551, @Jdlrobson wrote:

When we disable beta we run into the issue described in T198265. However given T233741 that might be another way to resolve this. For now I suggest making the settings link JS-only and only revealing it if settings are available. I can work on this..

Thank you Jon.

blocked on a decision on T198265: Special:MobileOptions is empty for third parties and when beta is disabled and this is confusing

Options are:

1. Settings link redirects to login link.
2. Settings is hidden for non-JavaScript
3. Settings page shows some text that prompts the user to login.
4. do nothing.

We're leaning towards option 2 as it's the most straightforward (we do this already for the Nearby page) . @ovasileva does that work for you?

Edit: "but this will remove AMC for users with JavaScript disabled or old browsers (likely a small and maybe even empty group of people)" < this is not true. I've realised we can keep it for those users, so this seems like a no brainer?

Change 562607 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[operations/mediawiki-config@master] Disable beta (for now)

https://gerrit.wikimedia.org/r/562607

In T237290#5783644, @Jdlrobson wrote:

Options are:

1. Settings link redirects to login link.
2. Settings is hidden for non-JavaScript
3. Settings page shows some text that prompts the user to login.
4. do nothing.

We're leaning towards option 2 as it's the most straightforward (we do this already for the Nearby page) . @ovasileva does that work for you?

Edit: "but this will remove AMC for users with JavaScript disabled or old browsers (likely a small and maybe even empty group of people)" < this is not true. I've realised we can keep it for those users, so this seems like a no brainer?

Yay, okay, in that case hiding it makes the most sense. So no settings but if they've already turned it on it will stay on?

SWAT scheduled for 11am PST tomorrow.
Review needed on https://gerrit.wikimedia.org/r/c/556473

I've moved this to Needs More Work as the patch that @Jdlrobson posted above (which disables mobile beta by default) causes tests to fail. One possibility would be to alter the tests so that they skip if mobile beta is disabled, e.g.

@categories
Feature: Categories

...

Before( { tags: '@categories' }, () => {
  const IP = path.resolve( __dirname, '../../../../../' );
  const config = require( path.resolve( IP, 'extensions/MobileFrontend/extension.js' ).config;

  // See https://github.com/cucumber/cucumber-js/blob/master/docs/support_files/hooks.md#skipping-in-a-before-hook
  return !!config.MFBeta ? 'skipped' : null;
} );

Change 562607 merged by jenkins-bot:
[operations/mediawiki-config@master] Drop beta setting.

https://gerrit.wikimedia.org/r/562607

Mentioned in SAL (#wikimedia-operations) [2020-01-09T19:13:04Z] <urbanecm@deploy1001> Synchronized wmf-config/mobile.php: SWAT: 2f9ee90: Drop beta setting (T237290) (duration: 01m 06s)

Change 563268 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Categories browser test only runs if the feature is enabled

https://gerrit.wikimedia.org/r/563268

Change 563268 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Categories browser test only runs if the feature is enabled

https://gerrit.wikimedia.org/r/563268

Change 556473 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Disable BETA mode

https://gerrit.wikimedia.org/r/556473