Page MenuHomePhabricator

Unable to respond to specific comments
Open, Needs TriagePublic

Description

As reported here [1], it is not possible to reply to the following comments posted to this talk page [2]:

  • Comment posted at 16:30, 10 December 2019 (UTC)
  • Comment posted at 02:50, 12 December 2019 (UTC)

Expected behavior

  1. Go to: https://en.wikipedia.beta.wmflabs.org/wiki/Talk:Cats
  2. Click the "Reply" link appended to either of the following comments:
    • Comment posted at 16:30, 10 December 2019 (UTC)
    • Comment posted at 02:50, 12 December 2019 (UTC)
  3. Compose a reply
  4. Click "Reply"
  5. ✅ Notice your comment has successfully been published to the talk page

Actual behavior

  1. Go to: https://en.wikipedia.beta.wmflabs.org/wiki/Talk:Cats
  2. Click the "Reply" link appended to either of the following comments:
    • Comment posted at 16:30, 10 December 2019 (UTC)
    • Comment posted at 02:50, 12 December 2019 (UTC)
  3. Compose a reply
  4. Click "Reply"
  5. ⚠️ Notice a yellow rectangular highlight appears where one would expect their comment to be posted, but your comment has not been posted to the talk page and no trace of the comment you just "posted" is shown in the talk page's History page.

Additional context

The person who first reported this issue, @Alsee, noted this earlier edit might be the cause of the inability to reply the comments above.


  1. https://www.mediawiki.org/w/index.php?title=Topic:Vcwvt3bq03o5gv8h&topic_showPostId=vd8593amh18c3myw#flow-post-vd8593amh18c3myw
  2. https://en.wikipedia.beta.wmflabs.org/wiki/Talk:Cats

Details

Related Gerrit Patches:
mediawiki/extensions/DiscussionTools : master[WIP] Pick reply insertion point based on parser tree, not DOM tree

Event Timeline

ppelberg created this task.Mon, Dec 23, 9:49 PM
ppelberg updated the task description. (Show Details)
ppelberg updated the task description. (Show Details)Mon, Dec 23, 10:07 PM
ppelberg removed ppelberg as the assignee of this task.Mon, Jan 6, 12:14 AM
matmarex claimed this task.Tue, Jan 14, 5:28 PM

I guess somebody cleaned up the page since this task was filed, as I don't see the comment a 02:50. I see the comment at 16:30 (the first comment on the page) and I can reproduce the problem with it, though. For reference, I was testing on this revision: https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Talk:Cats&oldid=410946

The beginning of the page looks like this:

1== How can we make this article better? ==
2
3this article is a good start, but I think we could add some deeper topics and information here. [[Special:Contributions/10.0.3.1|10.0.3.1]] 16:30, 10 December 2019 (UTC)
4
5: Is there a cat show, something similar to the [[National_Dog_Show]]? This would be a useful type of event to reference on this page. [[User:Yatu|Yatu]] ([[User talk:Yatu|talk]]) 19:21, 11 December 2019 (UTC)
6:: There is a national Cat Show. it's held every year in Pasadena in conjunction with the Rose parade. It specifically is for people who are not into football. [[Special:Contributions/192.168.122.1|192.168.122.1]] 21:32, 11 December 2019 (UTC)
7:test [[User:Yatu|Yatu]] ([[User talk:Yatu|talk]]) 19:27, 27 December 2019 (UTC)
8::testy [[Special:Contributions/68.195.105.134|68.195.105.134]] ([[User talk:68.195.105.134|talk]]) 08:15, 31 December 2019 (UTC)
9:::Hello.<ref name="1nbsp;&nbsp;2">Source one, source two</ref> Goodbye. [[Special:Contributions/68.195.105.134|68.195.105.134]] ([[User talk:68.195.105.134|talk]]) 08:15, 31 December 2019 (UTC)
10::::Hello2 [[Special:Contributions/68.195.105.134|68.195.105.134]] ([[User talk:68.195.105.134|talk]]) 08:16, 31 December 2019 (UTC)
11:::::hello3 [[Special:Contributions/68.195.105.134|68.195.105.134]] ([[User talk:68.195.105.134|talk]]) 08:16, 31 December 2019 (UTC)
12::proud to prototype =) [[link]] and with Eve? [[Special:Contributions/85.203.67.228|85.203.67.228]] ([[User talk:85.203.67.228|talk]]) 01:12, 4 January 2020 (UTC)
13:Reply-5 [[Special:Contributions/68.195.105.134|68.195.105.134]] ([[User talk:68.195.105.134|talk]]) 08:22, 31 December 2019 (UTC)
14::{{#if:x|<span style="}} font-weight: bold">red test 2. [[Special:Contributions/68.195.105.134|68.195.105.134]] ([[User talk:68.195.105.134|talk]]) 08:33, 31 December 2019 (UTC)
15:::{{welcome}} [[User:Ppelberg-test|Ppelberg-test]] ([[User talk:Ppelberg-test|talk]]) 20:01, 5 January 2020 (UTC)

Note the big mis-indented block at the end, generated by the {{welcome}} template.

When trying to reply to the comment, the reply is inserted according to the indentation, which happens to be in the middle of the content generated by the {{welcome}} template:

Since we can't represent this in wikitext, the reply then is lost when saving.