Page MenuHomePhabricator

Factor some static methods out of the ChangeTags class
Open, Needs TriagePublic

Description

I'd like to propose that the following methods be moved:

::getSoftwareTags, ::listSoftwareActivatedTags, ::listDefinedTags, ::listExplicitlyDefinedTags, ::listSoftwareDefinedTags
Should be moved to a service that has globals and services injected: wgSoftwareTags, MainWANObjectCache

::tagShortDescriptionMessage, ::tagDescription, ::tagLongDescriptionMessage, ::truncateTagDescription, ::defineTag, ::undefineTag, ::isTagNameValid
should be moved to a ChangeTag (singular) object that represents a specific tag, including providing its description methods

Thoughts?

Event Timeline

Restricted Application added a project: User-DannyS712. · View Herald TranscriptFeb 24 2020, 3:44 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.Feb 24 2020, 3:44 AM

Encapsulating a global state into a class is always a good idea.
At the moment I'm not quite familiar with that area, so can't give you more valuable suggestion.

But I'd appreciate it if you add me as Reviewer.