Page MenuHomePhabricator

Deprecate 'watch' parameter in favor of 'watchlist' parameter in FlaggedRevs stabilize API
Closed, ResolvedPublic

Description

boolean watch= was deprecated in favour of watchlist= way back in 1.17 (T24944), but FlaggedRevs still uses watch=.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 18 2020, 1:58 AM
Amorymeltzer triaged this task as Lowest priority.Mar 18 2020, 1:59 AM
DannyS712 raised the priority of this task from Lowest to Medium.
DannyS712 added a project: MediaWiki-API.

Specifically, ApiStabilizeGeneral and ApiStabilizeProtect need to be updated
See https://www.mediawiki.org/wiki/Special:Code/MediaWiki/r64197 for some background and migrations (also available at https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/88df448d362b1c331bfdb8de69d1818bf6e5316e%5E%21/)

Change 580602 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/FlaggedRevs@master] Update ApiStabilizeGeneral and ApiStabilizeProtect watchlist handling

https://gerrit.wikimedia.org/r/580602

DannyS712 moved this task from To Triage to Not ready to announce on the User-notice board.

Change 580602 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Update ApiStabilizeGeneral and ApiStabilizeProtect watchlist handling

https://gerrit.wikimedia.org/r/580602

DannyS712 closed this task as Resolved.Sat, Aug 29, 2:43 AM
DannyS712 removed a project: Patch-For-Review.
DannyS712 moved this task from Not ready to announce to To Triage on the User-notice board.
Johan added a subscriber: Johan.Mon, Aug 31, 2:08 PM

@DannyS712 How would you phrase this in Tech News?

(I see in Gerrit that there are no known callers (or am I misreading that comment?), if that's the case, which purpose do you think mentioning it serves? So I get the context here.)

@DannyS712 How would you phrase this in Tech News?

(I see in Gerrit that there are no known callers (or am I misreading that comment?), if that's the case, which purpose do you think mentioning it serves? So I get the context here.)

The two api modules used to have watch parameters to either watch the page, or do nothing. Now they have watchlist parameters, with the options being watch, unwatch, preferences (the default) and nochange, and the old watch parameters are deprecated.

Krinkle renamed this task from Deprecate watch in favor of watchlist in stabilize API to Deprecate 'watch' parameter in favor of 'watchlist' parameter in FlaggedRevs ApiStabilizeGeneral.Wed, Sep 9, 2:56 PM
Krinkle renamed this task from Deprecate 'watch' parameter in favor of 'watchlist' parameter in FlaggedRevs ApiStabilizeGeneral to Deprecate 'watch' parameter in favor of 'watchlist' parameter in FlaggedRevs stabilize API.
Krinkle updated the task description. (Show Details)

FWIW, it looks apihelp-stabilize-param-watchlist needs adding to all the i18n pages. Presumably it can just copy the text used everywhere by apihelp-*-param-watchlist in core?