| Tsevener | |
| Apr 1 2020, 5:11 PM |
| F31829834: Screen Shot 2020-05-18 at 6.46.41 AM.png | |
| May 18 2020, 10:47 AM |
| F31819866: Screen Shot 2020-05-15 at 9.57.06 AM.png | |
| May 15 2020, 4:01 PM |
| F31720704: screenshot_01.jpg | |
| Apr 1 2020, 5:11 PM |
Light background on the graphs
Dark background on the graphs
From OTRS:
In darkmode transparent PNGs have black or gray background. Maybe they should also be white.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix background color for transparent graphs in dark/black mode | mediawiki/services/mobileapps | master | +6 -0 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T252904 Issues with dark mode / non-white reading themes | |||
| Resolved | BUG REPORT | Jgiannelos | T249143 [Testflight Screenshots]: transparent PNGs in dark mode |
Change 596634 had a related patch set uploaded (by Jgiannelos; owner: Jgiannelos):
[mediawiki/services/mobileapps@master] Fix background color for transparent graphs in dark/black mode
@cmadeo @schoenbaechler
Here's a screenshot of how the page would look like after the change:
http://localhost:8888/de.wikipedia.org/v1/page/mobile-html/COVID-19-Pandemie_in_Deutschland?theme=dark
Edit: You can see the used background color value in the patch linked above.
Not sure why all the sections on this page are collapsed. I had to open the "Statistiken und Fallzahlen" heading to see the graph.
Being an editor and this being late enough to be in my spare time, I've simply added it since it fixes a problem that ought to be fixed.
(But they used flagged revisions and I'm only an occasional editor on German Wikipedia, so someone else needs to accept the edit.)
@Julle I made one small tweak - it needed to be class="hintergrundfarbe1 notheme" instead of class="hintergrundfarbe1" class="notheme" but it is fixed now. Thanks!
@JoeWalsh Should we consider fixing it in the user level by adding notheme as a solution for all similar issues or is it just a workaround for this wiki article specifically?
@Jgiannelos yes, it should be fixed at the user level with notheme for all similar issues. The context here is that we previously maintained a more extensive list of exclusions and it became untenable. There's not clear documentation so the confusion is understandable. I'll add this info to the comment at the top of ThemeTransform.css and a section in the pcs.md doc.
Change 596634 abandoned by Jgiannelos:
Fix background color for transparent graphs in dark/black mode
Reason:
Issue fixed in the user level by adding notheme to the png