Page MenuHomePhabricator

[Testflight Screenshots]: transparent PNGs in dark mode
Closed, ResolvedPublicBUG REPORT


Repro steps

  1. Open
  2. Look at the graphs in the "Statistiken und Fallzahlen" section


Light background on the graphs

Screen Shot 2020-05-18 at 6.46.41 AM.png (1×2 px, 482 KB)


Dark background on the graphs

screenshot_01.jpg (1×828 px, 131 KB)


From OTRS:

In darkmode transparent PNGs have black or gray background. Maybe they should also be white.

Event Timeline

Change 596634 had a related patch set uploaded (by Jgiannelos; owner: Jgiannelos):
[mediawiki/services/mobileapps@master] Fix background color for transparent graphs in dark/black mode

@cmadeo @schoenbaechler

Here's a screenshot of how the page would look like after the change:

Screen Shot 2020-05-15 at 9.57.06 AM.png (959×960 px, 179 KB)

Edit: You can see the used background color value in the patch linked above.
Not sure why all the sections on this page are collapsed. I had to open the "Statistiken und Fallzahlen" heading to see the graph.

@Johan would it be possible to get the editors to add a "notheme" class to the divs with the "hintergrundfarbe1" class in this article? This was the approach described in T236137 to work around this issue.

Being an editor and this being late enough to be in my spare time, I've simply added it since it fixes a problem that ought to be fixed.

(But they used flagged revisions and I'm only an occasional editor on German Wikipedia, so someone else needs to accept the edit.)

@Julle I made one small tweak - it needed to be class="hintergrundfarbe1 notheme" instead of class="hintergrundfarbe1" class="notheme" but it is fixed now. Thanks!

JoeWalsh updated the task description. (Show Details)

@JoeWalsh Should we consider fixing it in the user level by adding notheme as a solution for all similar issues or is it just a workaround for this wiki article specifically?

@Jgiannelos yes, it should be fixed at the user level with notheme for all similar issues. The context here is that we previously maintained a more extensive list of exclusions and it became untenable. There's not clear documentation so the confusion is understandable. I'll add this info to the comment at the top of ThemeTransform.css and a section in the doc.

Change 596634 abandoned by Jgiannelos:
Fix background color for transparent graphs in dark/black mode

Issue fixed in the user level by adding notheme to the png