When inserting an image using Visual Editor, show CommonsMetadata content in the language of the wiki
Closed, ResolvedPublic
Actions

Description

I inserted a Commons image using VE into a Hebrew Wikipedia article.

The image has structured media descriptions in English and Hebrew. Despite this, the description in the media insertion dialog appeared in English. Screenshot:

Screenshot_2020-04-05 עריכת הדף התפרצות נגיף הקורונה בישראל – ויקיפדיה.png (1×1 px, 1 MB)

I'd expect it to appear in Hebrew, given that it's the Hebrew Wikipedia. Even nicer would be to have it in Hebrew by default if it's available, and to show a language selector to select other languages, but that would be just a nice bonus.

The file, for reference: https://commons.wikimedia.org/wiki/File:Empty_egg_shelf_in_Jerusalem,_April_2020.jpg

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	master	+33 -3	MediaSearch: Use the specified language for search results

Customize query in gerrit

Related Objects

Mentioned Here: T51662: VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog

Event Timeline

Amire80 created this task.Apr 5 2020, 8:49 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 5 2020, 8:49 AM

Jdforrester-WMF closed this task as a duplicate of T51662: VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog.Apr 6 2020, 8:13 PM

I'm not sure how exactly is it a duplicate of T51662. The meta-data is shown, but in the wrong language.

In T249442#6033961, @Amire80 wrote:

I'm not sure how exactly is it a duplicate of T51662. The meta-data is shown, but in the wrong language.

Yes, that's part of it.

JTannerWMF added a project: Editing-team (Tracking).Apr 7 2020, 3:17 PM

JTannerWMF moved this task from To Triage to Triaged on the VisualEditor board.

JTannerWMF moved this task from Backlog to FY 2019-20 on the Editing-team (Tracking) board.

We use a query like this for the metadata: https://commons.wikimedia.org/w/api.php?action=query&format=jsonfm&origin=*&generator=search&gsrnamespace=6&iiurlheight=200&iiprop=dimensions%7Curl%7Cmediatype%7Cextmetadata%7Ctimestamp%7Cuser&prop=imageinfo&gsrsearch=Empty_egg_shelf_in_Jerusalem%2C_April_2020.jpg&iiurlwidth=400&gsroffset=0&gsrlimit=15

There is a parameter 'iiextmetadatalanguage', it seems that we could use it: https://commons.wikimedia.org/w/api.php?action=query&format=jsonfm&origin=*&generator=search&gsrnamespace=6&iiurlheight=200&iiprop=dimensions%7Curl%7Cmediatype%7Cextmetadata%7Ctimestamp%7Cuser&prop=imageinfo&gsrsearch=Empty_egg_shelf_in_Jerusalem%2C_April_2020.jpg&iiurlwidth=400&gsroffset=0&gsrlimit=15&iiextmetadatalanguage=he

(and it seems to fall back to English if there's no description in the specified language)

It seems to also affect the other fields, e.g. the "Own work" text, which is in English in your screenshot.

Actually, we already have the code that is supposed to use it. Now to find out why it doesn't work…

Change 587342 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] MediaSearch: Use the specified language for search results

https://gerrit.wikimedia.org/r/587342

gerritbot added a project: Patch-For-Review.Apr 7 2020, 9:25 PM

matmarex edited projects, added Editing-team (Q3 2019-2020 Kanban Board); removed Editing-team (Tracking).Apr 7 2020, 9:27 PM

matmarex moved this task from Needs Discussion / Investigation to Code Review on the Editing-team (Q3 2019-2020 Kanban Board) board.

The image has structured media descriptions in English and Hebrew. Despite this, the description in the media insertion dialog appeared in English.

I don't think the description we show is actually fetched from the structured data; I'm pretty sure it comes from the templates in the wikitext description page like {{en|…}} and {{he|…}}. This is implemented by the CommonsMetadata extension and I actually don't know how it works.

I suppose using the structured data falls under T51662.

matmarex updated the task description. (Show Details)Apr 7 2020, 9:30 PM

In T249442#6038028, @matmarex wrote:

The image has structured media descriptions in English and Hebrew. Despite this, the description in the media insertion dialog appeared in English.

I don't think the description we show is actually fetched from the structured data.

Correct.

[…]

I suppose using the structured data falls under T51662.

Indeed, hence why I duped it. :-)

Jdforrester-WMF renamed this task from When inserting an image using Visual Editor, show media description in the language of the wiki to When inserting an image using Visual Editor, show CommonsMetadata content in the language of the wiki.Apr 8 2020, 12:52 AM

Change 587342 merged by jenkins-bot:
[mediawiki/core@master] MediaSearch: Use the specified language for search results

https://gerrit.wikimedia.org/r/587342

Maintenance_bot removed a project: Patch-For-Review.Apr 8 2020, 1:10 PM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.28; 2020-04-14).Apr 8 2020, 2:00 PM

Esanders moved this task from Code Review to QA on the Editing-team (Q3 2019-2020 Kanban Board) board.Apr 13 2020, 2:06 PM

Esanders added a project: Editing QA.

Ryasmeen edited projects, added Verified; removed Editing QA.May 29 2020, 10:07 PM

Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Q3 2019-2020 Kanban Board) board.

ppelberg closed this task as Resolved.Jun 5 2020, 1:24 AM

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJun 5 2020, 1:24 AM

	F31733649: Screenshot_2020-04-05 עריכת הדף התפרצות נגיף הקורונה בישראל – ויקיפדיה.png
	Apr 5 2020, 8:49 AM

When inserting an image using Visual Editor, show CommonsMetadata content in the language of the wikiClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

When inserting an image using Visual Editor, show CommonsMetadata content in the language of the wiki
Closed, ResolvedPublic
Actions