Page MenuHomePhabricator

Increase touch target for edit links
Closed, ResolvedPublic

Description

Parent ticket: T226401#5780144

(16) The edit link within articles is 25dp x 26dp. Please increase to 48dp.

Add margin or padding on the edit pencil should be enough.

Event Timeline

@MSantos , could you please tell if this change sufficient\looks good:

Current variant:

current.png (200×977 px, 10 KB)

New variant:
new.png (201×1 px, 11 KB)

Notes:

  • I can center the pencil icon but in this case the section will look differently from how it looks now, that's why the icon is not in the center of <a> element area.
  • The change is made with increasing width and height of <a> element, removing top marging and removing parent <span> element bottom marging -> so the distance between "References" and "External links" sections remains.

@Art.tsymbar looks good to me, it's meeting the criteria.

There's no need to center the pencil, thanks!

Change 676332 had a related patch set uploaded (by Art.tsymbar; author: arttsymbar):

[mediawiki/services/mobileapps@master] Increasing touch target for edit links

https://gerrit.wikimedia.org/r/676332

Change 676332 merged by jenkins-bot:

[mediawiki/services/mobileapps@master] Increasing touch target for edit links

https://gerrit.wikimedia.org/r/676332