| matmarex | |
| Jun 10 2020, 7:54 PM |
| F31875112: Wikipedia, the free encyclopedia (3).gif | |
| Jun 22 2020, 4:09 PM |
| F31875110: Wikipedia, the free encyclopedia (2).gif | |
| Jun 22 2020, 4:09 PM |
"More" menu in Vector is no longer accessible except by mouse hover. It should also be possible to open it by clicking it, or by keyboard.
The menu's <ul> was wrapped into a <div>: patch 589395 task T249372.
The checkbox hack's CSS selector needs to be updated with the new sibling.
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T255069#6222561 |
| 2 | ✅ | T255069#6222561 PLEASE SEE NOTE |
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T255069#6245066 |
| 2 | ✅ | T255069#6245066 PLEASE SEE NOTE |
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix dropdown menu checkbox hack's CSS selector | mediawiki/skins/Vector | master | +1 -1 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Jdrewniak | T249372 [Dev] DRY up the menu templating code | |||
| Resolved | ovasileva | T255069 "More" menu in Vector is no longer accessible except by mouse hover |
Sounds reasonable, but that's not the case. On version 1.34.1 focus + SPACE toggles the checkbox, but not ENTER. This behavior did not change recently.
It should also be possible to open it by clicking it, or by keyboard.
The checkbox hack's CSS selector broke when the <ul> was wrapped into a <div>.
I have deja vu. Somewhere I've written this should be expected.
Change 605201 had a related patch set uploaded (by Aron Manning; owner: Aron Manning):
[mediawiki/skins/Vector@master] Fix dropdown menu checkbox hack's CSS selector
Change 605201 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Fix dropdown menu checkbox hack's CSS selector
Status: ✅ PASS
Environment: beta
OS: macOS Catalina
Browser: Chrome
Device: MBP
Emulated Device: NA
Test Artifact(s):
✅ AC1: "More" menu should expend when hovered over.
Yes, that's an implementation shortcoming: the mouse is still hovering the menu thus it remains open until the mouse moves out. It's very weird, but it was like that for a very long time.
wmf.37 reached group 2 on 2020-06-17.
This passes ad-hoc testing on enwiki, dewiki, enwikt, meta, mediawiki.
@Edtadros unless you want to do extra testing, I went ahead and boldly closed this.
@Demian, thanks for taking the initiative, below are the documentation and test artifacts for the testing
Status: ✅ PASS
Environment: enwiki
OS: macOS Catalina
Browser: Chrome
Device: MBP
Emulated Device: NA
Test Artifact(s):
✅ AC1: "More" menu should expend when hovered over.
