Page MenuHomePhabricator
Create Task
Maniphest T255177

Tests failing for the master branch of MassMessage
Closed, ResolvedPublic
Actions

Description

Tests are currently failing for the master branch for MassMessage:

https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MassMessage/+/604826/ is an empty patch with only a commit message but it is failing tests

11:35:37 1) MediaWiki\MassMessage\MassMessageListContentHandlerTest::testInvalidEdit
11:35:37 Object of class MediaWiki\Debug\DeprecatablePropertyArray could not be converted to int
11:35:37 
11:35:37 /workspace/src/includes/api/ApiEditPage.php:421
11:35:37 /workspace/src/includes/api/ApiMain.php:1585
11:35:37 /workspace/src/includes/api/ApiMain.php:494
11:35:37 /workspace/src/extensions/MassMessage/includes/Content/MassMessageListContentHandler.php:91
11:35:37 /workspace/src/extensions/MassMessage/tests/phpunit/content/MassMessageListContentHandlerTest.php:77
11:35:37 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:437
11:35:37 /workspace/src/maintenance/doMaintenance.php:105

Caused by 2704be7df8e372348dd85d73656c9f37c8d3bb59 as part of T250638: Replace uses and hard deprecate WikiPage::doEditContent and PageUpdater::getStatus

Details

SubjectRepoBranchLines +/-
Safe-guard switch possibly doing bad comparisonsmediawiki/coremaster+13 -10
Do not return internal edit status from EditPagemediawiki/coremaster+2 -2
Do not return internal edit status from EditPagemediawiki/corewmf/1.35.0-wmf.37+2 -2
Customize query in gerrit

Related Objects

Event Timeline

DannyS712 created this task.Jun 11 2020, 6:38 PM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptJun 11 2020, 6:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 triaged this task as High priority.Jun 11 2020, 6:38 PM
DannyS712 moved this task from Unsorted to Reports on the User-DannyS712 board.
DannyS712 added a subscriber: • Pchelolo.
mdaniels5757 subscribed.Jun 11 2020, 6:56 PM
gerritbot added a comment.Jun 11 2020, 7:04 PM

Change 604839 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] Do not return internal edit status from EditPage

https://gerrit.wikimedia.org/r/604839

gerritbot added a project: Patch-For-Review.Jun 11 2020, 7:04 PM
• Pchelolo moved this task from Inbox to Waiting for Review on the Platform Team Workboards (Clinic Duty Team) board.Jun 11 2020, 7:30 PM
brennen subscribed.EditedJun 16 2020, 8:42 PM

Related to T255614?

gerritbot added a comment.Jun 17 2020, 12:52 AM

Change 604839 merged by jenkins-bot:
[mediawiki/core@master] Do not return internal edit status from EditPage

https://gerrit.wikimedia.org/r/604839

gerritbot added a comment.Jun 17 2020, 12:53 AM

Change 606047 had a related patch set uploaded (by DannyS712; owner: Ppchelko):
[mediawiki/core@wmf/1.35.0-wmf.37] Do not return internal edit status from EditPage

https://gerrit.wikimedia.org/r/606047

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.38; 2020-06-23).Jun 17 2020, 1:00 AM
DannyS712 closed this task as Resolved.Jun 17 2020, 1:01 AM
DannyS712 assigned this task to • Pchelolo.

Backport is for T255614: PHP Notice: Object of class MediaWiki\Debug\DeprecatablePropertyArray could not be converted to int, massmessage master no longer failing

gerritbot added a comment.Jun 17 2020, 8:38 AM

Change 606047 merged by jenkins-bot:
[mediawiki/core@wmf/1.35.0-wmf.37] Do not return internal edit status from EditPage

https://gerrit.wikimedia.org/r/606047

Stashbot added a comment.Jun 17 2020, 8:43 AM

Mentioned in SAL (#wikimedia-operations) [2020-06-17T08:43:05Z] <jforrester@deploy1001> Synchronized php-1.35.0-wmf.37/includes/EditPage.php: T255177 T255614 Do not return internal edit status from EditPage (duration: 01m 08s)

Stashbot mentioned this in T255614: PHP Notice: Object of class MediaWiki\Debug\DeprecatablePropertyArray could not be converted to int.Jun 17 2020, 8:43 AM
Maintenance_bot removed a project: Patch-For-Review.Jun 17 2020, 9:10 AM
thiemowmde mentioned this in T258790: Old wikitext editor no longer displays error message when :Status::newFatal() is called (in TemplateData).Jan 15 2021, 4:18 PM
gerritbot added a comment.Jan 15 2021, 4:22 PM

Change 656444 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/core@master] Safe-guard switch possibly doing bad comparisons

https://gerrit.wikimedia.org/r/656444

gerritbot added a project: Patch-For-Review.Jan 15 2021, 4:22 PM
thiemowmde reopened this task as Open.Jan 15 2021, 4:23 PM
thiemowmde subscribed.

This introduced a regression, see T258790.

matmarex subscribed.Feb 10 2021, 9:20 PM
In T255177#6230380, @gerritbot wrote:

Change 604839 merged by jenkins-bot:
[mediawiki/core@master] Do not return internal edit status from EditPage

https://gerrit.wikimedia.org/r/604839

Reverted in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/656423

gerritbot added a comment.Feb 10 2021, 9:46 PM

Change 656444 merged by jenkins-bot:
[mediawiki/core@master] Safe-guard switch possibly doing bad comparisons

https://gerrit.wikimedia.org/r/656444

matmarex added a comment.Feb 10 2021, 9:51 PM

@Pchelolo Leaving this task open because of your comment on the revert patch ("I'll try to make it respect EditPage contract and not break the editor"), although I think @thiemowmde's patch should also fix the bug. Please close it if you're fine with the current state of it.

Maintenance_bot removed a project: Patch-For-Review.Feb 10 2021, 10:11 PM
• Pchelolo closed this task as Resolved.Mar 4 2021, 2:51 PM

The actual issue described in the task is resolved. We'll look into EditPage when we get to refactoring it.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL