Page MenuHomePhabricator

Tests failing for the master branch of MassMessage
Closed, ResolvedPublic

Description

Tests are currently failing for the master branch for MassMessage:

https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MassMessage/+/604826/ is an empty patch with only a commit message but it is failing tests

11:35:37 1) MediaWiki\MassMessage\MassMessageListContentHandlerTest::testInvalidEdit
11:35:37 Object of class MediaWiki\Debug\DeprecatablePropertyArray could not be converted to int
11:35:37 
11:35:37 /workspace/src/includes/api/ApiEditPage.php:421
11:35:37 /workspace/src/includes/api/ApiMain.php:1585
11:35:37 /workspace/src/includes/api/ApiMain.php:494
11:35:37 /workspace/src/extensions/MassMessage/includes/Content/MassMessageListContentHandler.php:91
11:35:37 /workspace/src/extensions/MassMessage/tests/phpunit/content/MassMessageListContentHandlerTest.php:77
11:35:37 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:437
11:35:37 /workspace/src/maintenance/doMaintenance.php:105

Caused by 2704be7df8e372348dd85d73656c9f37c8d3bb59 as part of T250638: Replace uses and hard deprecate WikiPage::doEditContent and PageUpdater::getStatus

Event Timeline

Restricted Application added a project: User-DannyS712. · View Herald TranscriptJun 11 2020, 6:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 triaged this task as High priority.Jun 11 2020, 6:38 PM
DannyS712 moved this task from Unsorted to Reports on the User-DannyS712 board.
DannyS712 added a subscriber: Pchelolo.

Change 604839 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] Do not return internal edit status from EditPage

https://gerrit.wikimedia.org/r/604839

brennen added a subscriber: brennen.EditedTue, Jun 16, 8:42 PM

Related to T255614?

Change 604839 merged by jenkins-bot:
[mediawiki/core@master] Do not return internal edit status from EditPage

https://gerrit.wikimedia.org/r/604839

Change 606047 had a related patch set uploaded (by DannyS712; owner: Ppchelko):
[mediawiki/core@wmf/1.35.0-wmf.37] Do not return internal edit status from EditPage

https://gerrit.wikimedia.org/r/606047

Change 606047 merged by jenkins-bot:
[mediawiki/core@wmf/1.35.0-wmf.37] Do not return internal edit status from EditPage

https://gerrit.wikimedia.org/r/606047

Mentioned in SAL (#wikimedia-operations) [2020-06-17T08:43:05Z] <jforrester@deploy1001> Synchronized php-1.35.0-wmf.37/includes/EditPage.php: T255177 T255614 Do not return internal edit status from EditPage (duration: 01m 08s)