Page MenuHomePhabricator
Create Task
Maniphest T255427

Survey names should be unique
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Background

Since we can only distinguish between survey initial impressions by using the survey name, it's important that multiple surveys don't share a name at any moment in time. We can add validation to check for this condition.

Steps for QA

  1. Two surveys with the same name would need to be deployed to beta
  2. Check logs for "Bad survey configuration: The survey name XXX is not unique"

Details

SubjectRepoBranchLines +/-
Dramatically simplify uniqueness checkmediawiki/extensions/QuickSurveysmaster+12 -24
Fix broken "survey name must be unique" checkmediawiki/extensions/QuickSurveysmaster+2 -2
Checks name of enabled Quick Survey for duplicate, logs if issuemediawiki/extensions/QuickSurveysmaster+81 -5
WIP: One way of validating unique survey namesmediawiki/extensions/QuickSurveysmaster+43 -4
Extract logic from ServiceWiringmediawiki/extensions/QuickSurveysmaster+41 -23
Customize query in gerrit

Event Timeline

awight created this task.Jun 15 2020, 12:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 15 2020, 12:32 PM
gerritbot added a comment.Jun 15 2020, 1:54 PM

Change 605595 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/QuickSurveys@master] Extract logic from ServiceWiring

https://gerrit.wikimedia.org/r/605595

gerritbot added a project: Patch-For-Review.Jun 15 2020, 1:54 PM
• nray added a project: Web-Team-Backlog (Tracking).Jun 15 2020, 11:00 PM
gerritbot added a comment.Jun 17 2020, 9:36 AM

Change 605595 merged by jenkins-bot:
[mediawiki/extensions/QuickSurveys@master] Extract logic from ServiceWiring

https://gerrit.wikimedia.org/r/605595

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.38; 2020-06-23).Jun 17 2020, 10:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jun 17 2020, 10:10 AM
Jdlrobson moved this task from Backlog to Bugs on the QuickSurveys board.Apr 14 2021, 6:34 PM
• Jhernandez edited projects, added Trust and Safety Tools Team Backlog; removed MW-1.35-notes (1.35.0-wmf.38; 2020-06-23).Sep 30 2021, 7:49 PM
ovasileva moved this task from Untriaged to Discuss further on the Web-Team-Backlog (Tracking) board.Sep 30 2021, 8:45 PM
LGoto removed a project: Web-Team-Backlog (Tracking).Sep 30 2021, 9:10 PM
ARamirez_WMF renamed this task from Survey names should be unique to Survey names should be unique [S].Oct 4 2021, 3:17 PM
ARamirez_WMF triaged this task as Low priority.
ARamirez_WMF moved this task from Needs triage to Ready for development on the Trust and Safety Tools Team Backlog board.
ARamirez_WMF moved this task from Ready for development to Kanban on the Trust and Safety Tools Team Backlog board.
ARamirez_WMF edited projects, added Trust and Safety Tools Team Backlog (Kanban); removed Trust and Safety Tools Team Backlog.
ARamirez_WMF renamed this task from Survey names should be unique [S] to Survey names should be unique .Oct 4 2021, 3:20 PM
ARamirez_WMF set the point value for this task to 2.
• mepps subscribed.Oct 13 2021, 7:57 PM

Would we throw an exception when a survey name is not unique? Because it's read from the config, I'm just wondering when that would get caught and shown to the admin setting it up. If someone accidentally deployed a not unique survey name to prod, I wouldn't want users seeing it.

ARamirez_WMF claimed this task.Oct 14 2021, 2:39 PM
ARamirez_WMF removed ARamirez_WMF as the assignee of this task.
ARamirez_WMF claimed this task.
ARamirez_WMF moved this task from 🎬 Ready to 💻 In Progress on the Trust and Safety Tools Team Backlog (Kanban) board.
ARamirez_WMF moved this task from 💻 In Progress to 🎬 Ready on the Trust and Safety Tools Team Backlog (Kanban) board.
ARamirez_WMF moved this task from 🎬 Ready to 💻 In Progress on the Trust and Safety Tools Team Backlog (Kanban) board.
ARamirez_WMF subscribed.
ARamirez_WMF moved this task from 💻 In Progress to 🔍 Review/Feedback on the Trust and Safety Tools Team Backlog (Kanban) board.Oct 14 2021, 2:44 PM
ARamirez_WMF moved this task from 🔍 Review/Feedback to 💻 In Progress on the Trust and Safety Tools Team Backlog (Kanban) board.Oct 14 2021, 2:48 PM
ARamirez_WMF moved this task from 💻 In Progress to 🔍 Review/Feedback on the Trust and Safety Tools Team Backlog (Kanban) board.
ARamirez_WMF moved this task from 🔍 Review/Feedback to 💻 In Progress on the Trust and Safety Tools Team Backlog (Kanban) board.
ARamirez_WMF moved this task from 💻 In Progress to 🔍 Review/Feedback on the Trust and Safety Tools Team Backlog (Kanban) board.
ARamirez_WMF moved this task from 🔍 Review/Feedback to 🐛 QA on the Trust and Safety Tools Team Backlog (Kanban) board.Oct 14 2021, 2:51 PM
ARamirez_WMF moved this task from 🐛 QA to 💻 In Progress on the Trust and Safety Tools Team Backlog (Kanban) board.
ARamirez_WMF moved this task from 💻 In Progress to 🐛 QA on the Trust and Safety Tools Team Backlog (Kanban) board.
ARamirez_WMF moved this task from 🐛 QA to 🔍 Review/Feedback on the Trust and Safety Tools Team Backlog (Kanban) board.
ARamirez_WMF removed ARamirez_WMF as the assignee of this task.Oct 14 2021, 2:53 PM
ARamirez_WMF claimed this task.
ARamirez_WMF moved this task from 🔍 Review/Feedback to 💻 In Progress on the Trust and Safety Tools Team Backlog (Kanban) board.
ARamirez_WMF moved this task from 💻 In Progress to 🤘 Done on the Trust and Safety Tools Team Backlog (Kanban) board.
ARamirez_WMF moved this task from 🤘 Done to 🐛 QA on the Trust and Safety Tools Team Backlog (Kanban) board.
ARamirez_WMF removed ARamirez_WMF as the assignee of this task.Oct 14 2021, 2:55 PM
ARamirez_WMF moved this task from 🐛 QA to 🎬 Ready on the Trust and Safety Tools Team Backlog (Kanban) board.
gerritbot added a comment.Oct 14 2021, 6:57 PM

Change 730883 had a related patch set uploaded (by Mepps; author: Mepps):

[mediawiki/extensions/QuickSurveys@master] WIP: One way of validating unique survey names

https://gerrit.wikimedia.org/r/730883

gerritbot added a project: Patch-For-Review.Oct 14 2021, 6:57 PM
• mepps updated the task description. (Show Details)Oct 18 2021, 8:07 PM
• mepps updated the task description. (Show Details)
• mepps updated the task description. (Show Details)
• mepps updated the task description. (Show Details)
Madalina added a project: WMF-Safety-Survey.Oct 25 2021, 5:06 PM
• ERayfield claimed this task.Nov 10 2021, 3:30 PM
• ERayfield moved this task from 🎬 Ready to 💻 In Progress on the Trust and Safety Tools Team Backlog (Kanban) board.Nov 10 2021, 4:28 PM
• ERayfield added a comment.Nov 29 2021, 7:12 PM

QUESTION - if there are two (or more) QS with same names, how to specify WHICH is considered the duplicate?

• ERayfield added a comment.Nov 29 2021, 7:39 PM

QUESTION - is this ALL surveys or just Quick Surveys?

ARamirez_WMF added a comment.Dec 1 2021, 3:34 PM

@ERayfield did someone give you an answer to this?

• ERayfield added a comment.Dec 1 2021, 5:21 PM

@ARamirez_WMF , nope, although I am sure it will happen at some point in time

• Jhernandez subscribed.Dec 1 2021, 6:08 PM

I did answer both questions in slack where they were asked as well.

https://wikimedia.slack.com/archives/C0269GFNG3Z/p1638222156195200 and https://wikimedia.slack.com/archives/C0269GFNG3Z/p1638222190195600

In T255427#7535096, @ERayfield wrote:

QUESTION - if there are two (or more) QS with same names, how to specify WHICH is considered the duplicate?

I think Maggie and I assumed the moment you see one with a name you've already seen, that's the one we error as duplicate. I guess that means the second one is the one erroring out.

In T255427#7535222, @ERayfield wrote:

QUESTION - is this ALL surveys or just Quick Surveys?

Joaquin Oltra Hernandez: I don't understand this question. What do you mean All / Quick? QuickSurveys is the extension name, and there you configure surveys. Do you mean internal / external surveys?

Ellen Rayfield:
no, I don't know if there is more than one type of survey - if only dealing with QS, then that is cool. If there are other survey types/definitions that need to be worried about then I am going to get worried

I guess the answer is just QuickSurveys, I'm not sure what other surveys you may be referring to.

gerritbot added a comment.Dec 3 2021, 8:07 PM

Change 743488 had a related patch set uploaded (by EllenR; author: EllenR):

[mediawiki/extensions/QuickSurveys@master] Checks name of enabled Quick Survey for duplicate, logs if issue

https://gerrit.wikimedia.org/r/743488

gerritbot added a comment.Dec 3 2021, 8:40 PM

Change 743488 had a related patch set uploaded (by EllenR; author: EllenR):

[mediawiki/extensions/QuickSurveys@master] Checks name of enabled Quick Survey for duplicate, logs if issue

https://gerrit.wikimedia.org/r/743488

• ERayfield moved this task from 💻 In Progress to 🔍 Review/Feedback on the Trust and Safety Tools Team Backlog (Kanban) board.Dec 3 2021, 8:46 PM
ARamirez_WMF added subscribers: Scardenasmolinar, jsn.sherman.Dec 6 2021, 4:49 PM

@Scardenasmolinar @jsn.sherman we need review for this one :)

jsn.sherman added a comment.Dec 8 2021, 7:14 PM

Reviewed; now it's waiting on a second set of eyes.

gerritbot added a comment.Dec 9 2021, 2:35 PM

Change 743488 merged by jenkins-bot:

[mediawiki/extensions/QuickSurveys@master] Checks name of enabled Quick Survey for duplicate, logs if issue

https://gerrit.wikimedia.org/r/743488

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.13; 2021-12-13).Dec 9 2021, 3:00 PM
Scardenasmolinar moved this task from 🔍 Review/Feedback to 🐛 QA on the Trust and Safety Tools Team Backlog (Kanban) board.Dec 9 2021, 5:04 PM
Scardenasmolinar moved this task from 🐛 QA to 🤘 Done on the Trust and Safety Tools Team Backlog (Kanban) board.Dec 9 2021, 5:15 PM
Madalina closed this task as Resolved.Dec 10 2021, 8:11 PM
gerritbot added a comment.Jan 5 2022, 3:49 PM

Change 730883 abandoned by Mepps:

[mediawiki/extensions/QuickSurveys@master] WIP: One way of validating unique survey names

Reason:

This was just meant as an example.

https://gerrit.wikimedia.org/r/730883

gerritbot added a comment.Sep 19 2022, 6:10 PM

Change 833073 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/QuickSurveys@master] Fix broken "survey name must be unique" check

https://gerrit.wikimedia.org/r/833073

gerritbot added a comment.Sep 19 2022, 6:11 PM

Change 833074 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/QuickSurveys@master] Dramatically simplify uniqueness check

https://gerrit.wikimedia.org/r/833074

gerritbot added a comment.Oct 8 2022, 10:18 PM

Change 833073 merged by jenkins-bot:

[mediawiki/extensions/QuickSurveys@master] Fix broken "survey name must be unique" check

https://gerrit.wikimedia.org/r/833073

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.5; 2022-10-10).Oct 8 2022, 11:00 PM
gerritbot added a comment.Jan 6 2023, 6:39 PM

Change 833074 merged by jenkins-bot:

[mediawiki/extensions/QuickSurveys@master] Dramatically simplify uniqueness check

https://gerrit.wikimedia.org/r/833074

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.18; 2023-01-09); removed MW-1.40-notes (1.40.0-wmf.5; 2022-10-10).Jan 6 2023, 7:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL