pageinfo-footer message in other language falls back to default English message instead of overridden / database English message
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Lucas_Werkmeister_WMDE
	Jul 3 2020, 12:02 PM

Description

Compare:

In English, there are “External tools” and “Alternate views” sections at the bottom, which are missing in French. Those sections are added by the local version of MediaWiki:Pageinfo-footer, and it seems that the French version of that message falls back to the default from en.json (“-”, disabled) rather than to the overridden English message from the MediaWiki namespace:

lucaswerkmeister-wmde@mwdebug1002:~$ mwscript shell.php wikidatawiki
Psy Shell v0.10.4 (PHP 7.2.31-1+0~20200514.41+debian9~1.gbpe2a56b+wmf1 — cli) by Justin Hileman
>>> wfMessage( 'pageinfo-footer' )->inLanguage( 'en' )->text()
=> """
   ==External tools==\n
   \n
   * [//pageviews.toolforge.org?project=wikidata.org&pages=Special:Badtitle/Parser Pageviews Analysis]\n
   \n
   <div style="float:right; font-size:95%;">[[Special:EditPage/MediaWiki:Pageinfo-footer|edit]]</div>
   """
>>> wfMessage( 'pageinfo-footer' )->inLanguage( 'fr' )->text()
=> "-"

This also affects other wikis, e. g.:

enwiki en / fr
dewiki de / fr (but en has the extra sections because MediaWiki:Pageinfo-footer/en exists)

On the other hand, on commonswiki, gsw and bar seem to correctly fall back to MediaWiki:Pageinfo-footer/de.

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		Func	T257037 pageinfo-footer message in other language falls back to default English message instead of overridden / database English message
Open		Func	T229992 Locally created fallback should take precedent over config fallback
Resolved	BUG REPORT	Func	T340840 Viewing non existent message overrides should reflect the reality that it fallback to another local override
Open		None	T342604 Extend deleteEqualMessages.php to delete redundant overrides that are the same as fallbacks
Open		None	T342669 Improve Special:AllMessages
Resolved		Pppery	T64714 Some language tags show wrong language ("English") in Babel boxes
Open		None	T162415 Make global userpage Babel links point to Meta instead of locally.
Open		None	T168799 Integrate IANA language registry with language-data and MediaWiki (let MediaWiki "knows" all languages with ISO 639-1/2/3 codes)
Resolved	BUG REPORT	Seb35	T349115 PHP Notice: Undefined offset: 1 in LocalisationCache.php on line 579

Event Timeline

• Lucas_Werkmeister_WMDE created this task.Jul 3 2020, 12:02 PM

Restricted Application added subscribers: MusikAnimal, Aklapper. · View Herald TranscriptJul 3 2020, 12:02 PM

Apparently, that “-” is somewhere in the LocalisationCache:

lucaswerkmeister-wmde@mwdebug1002:~$ mwscript shell.php wikidatawiki
Psy Shell v0.10.4 (PHP 7.2.31-1+0~20200514.41+debian9~1.gbpe2a56b+wmf1 — cli) by Justin Hileman
>>> $lc = MediaWiki\MediaWikiServices::getInstance()->getLocalisationCache()
=> LocalisationCache {#614}
>>> $lc->getSubitem( 'fr', 'messages', 'pageinfo-footer' )
=> "-"

Which, if I understand the caching documentation correctly, means that MessageCache (sitting on top of the LocalisationCache) can’t detect that it should fall back to the English message.

And the underlying l10n cache files seem to contain the message as well:

lucaswerkmeister-wmde@mwdebug1002:~$ grep pageinfo-footer /srv/mediawiki/php-1.35.0-wmf.39/cache/l10n/*fr.*
/srv/mediawiki/php-1.35.0-wmf.39/cache/l10n/fr.l10n.php:	'messages:pageinfo-footer' => '-',
/srv/mediawiki/php-1.35.0-wmf.39/cache/l10n/fr.l10n.php:				24003 => 'pageinfo-footer',
Binary file /srv/mediawiki/php-1.35.0-wmf.39/cache/l10n/l10n_cache-fr.cdb matches

So it looks like we’re already applying language fallbacks when building the l10n cache, and that probably shouldn’t happen?

• Lucas_Werkmeister_WMDE updated the task description. (Show Details)Jul 3 2020, 12:06 PM

• Lucas_Werkmeister_WMDE updated the task description. (Show Details)

Please confirm whether this is still an issue:

In T229992#8936403, @gerritbot wrote:

Change 924137 merged by jenkins-bot:

[mediawiki/core@master] LocalisationCache: Preserve fallback source language info

https://gerrit.wikimedia.org/r/924137