Page MenuHomePhabricator

Variant C/D: remove header from discovery banner on mobile
Closed, ResolvedPublic

Assigned To
Authored By
MMiller_WMF
Jul 22 2020, 8:29 PM
Referenced Files
F32370483: Screen Shot 2020-10-01 at 5.07.57 PM.png
Oct 2 2020, 12:13 AM
F32366435: discovery-arrow-up-longer-shorter.svg
Sep 28 2020, 11:59 AM
F32353498: discovery-arrow-up-shorter.svg
Sep 17 2020, 10:36 AM
F32353500: image.png
Sep 17 2020, 10:36 AM
F32353466: image.png
Sep 17 2020, 10:36 AM
F32353502: discovery-arrow-up-longer.svg
Sep 17 2020, 10:36 AM
F32353468: image.png
Sep 17 2020, 10:36 AM
F32353470: image.png
Sep 17 2020, 10:36 AM

Description

In T258010: Variant C/D: welcome peek drawer on mobile, we will be adding a drawer to welcome users to their homepage. Therefore, the existing discovery banner at the top of homepage (implemented in T224883: Homepage: discovery of homepage after account creation (mobile)) no longer should have a header that says "Welcome to your homepage". It should be headerless, like this:

image.png (640×360 px, 59 KB)

Event Timeline

Change 623653 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] WIP: Remove header from discovery banner on mobile

https://gerrit.wikimedia.org/r/623653

Change 623653 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Remove header from discovery banner on mobile

https://gerrit.wikimedia.org/r/623653

Checked in betalabs - the banner header is removed:

variation C/Dthe header is present
Screen Shot 2020-09-15 at 1.47.02 PM.png (476×419 px, 48 KB)
Screen Shot 2020-09-15 at 1.48.06 PM.png (467×420 px, 52 KB)

Note: @RHo - should the arrow be moved up, so it'd be connected visually with the text?

Checked in betalabs - the banner header is removed:

variation C/Dthe header is present
Screen Shot 2020-09-15 at 1.47.02 PM.png (476×419 px, 48 KB)
Screen Shot 2020-09-15 at 1.48.06 PM.png (467×420 px, 52 KB)

Note: @RHo - should the arrow be moved up, so it'd be connected visually with the text?

Good note @Etonkovidova. @Kosta - can the two svg arrow assets be updated please with the following SVGs:

Arrow

CurrentUpdated asset)
image.png (338×908 px, 32 KB)
image.png (364×868 px, 34 KB)

Longer arrow

CurrentUpdated asset
image.png (312×1 px, 41 KB)
image.png (340×1 px, 43 KB)

@RHo I might be missing something, but the "Longer arrow" asset looks to be identical to what is in the current screenshot; could you please double check if the SVG you sent is the one you used for the "Updated asset" screenshot?

Change 630564 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] [WIP] Homepage: Show discovery banner with variant specific arrows

https://gerrit.wikimedia.org/r/630564

Aside from the new asset missing (T258652#6498017) the rest of the patch can be reviewed.

@RHo I might be missing something, but the "Longer arrow" asset looks to be identical to what is in the current screenshot; could you please double check if the SVG you sent is the one you used for the "Updated asset" screenshot?

oops sorry @kostajh, here's the right asset:

@RHo I might be missing something, but the "Longer arrow" asset looks to be identical to what is in the current screenshot; could you please double check if the SVG you sent is the one you used for the "Updated asset" screenshot?

oops sorry @kostajh, here's the right asset:

@RHo, sorry I need the longer one, it looks like that is the short version.

Change 630564 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Homepage: Show discovery banner with variant specific arrows

https://gerrit.wikimedia.org/r/630564

@RHo -- resurfacing to make sure you see this request for the right icon.

@RHo -- resurfacing to make sure you see this request for the right icon

oh we resolved this on Slack, it was the right svg so all good.

This looks good to me in beta. To be resolved once it's in production.