Page MenuHomePhabricator

Custom bold and italic icons for Russian & Ukrainian language
Closed, ResolvedPublic

Description

Author: claymore.ws

Description:
Please replace generic icons with Ж (for bold) and К (for italic). German K from http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/UsabilityInitiative/images/wikiEditor/toolbar/button-sprite.png?view=log will do. Ж is available here: http://commons.wikimedia.org/wiki/File:Toolbaricon_bold_%D0%96.png. Thank you in advance.


Version: unspecified
Severity: enhancement

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:02 PM
bzimport added a project: WikiEditor.
bzimport set Reference to bz23914.
bzimport added a subscriber: Unknown Object (MLST).

Hi these have been added to WikiEditor. Please could someone close this as a fix.

I can confirm that buttons Ж (жирный / bold) and К (курсивный / cursive) are available when editing wiki text on ru.wikipedia.org .

I do not see such custom letter icons when editing on uk.wikipedia.org.

Mvolz added a subscriber: Mvolz.

Would the Ukraine follow what was done to Russian by using the same icons as Russian.

Change 258674 had a related patch set uploaded (by Paladox):
Use the same icon as the russian for the ukraine

https://gerrit.wikimedia.org/r/258674

Change 258674 abandoned by Paladox:
Use the same icon as the russian for the ukraine

Reason:
Ive merged this into https://gerrit.wikimedia.org/r/#/c/257978/

https://gerrit.wikimedia.org/r/258674

Change 257978 had a related patch set uploaded (by Paladox):
Add format-bold-Iab image for lang ru, Add format-bold-ru image to lang uk

https://gerrit.wikimedia.org/r/257978

Yurik added a subscriber: Yurik.

I just checked - In source editor, both RU and UK show correct icons -- Ж (жирный / bold) and К (курсивный / cursive). On the other hand, in the Visual Editor, Russian shows proper icon, but Ukranian shows the default "A" icon in the formatting dropdown, even though the textual description is correct. Adding VE.

Right, so:
1: ce wants Iab for bold
2: ru was involved to assist them with advice, but doesn't want any actual changes.
3: this ticket has some old info about uk, probably from when WikiEditor did not have fallback languages yet, but there is no real problem with uk in the WikiEditor anymore.
4: Seems VE does not have language fallback for icons, causing uk to not have the right icons

Ok.

Could we update this task to add info for visualeditor. So uk uses the Russian icon in visualeditor.

Also could we cross out the bit about doing it for uk in wikieditor.

That's because the fallback file in visualeditor is not working. https://github.com/wikimedia/VisualEditor/blob/master/lib/jquery.i18n/src/jquery.i18n.fallbacks.js

I looked at the other lanages that are falling back on Russian but none are showing any Russian icons.

Adding @Jdforrester-WMF since he is the one that works on visual editor and may know how to fix the problem.

That file is only for text not icons. There should be a fallback icon file created.

Change 261041 had a related patch set uploaded (by Paladox):
Lang uk use russian bold and italic icons

https://gerrit.wikimedia.org/r/261041

Change 261041 abandoned by Jforrester:
Lang uk use russian bold and italic icons

https://gerrit.wikimedia.org/r/261041

As far as I can tell all WikiEditor issues were dealt with. If similar changes need to be made to VisualEditor, please file a new ticket for VE, linking back to this one.

Change 274466 had a related patch set uploaded (by Paladox):
Lang uk use russian bold and italic icons

https://gerrit.wikimedia.org/r/274466

Change 274466 merged by jenkins-bot:
editing-styling pack: Have uk fallback to use ru bold and italic icons

https://gerrit.wikimedia.org/r/274466