Page MenuHomePhabricator

[Spike,1hr] Consider whether "Article" tab's and VE's left-most edge should have borders
Closed, InvalidPublicSpike

Description

As @Esanders observed in T259083#6348592:

Behavior

Actual
The "Article" tab's and VE's left-most edge do NOT have any border:

image.png (161×387 px, 16 KB)

Expected
TBD – further discussion needed. See "Open questions" below.

Open questions

  • How should people see the "Article" tab's and VE's left-most edge?

Done

  • All "Open questions" are answered
  • If relevant, "Expected" behavior is implemented.

Outcome

The issue has been discussed with all stakeholders and the result of that conversation is documented with a comment and/or new implementation task.

Event Timeline

@ppelberg - for now, this is due to the new fixed with applied on the article tabs (i.e. it's imperfect but by current design). It's persistent within and outside of VE. I'll let @alexhollender speak to whether we want to tackle this at the moment or wait for some of the aesthetic refinements:

Screen Shot 2020-07-31 at 10.14.49 AM.png (1×2 px, 833 KB)

Jdlrobson renamed this task from Consider whether "Article" tab's and VE's left-most edge should have borders to [Spike,1hr] Consider whether "Article" tab's and VE's left-most edge should have borders.Aug 4 2020, 12:29 AM
Jdlrobson added a project: Spike.
Jdlrobson updated the task description. (Show Details)
Restricted Application changed the subtype of this task from "Task" to "Spike". · View Herald TranscriptAug 4 2020, 12:29 AM

Not quite the same case, but on special pages where we still have full width this looks particularly odd:

image.png (110×204 px, 4 KB)

@alexhollender this seems a priority now given T303549 is ready for development.

since we are updating the tab styling this is no longer relevant. see T309398: Article toolbar styling

logged-out
Screen Shot 2022-06-01 at 12.59.12 PM.png (246×2 px, 43 KB)
logged-in
image.png (260×2 px, 47 KB)