Page MenuHomePhabricator

Create a change tag for edits made using the New Discussion Tool
Closed, ResolvedPublic

Description

This task involves the work with implementing a change tag for edits made with the yet-to-be-deployed New Discussion Tool.

Requirements

  • Change tag(s) are implemented that enable us to:
    • Filter Special:Recent Changes for new sections started with the New Discussion Tool and the input mode – source or visual – that was used to publish said new section
    • Create charts in Superset to monitor how many edits are being made with the New Discussion Tool (e.g. https://superset.wikimedia.org/r/339) and the input mode being used to make said edits
    • Write queries to monitor how many unique people are using the New Discussion Tool and the number of edits they've made with it (e.g. https://quarry.wmflabs.org/query/48614)

Done

  • Change tag(s) are implemented that meet the "Requirements" above

Event Timeline

ppelberg updated the task description. (Show Details)Oct 9 2020, 1:45 AM
ppelberg added a subscriber: DLynch.Oct 9 2020, 1:52 AM

@DLynch does T242184 already implement what this tasking is asking for?

We added a 'discussiontools-newtopic' tag as part of the new topic API patch. It hasn't been used yet because there is no front-end yet.

It's different from the one in that patch, incidentally, because we immediately renamed it in this one.

Notes from this morning's standup

  • @Esanders can you check in the code to see whether a label has been defined for the 'discussiontools-newtopic' tag? And if so, what the label has been defined as?

There's a label, it's defined with:

"tag-discussiontools-newtopic": "Add topic",
"tag-discussiontools-newtopic-description": "User added a new topic to the page with DiscussionTools",

There's a label, it's defined with:

"tag-discussiontools-newtopic": "Add topic",
"tag-discussiontools-newtopic-description": "User added a new topic to the page with DiscussionTools",

Roger that – thank you, David.

For now, can we change the label such that the link text that accompanies edits in a page's history [i] reads: New topic ?

Copying @iamjessklein in case there is an alternative label she thinks we ought to use in the time between now and when we do the holistic copy review we have planned as part of T264220.


i.

Change 637555 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/DiscussionTools@master] Fix label of new topic tag

https://gerrit.wikimedia.org/r/637555

DLynch assigned this task to Esanders.Thu, Oct 29, 8:32 PM
DLynch edited projects, added Skipped QA; removed Patch-For-Review.

Change 637555 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Fix label of new topic tag

https://gerrit.wikimedia.org/r/637555

Is there a way for us to test this?

One thought: spin up a Patch demo with the widget created in T260335 and observe the change tags appended to edits made with said widget.

The answer to @ppelberg's question is yes to verify that edits made with a new discussion tool are being tagged as such @ppelberg can test the demo widget posted to T260335.

https://patchdemo.wmflabs.org/wikis/c76ec2c16d210695a40b03b9f0de9c72/w/index.php?title=Talk:Main_Page&action=history