Create a change tag for edits made using the New Discussion Tool
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ppelberg
	Aug 14 2020, 11:50 PM

Description

This task involves the work with implementing a change tag for edits made with the yet-to-be-deployed New Discussion Tool.

Requirements

Change tag(s) are implemented that enable us to:
- Filter Special:Recent Changes for new sections started with the New Discussion Tool and the input mode – source or visual – that was used to publish said new section
- Create charts in Superset to monitor how many edits are being made with the New Discussion Tool (e.g. https://superset.wikimedia.org/r/339) and the input mode being used to make said edits
- Write queries to monitor how many unique people are using the New Discussion Tool and the number of edits they've made with it (e.g. https://quarry.wmflabs.org/query/48614)

Done

Change tag(s) are implemented that meet the "Requirements" above

Details

	Subject	Repo	Branch	Lines +/-
	Fix label of new topic tag	mediawiki/extensions/DiscussionTools	master	+1 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T233446 [Epic] New Discussion Tool
		Resolved		Esanders	T260467 Create a change tag for edits made using the New Discussion Tool

Event Timeline

ppelberg created this task.Aug 14 2020, 11:50 PM

ppelberg moved this task from Needs Prioritization to Required for Release on the OWC2020 (New Discussion 1.0) board.

ppelberg updated the task description. (Show Details)Oct 9 2020, 1:45 AM

@DLynch does T242184 already implement what this tasking is asking for?

https://quarry.wmflabs.org/query/48526 (see rows ctd_id: 565, 566 and 567) leads me to think T242184 did not implement what this task is asking for
However, I wonder whether the new discussion tag is included within onListDefinedTags (I was looking at this commit: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/567123)

ppelberg added a project: Editing-team (Kanban Board).Oct 9 2020, 1:52 AM

We added a 'discussiontools-newtopic' tag as part of the new topic API patch. It hasn't been used yet because there is no front-end yet.

It's different from the one in that patch, incidentally, because we immediately renamed it in this one.

Notes from this morning's standup

@Esanders can you check in the code to see whether a label has been defined for the 'discussiontools-newtopic' tag? And if so, what the label has been defined as?

There's a label, it's defined with:

"tag-discussiontools-newtopic": "Add topic",
"tag-discussiontools-newtopic-description": "User added a new topic to the page with DiscussionTools",

In T260467#6562080, @DLynch wrote:
There's a label, it's defined with:
"tag-discussiontools-newtopic": "Add topic",
"tag-discussiontools-newtopic-description": "User added a new topic to the page with DiscussionTools",

Roger that – thank you, David.

For now, can we change the label such that the link text that accompanies edits in a page's history [i] reads: New topic ?

Copying @iamjessklein in case there is an alternative label she thinks we ought to use in the time between now and when we do the holistic copy review we have planned as part of T264220.

ppelberg moved this task from Incoming to Upcoming on the Editing-team (Kanban Board) board.Oct 27 2020, 9:57 PM

ppelberg moved this task from Upcoming to Ready to Be Worked On on the Editing-team (Kanban Board) board.Oct 28 2020, 5:01 PM

Change 637555 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/DiscussionTools@master] Fix label of new topic tag

https://gerrit.wikimedia.org/r/637555

gerritbot added a project: Patch-For-Review.Oct 29 2020, 7:46 PM

DLynch assigned this task to Esanders.Oct 29 2020, 8:32 PM

DLynch moved this task from Ready to Be Worked On to Ready for Sign Off on the Editing-team (Kanban Board) board.

DLynch edited projects, added Skipped QA; removed Patch-For-Review.

Change 637555 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Fix label of new topic tag

https://gerrit.wikimedia.org/r/637555

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.16; 2020-11-03).Oct 29 2020, 10:00 PM

Is there a way for us to test this?

One thought: spin up a Patch demo with the widget created in T260335 and observe the change tags appended to edits made with said widget.

The answer to @ppelberg's question is yes to verify that edits made with a new discussion tool are being tagged as such @ppelberg can test the demo widget posted to T260335.

https://patchdemo.wmflabs.org/wikis/c76ec2c16d210695a40b03b9f0de9c72/w/index.php?title=Talk:Main_Page&action=history

In T260467#6603895, @JTannerWMF wrote:

The answer to @ppelberg's question is yes to verify that edits made with a new discussion tool are being tagged as such @ppelberg can test the demo widget posted to T260335.

https://patchdemo.wmflabs.org/wikis/c76ec2c16d210695a40b03b9f0de9c72/w/index.php?title=Talk:Main_Page&action=history

Tag is being added: https://patchdemo.wmflabs.org/wikis/c76ec2c16d210695a40b03b9f0de9c72/w/index.php?title=Talk%3AMain_Page&type=revision&diff=16&oldid=15

ppelberg mentioned this in T269486: Determine what – if any – new events need to be added to the existing section=new workflow.Jan 20 2021, 9:04 PM

ppelberg mentioned this in T279157: Create a hidden change tag for edits made with the new source mode.Apr 2 2021, 4:57 PM

	F32410326: Screen Shot 2020-10-21 at 8.58.41 AM.png
	Oct 21 2020, 4:00 PM

Create a change tag for edits made using the New Discussion ToolClosed, ResolvedPublicActions