Page MenuHomePhabricator

Create a hidden change tag for edits made with the new source mode
Closed, ResolvedPublic

Description

This task is about implementing a hidden [chnage tag]() for edits made with the DiscussionTools' new source mode with tools (T257391).

Use cases

In T276631 we will analyze how people are using the DiscussionTools' new source mode with tools (T257391). To do this analysis, we will need a way to "look at" all of the edits made with said new source mode in aggregate. The change tag this task is asking for should enable us to view these edits in such a way.

//Note: we would like to be able to use these hidden change tags to aggregate edits using the following tools/interfaces: Special:Recent Changes, quarry (e.g. https://quarry.wmflabs.org/query/48614), and superset (e.g. https://superset.wikimedia.org/r/509).//

Requirements

  • A hidden change tag that is "associated with" all edits made in either the New Discussion Tool's or Reply Tool's source mode with tools.
  • This hidden chnage tag should be called: discussiontools-source-enhanced
  • The existing New Discussion Tool and Reply Tool change tags (T242184, T260467) should continue to work as they currently do [i][ii]

Test instructions

  1. Visit: https://en.wikipedia.beta.wmflabs.org/wiki/Special:Preferences#mw-prefsection-editing
  2. Ensure the experimental source mode setting is turned on within the Discussion pages section
  3. Navigate to any talk page on Beta
  4. Open the Reply Tool
  5. Switch to the tool's source mode
  6. Verify the new tools are visible (linking and pinging)
  7. Post a comment
  8. Visit the History page
  9. Confirm the following tags are associated with the edit you made in "Step 7": Reply and Source
  10. Visit Special:Tags
  11. Click the "X changes" link next to the discussiontools-source-enhanced tag
  12. ✅ See the edit you posted in "Step 7." appears within the list of changes

Open questions

  • 1. What happens to this new tag once we converge on a single source mode?
    • As part of converging on a single source mode in T276607, we'll deprecate the hidden tag this task will have implemented and instead use the existing discussiontools-source tag. The work to deprecate this tag will happen in this ticket: T280066. See: /T279157#6995881.

Done

  • ===Requirements are implemented
  • All ===Open questions are answered

i. Edits made with the New Discussion Tool and Reply Tool have the following tags visibly associated with them: New topic and Reply, respectively
i. Edits made with the New Discussion Tool's and Reply Tool's source and visual modes also have the following tags visibly associated with them: Source and Visual, respectively

Event Timeline

ppelberg added a subscriber: Esanders.

During a meeting last week, @Esanders posed this question: "What happens to this new tag once we converge on a single source mode?"

Decision
As part of converging on a single source mode in T276607, we'll deprecate the hidden tag this task will have implemented and instead use the existing discussiontools-source tag. [i]

The work to deprecate this tag will happen in this ticket: T280066.


i. See: https://quarry.wmflabs.org/query/51848

ppelberg updated the task description. (Show Details)

Is discussiontools-source-enhanced ok? It makes a bit more sense in the code.

Is discussiontools-source-enhanced ok? It makes a bit more sense in the code.

Works for me.

Change 680381 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Implement hidden tag for source mode with toolbar

https://gerrit.wikimedia.org/r/680381

Change 680381 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Implement hidden tag for source mode with toolbar

https://gerrit.wikimedia.org/r/680381

matmarex added a project: Editing QA.
matmarex removed a project: Editing QA.
matmarex added a subscriber: matmarex.

Ehm, actually we still need to make this feature available in preferences before this can be tested.

We should enable the feature on beta.

We should enable the feature on beta.

+1. See: T281011.

@matmarex/@Esanders :This doesn't seem to be working in Beta. When I try to filter the recent changes with #discussiontools-source-enhanced, it doesn't show the edit made with Reply tool's experimental source mode. Rather it says "No filters found".

Change 684477 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] NewTopicController: Fix tag list construction

https://gerrit.wikimedia.org/r/684477

@matmarex/@Esanders :This doesn't seem to be working in Beta. When I try to filter the recent changes with #discussiontools-source-enhanced, it doesn't show the edit made with Reply tool's experimental source mode. Rather it says "No filters found".

The tag is hidden so you need to go to [[Special:Tags]] and click on the "X changes" link next to the tag: https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:RecentChanges&tagfilter=discussiontools-source-enhanced

(filed T281741)

Change 684477 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] NewTopicController: Fix tag list construction

https://gerrit.wikimedia.org/r/684477

ppelberg updated the task description. (Show Details)