Page MenuHomePhabricator
Create Task
Maniphest T264391

FeaturedFeedChannel must not contain a User object, since it cannot be serialized safely.
Closed, ResolvedPublic
Actions

Description

FeaturedFeedChannel gets serialized by FeatureFeeds for caching. It contains a User object, which is used to construct ParserOptions in the getFeedItem() method. The solution here would be to pass a User option (or ParserOptiosn) to getFeedItem() as a parameter.

This issue caused a production error, see T264363: Instances of User are not serializable!.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
objectcache: improve async cache key refresh exception loggingmediawiki/coremaster+26 -8
Fix issues with recent caching updatemediawiki/extensions/FeaturedFeedswmf/1.36.0-wmf.30+120 -49
Fix issues with recent caching updatemediawiki/extensions/FeaturedFeedsmaster+11 -6
Revert "Caching fixes"mediawiki/extensions/FeaturedFeedswmf/1.36.0-wmf.30+46 -112
Caching fixesmediawiki/extensions/FeaturedFeedswmf/1.36.0-wmf.29+112 -46
Caching fixesmediawiki/extensions/FeaturedFeedsmaster+112 -46
objectcache: Log more info when WANObjectCache async refresh failsmediawiki/corewmf/1.36.0-wmf.29+11 -1
objectcache: Log more info when WANObjectCache async refresh failsmediawiki/coremaster+11 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

daniel created this task.Oct 2 2020, 7:53 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 2 2020, 7:53 AM
daniel mentioned this in T264363: Instances of User are not serializable!.Oct 2 2020, 7:55 AM
daniel mentioned this in T264393: Mark user object as non-serializable.Oct 2 2020, 7:58 AM
daniel added a parent task: T264393: Mark user object as non-serializable.
BPirkle moved this task from Inbox to Future Initiatives/Small Projects on the Platform Engineering board.Oct 6 2020, 8:41 PM
Naike edited projects, added Platform Engineering Roadmap Decision Making; removed Platform Engineering.Oct 8 2020, 8:49 PM
Naike moved this task from Untriaged to Icebox on the Platform Engineering Roadmap Decision Making board.Nov 16 2020, 3:23 PM
daniel mentioned this in T273242: MemcachedPeclBagOStuff: Serialization of 'Closure' is not allowed.Feb 2 2021, 3:18 PM
taavi added a project: MediaWiki-extensions-FeaturedFeeds.Feb 2 2021, 3:40 PM
taavi subscribed.

FeaturedFeedItem also caches (=serializes) a Title object

gerritbot added a comment.Feb 3 2021, 11:17 AM

Change 661357 had a related patch set uploaded (by Majavah; owner: Majavah):
[mediawiki/extensions/FeaturedFeeds@master] Caching fixes

https://gerrit.wikimedia.org/r/661357

gerritbot added a project: Patch-For-Review.Feb 3 2021, 11:17 AM
gerritbot added a comment.Feb 3 2021, 8:38 PM

Change 661456 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] WANObjectCache: Log more info if async refresh failed.

https://gerrit.wikimedia.org/r/661456

gerritbot added a comment.Feb 5 2021, 1:14 AM

Change 661673 had a related patch set uploaded (by Krinkle; owner: Aaron Schulz):
[mediawiki/core@master] objectcache: improve async cache key refresh exception logging

https://gerrit.wikimedia.org/r/661673

gerritbot added a comment.Feb 8 2021, 10:54 AM

Change 662065 had a related patch set uploaded (by Daniel Kinzler; owner: Ppchelko):
[mediawiki/core@wmf/1.36.0-wmf.29] objectcache: Log more info when WANObjectCache async refresh fails

https://gerrit.wikimedia.org/r/662065

gerritbot added a comment.Feb 8 2021, 11:07 AM

Change 661456 merged by jenkins-bot:
[mediawiki/core@master] objectcache: Log more info when WANObjectCache async refresh fails

https://gerrit.wikimedia.org/r/661456

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.30; 2021-02-09).Feb 8 2021, 12:00 PM
gerritbot added a comment.Feb 8 2021, 12:29 PM

Change 662065 merged by jenkins-bot:
[mediawiki/core@wmf/1.36.0-wmf.29] objectcache: Log more info when WANObjectCache async refresh fails

https://gerrit.wikimedia.org/r/662065

Stashbot added a comment.Feb 8 2021, 12:55 PM

Mentioned in SAL (#wikimedia-operations) [2021-02-08T12:55:27Z] <daniel@deploy1001> Synchronized php-1.36.0-wmf.29/includes/libs/objectcache/wancache/WANObjectCache.php: Backport: [[gerrit:662065|objectcache: Log more info when WANObjectCache async refresh fails]] ([[phab:T264391]]) (duration: 01m 07s)

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.29; 2021-02-02); removed MW-1.36-notes (1.36.0-wmf.30; 2021-02-09).Feb 8 2021, 1:00 PM
gerritbot added a comment.Feb 9 2021, 1:09 AM

Change 661357 merged by jenkins-bot:
[mediawiki/extensions/FeaturedFeeds@master] Caching fixes

https://gerrit.wikimedia.org/r/661357

gerritbot added a comment.Feb 9 2021, 1:13 AM

Change 662677 had a related patch set uploaded (by Tim Starling; owner: Majavah):
[mediawiki/extensions/FeaturedFeeds@wmf/1.36.0-wmf.29] Caching fixes

https://gerrit.wikimedia.org/r/662677

gerritbot added a comment.Feb 9 2021, 1:20 AM

Change 662677 merged by jenkins-bot:
[mediawiki/extensions/FeaturedFeeds@wmf/1.36.0-wmf.29] Caching fixes

https://gerrit.wikimedia.org/r/662677

tstarling closed this task as Resolved.Feb 9 2021, 2:35 AM
tstarling claimed this task.
hashar reopened this task as Open.Feb 9 2021, 2:32 PM
hashar subscribed.

After promoting to group1:

/srv/mediawiki/php-1.36.0-wmf.29/extensions/FeaturedFeeds/includes/FeaturedFeedChannel.php:45
Call to a member function getCode() on string

from /srv/mediawiki/php-1.36.0-wmf.29/extensions/FeaturedFeeds/includes/FeaturedFeedChannel.php(45)
#0 /srv/mediawiki/php-1.36.0-wmf.29/extensions/FeaturedFeeds/includes/FeaturedFeedChannel.php(56): FeaturedFeedChannel->__construct(string, array, string)
#1 /srv/mediawiki/php-1.36.0-wmf.29/extensions/FeaturedFeeds/includes/FeaturedFeeds.php(249): FeaturedFeedChannel::fromArray(array)
#2 /srv/mediawiki/php-1.36.0-wmf.29/extensions/FeaturedFeeds/includes/FeaturedFeeds.php(60): FeaturedFeeds::getFeedsFromCached(array)
#3 /srv/mediawiki/php-1.36.0-wmf.29/extensions/FeaturedFeeds/includes/SpecialFeedItem.php(19): FeaturedFeeds::getFeeds(string)
#4 /srv/mediawiki/php-1.36.0-wmf.29/includes/specialpage/SpecialPage.php(645): SpecialFeedItem->execute(string)
#5 /srv/mediawiki/php-1.36.0-wmf.29/includes/specialpage/SpecialPageFactory.php(1405): SpecialPage->run(string)
#6 /srv/mediawiki/php-1.36.0-wmf.29/includes/MediaWiki.php(310): MediaWiki\SpecialPage\SpecialPageFactory->executePath(Title, RequestContext)
#7 /srv/mediawiki/php-1.36.0-wmf.29/includes/MediaWiki.php(944): MediaWiki->performRequest()
#8 /srv/mediawiki/php-1.36.0-wmf.29/includes/MediaWiki.php(548): MediaWiki->main()
#9 /srv/mediawiki/php-1.36.0-wmf.29/index.php(53): MediaWiki->run()
#10 /srv/mediawiki/php-1.36.0-wmf.29/index.php(46): wfIndexMain()
#11 /srv/mediawiki/w/index.php(3): require(string)
#12 {main}
gerritbot added a comment.Feb 9 2021, 2:45 PM

Change 662985 had a related patch set uploaded (by Majavah; owner: Majavah):
[mediawiki/extensions/FeaturedFeeds@master] Fix issues with recent caching update

https://gerrit.wikimedia.org/r/662985

Stashbot added a comment.Feb 9 2021, 3:06 PM

Mentioned in SAL (#wikimedia-operations) [2021-02-09T15:06:32Z] <hashar@deploy1001> Synchronized php-1.36.0-wmf.29/extensions/FeaturedFeeds: Revert "Caching fixes" T264391 (duration: 01m 25s)

hashar added a parent task: T271343: 1.36.0-wmf.29 deployment blockers.Feb 9 2021, 3:13 PM
RhinosF1 subscribed.Feb 9 2021, 3:15 PM
hashar added a comment.Feb 9 2021, 3:18 PM

We went to revert the caching fix (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FeaturedFeeds/+/662956 ) and I have promoted to group 1 again.

We had ONE occurrence of:

Too few arguments to function FeaturedFeedChannel::__construct(), 3 passed in /srv/mediawiki/php-1.36.0-wmf.29/extensions/FeaturedFeeds/includes/FeaturedFeeds.php on line 214 and exactly 4 expected
/srv/mediawiki/php-1.36.0-wmf.29/extensions/FeaturedFeeds/includes/FeaturedFeedChannel.php:41

from /srv/mediawiki/php-1.36.0-wmf.29/extensions/FeaturedFeeds/includes/FeaturedFeedChannel.php(41)
#0 /srv/mediawiki/php-1.36.0-wmf.29/extensions/FeaturedFeeds/includes/FeaturedFeeds.php(214): FeaturedFeedChannel->__construct(string, array, Language)
#1 /srv/mediawiki/php-1.36.0-wmf.29/extensions/FeaturedFeeds/includes/FeaturedFeeds.php(118): FeaturedFeeds::getFeedsQuick(string)
#2 /srv/mediawiki/php-1.36.0-wmf.29/includes/HookContainer/HookContainer.php(333): FeaturedFeeds::beforePageDisplay(OutputPage, SkinVector)
#3 /srv/mediawiki/php-1.36.0-wmf.29/includes/HookContainer/HookContainer.php(140): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)
#4 /srv/mediawiki/php-1.36.0-wmf.29/includes/HookContainer/HookRunner.php(1003): MediaWiki\HookContainer\HookContainer->run(string, array, array)
#5 /srv/mediawiki/php-1.36.0-wmf.29/includes/OutputPage.php(2618): MediaWiki\HookContainer\HookRunner->onBeforePageDisplay(OutputPage, SkinVector)
#6 /srv/mediawiki/php-1.36.0-wmf.29/includes/MediaWiki.php(951): OutputPage->output(boolean)
#7 /srv/mediawiki/php-1.36.0-wmf.29/includes/MediaWiki.php(964): MediaWiki->{closure}()
#8 /srv/mediawiki/php-1.36.0-wmf.29/includes/MediaWiki.php(548): MediaWiki->main()
#9 /srv/mediawiki/php-1.36.0-wmf.29/index.php(53): MediaWiki->run()
#10 /srv/mediawiki/php-1.36.0-wmf.29/index.php(46): wfIndexMain()
#11 /srv/mediawiki/w/index.php(3): require(string)
#12 {main}

The url for that single error was https://www.mediawiki.org/wiki/MediaWiki

gerritbot added a comment.Feb 9 2021, 4:58 PM

Change 662964 had a related patch set uploaded (by Hashar; owner: Majavah):
[mediawiki/extensions/FeaturedFeeds@wmf/1.36.0-wmf.30] Revert "Caching fixes"

https://gerrit.wikimedia.org/r/662964

hashar added a comment.Feb 9 2021, 6:30 PM

I tried on mwdebug hitting https://fr.wikipedia.org/wiki/Sp%C3%A9cial:FeedItem/featured/20210201000000/fr which apparently was not cached. Tried again after and it was much faster. But that did not result in any log message as far as i can tell :\

gerritbot added a comment.Feb 9 2021, 7:29 PM

Change 662964 merged by jenkins-bot:
[mediawiki/extensions/FeaturedFeeds@wmf/1.36.0-wmf.30] Revert "Caching fixes"

https://gerrit.wikimedia.org/r/662964

gerritbot added a comment.Feb 9 2021, 9:10 PM

Change 662965 had a related patch set uploaded (by 20after4; owner: Majavah):
[mediawiki/extensions/FeaturedFeeds@wmf/1.36.0-wmf.30] Fix issues with recent caching update

https://gerrit.wikimedia.org/r/662965

gerritbot added a comment.Feb 9 2021, 9:13 PM

Change 662985 merged by jenkins-bot:
[mediawiki/extensions/FeaturedFeeds@master] Fix issues with recent caching update

https://gerrit.wikimedia.org/r/662985

gerritbot added a comment.Feb 9 2021, 9:14 PM

Change 662965 abandoned by 20after4:
[mediawiki/extensions/FeaturedFeeds@wmf/1.36.0-wmf.30] Fix issues with recent caching update

Reason:

https://gerrit.wikimedia.org/r/662965

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.31; 2021-02-16); removed MW-1.36-notes (1.36.0-wmf.29; 2021-02-02).Feb 9 2021, 10:00 PM
gerritbot added a comment.Feb 9 2021, 10:18 PM

Change 662965 restored by 20after4:
[mediawiki/extensions/FeaturedFeeds@wmf/1.36.0-wmf.30] Fix issues with recent caching update

https://gerrit.wikimedia.org/r/662965

gerritbot added a comment.Feb 9 2021, 11:01 PM

Change 662965 abandoned by 20after4:
[mediawiki/extensions/FeaturedFeeds@wmf/1.36.0-wmf.30] Fix issues with recent caching update

Reason:

https://gerrit.wikimedia.org/r/662965

gerritbot added a comment.Feb 9 2021, 11:56 PM

Change 662965 restored by Thcipriani:
[mediawiki/extensions/FeaturedFeeds@wmf/1.36.0-wmf.30] Fix issues with recent caching update

https://gerrit.wikimedia.org/r/662965

• mmodell added a parent task: T271344: 1.36.0-wmf.30 deployment blockers.Feb 10 2021, 12:04 AM
gerritbot added a comment.Feb 10 2021, 12:16 AM

Change 662965 merged by jenkins-bot:
[mediawiki/extensions/FeaturedFeeds@wmf/1.36.0-wmf.30] Fix issues with recent caching update

https://gerrit.wikimedia.org/r/662965

Stashbot added a comment.Feb 10 2021, 12:33 AM

Mentioned in SAL (#wikimedia-operations) [2021-02-10T00:33:45Z] <ladsgroup@deploy1001> Synchronized php-1.36.0-wmf.30/extensions/FeaturedFeeds: [[gerrit:662965|Fix issues with recent caching update]] (T264391) (duration: 01m 10s)

Stashbot added a comment.Feb 10 2021, 12:42 AM

Mentioned in SAL (#wikimedia-operations) [2021-02-10T00:42:17Z] <Amir1> changing frwiki to wmf.30 in mwdebug1002 to test T264391

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.30; 2021-02-09); removed MW-1.36-notes (1.36.0-wmf.31; 2021-02-16).Feb 10 2021, 1:00 AM
Jdforrester-WMF subscribed.Feb 10 2021, 4:14 PM

Are we declaring this Resolved?

• mmodell closed this task as Resolved.Feb 10 2021, 8:21 PM
• mmodell subscribed.

I guess so?

gerritbot added a comment.Feb 24 2021, 4:57 AM

Change 661673 abandoned by Aaron Schulz:
[mediawiki/core@master] objectcache: improve async cache key refresh exception logging

Reason:
duplicate

https://gerrit.wikimedia.org/r/661673

kostajh mentioned this in T276301: Tech News web feed no longer working.Mar 3 2021, 10:16 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits