UI Regression: Personal tools menu is appearing unstyled for anonymous users on cached HTML
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	Jdlrobson
	Oct 14 2020, 8:40 PM

Description

NOTE: this error is fixed by action=purge

The personal tools menu is appeared unstyled for anonymous users in wmf.13 because new CSS is being shipped with old HTML and the new CSS is not compatible.

We should halt further roll out of this branch until addressed.

Observed:

Screen Shot 2020-10-14 at 1.37.35 PM.png (1×2 px, 409 KB)

Dump of the HTML which wasn't styled correctly:

<nav id="p-personal" class="vector-menu" aria-labelledby="p-personal-label" role="navigation">
	<h3 id="p-personal-label">
		<span>Personal tools</span>
	</h3>
	<!-- Please do not use the .body class, it is deprecated. -->
	<div class="body vector-menu-content">
		<!-- Please do not use the .menu class, it is deprecated. -->
		<ul class="vector-menu-content-list"><li id="pt-uls" class="active" style="display: none;"><a href="#" class="uls-trigger">English</a></li><li id="pt-anonuserpage">Not logged in</li><li id="pt-anontalk"><a href="/wiki/Special:MyTalk" title="Discussion about edits from this IP address [ctrl-option-n]" accesskey="n">Talk</a></li><li id="pt-anoncontribs"><a href="/wiki/Special:MyContributions" title="A list of edits made from this IP address [ctrl-option-y]" accesskey="y">Contributions</a></li><li id="pt-createaccount"><a href="/w/index.php?title=Special:CreateAccount&amp;returnto=Commons%3ACommunity+portal" title="You are encouraged to create an account and log in; however, it is not mandatory">Create account</a></li><li id="pt-login"><a href="/w/index.php?title=Special:UserLogin&amp;returnto=Commons%3ACommunity+portal" title="You are encouraged to log in; however, it is not mandatory [ctrl-option-o]" accesskey="o">Log in</a></li></ul>
		
	</div>
</nav>
`

Details

	Subject	Repo	Branch	Lines +/-
	Stylesheet needs to be compatible with cached HTML	mediawiki/skins/Vector	wmf/1.36.0-wmf.13	+2 -0
	Stylesheet needs to be compatible with cached HTML	mediawiki/skins/Vector	master	+2 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	• dduvall	T263179 1.36.0-wmf.13 deployment blockers
		Resolved	PRODUCTION ERROR	Jdlrobson	T265543 UI Regression: Personal tools menu is appearing unstyled for anonymous users on cached HTML

Event Timeline

Jdlrobson triaged this task as Unbreak Now! priority.Oct 14 2020, 8:40 PM

Jdlrobson created this task.

Jdlrobson updated the task description. (Show Details)Oct 14 2020, 8:43 PM

This was causing breakage on all the group1 wikis, so Dan rolled back the deployment. I imagine you may need to do a 2-step change to the CSS in order to accommodate server-cached HTML.

Change 634082 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/Vector@master] Stylesheet needs to be compatible with cached HTML

https://gerrit.wikimedia.org/r/634082

Change 634086 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/Vector@wmf/1.36.0-wmf.13] Stylesheet needs to be compatible with cached HTML

https://gerrit.wikimedia.org/r/634086

Change 634082 abandoned by Jdlrobson:
[mediawiki/skins/Vector@master] Stylesheet needs to be compatible with cached HTML

Reason:
Only needed for wmf13

https://gerrit.wikimedia.org/r/634082

It seems we wrote this code under the assumption of a standard train and a week between deployments. Since that's not the case the above patch is needed temporarily for wmf13. By the time wmf14 rolls out cached HTML should not be a problem so I've limited the fix to that branch.

Change 634086 merged by jenkins-bot:
[mediawiki/skins/Vector@wmf/1.36.0-wmf.13] Stylesheet needs to be compatible with cached HTML

https://gerrit.wikimedia.org/r/634086

Mentioned in SAL (#wikimedia-operations) [2020-10-14T21:33:48Z] <thcipriani@deploy1001> Synchronized php-1.36.0-wmf.13/skins/Vector/resources/skins.vector.styles/Menu.less: BACON: [[gerrit:634086|Stylesheet needs to be compatible with cached HTML]] T265543 (duration: 01m 07s)

Jdlrobson closed this task as Resolved.Oct 14 2020, 9:37 PM

Jdlrobson claimed this task.

In T265543#6544416, @Jdlrobson wrote:

It seems we wrote this code under the assumption of a standard train and a week between deployments. Since that's not the case the above patch is needed temporarily for wmf13. By the time wmf14 rolls out cached HTML should not be a problem so I've limited the fix to that branch.

The ParserCache old HTML stays around for 30 days. This will break again next week.

I don't think so, but maybe you know something I don't ? My understanding is this is not parser cache. This is varnish caching for which T124954 suggests TTL is 1 day T124954#3703453 and usually what we assume.

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.13; 2020-10-12).Oct 14 2020, 10:00 PM

In T265543#6544613, @Jdlrobson wrote:

I don't think so, but maybe you know something I don't ? My understanding is this is not parser cache. This is varnish caching for which T124954 suggests TTL is 1 day T124954#3703453 and usually what we assume.

If it's edge cache and not PC, you're right. Ignore my comment then. Thanks.

matmarex mentioned this in T265657: Link text of the Wikipedia sidebar menu bigger than normal.Oct 15 2020, 9:44 PM

Nintendofan885 removed a project: Patch-For-Review.Oct 17 2020, 5:19 PM

Jdlrobson merged a task: T265657: Link text of the Wikipedia sidebar menu bigger than normal.Oct 19 2020, 6:07 PM

Jdlrobson added subscribers: RodneyAraujo, matmarex, Windino and 2 others.

Jdlrobson merged a task: T266337: Personnal tools menu goes crazy .Oct 23 2020, 4:16 PM

Jdlrobson added subscribers: Totostache, Ammarpad.

DannyS712 removed projects: Release, Train Deployments.Nov 2 2020, 9:43 PM