I am still trying to understand what needs to be done to fix T266673. I am surprised that Math uses a JS parser and don't understand this situation yet. However, if we found a way to fix this, one could backport math and do a swat deploy there (or wait for the next train). This seems more straigt forward to me than going back and breaking something else.

This will temporarily break T261071: Malformed input error on text which is not malformed in production again. @Lydia_Pintscher is that acceptable? (We’ll find a proper fix on the master branch, but there is no deployment train next week and a git revert seems like the easiest fix in the meantime.)

Yeah it's not great but let's do it and quickly find a fix for the master branch.

cc @Nikki for info

Reverting this commit only does not help, as it disabled the ability to add / edit statements, therefore, I revert both commit in the same Patch.

Change 638027 had a related patch set uploaded (by Itamar Givon; owner: Itamar Givon):
[mediawiki/extensions/Wikibase@master] Revert JS parser commits

https://gerrit.wikimedia.org/r/638027

But we wanted to revert on the deployment branch (1.36.0-wmf.14 according to https://versions.toolforge.org/), not master…

Change 637801 had a related patch set uploaded (by Itamar Givon; owner: Itamar Givon):
[mediawiki/extensions/Wikibase@wmf/1.36.0-wmf.14] Revert JS parser commits

https://gerrit.wikimedia.org/r/637801

Change 638027 abandoned by Itamar Givon:
[mediawiki/extensions/Wikibase@master] Revert JS parser commits

Reason:
Wrong base branch

https://gerrit.wikimedia.org/r/638027

Change 637801 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@wmf/1.36.0-wmf.14] Revert JS parser commits

https://gerrit.wikimedia.org/r/637801

Mentioned in SAL (#wikimedia-operations) [2020-11-02T13:02:49Z] <lucaswerkmeister-wmde@deploy1001> Synchronized php-1.36.0-wmf.14/extensions/Wikibase: Backport: [[gerrit:637801|Revert JS parser commits (T266671)]] (duration: 01m 09s)

Change 639035 had a related patch set uploaded (by Itamar Givon; owner: Itamar Givon):
[mediawiki/extensions/Wikibase@wmf/1.36.0-wmf.16] Revert JS parser commits

https://gerrit.wikimedia.org/r/639035

Change 639035 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@wmf/1.36.0-wmf.16] Revert JS parser commits

https://gerrit.wikimedia.org/r/639035

Mentioned in SAL (#wikimedia-operations) [2020-11-10T12:04:49Z] <lucaswerkmeister-wmde@deploy1001> Synchronized php-1.36.0-wmf.16/extensions/Wikibase: Backport: [[gerrit:639035|Revert JS parser commits (T266671)]] (duration: 01m 04s)